34c2acc354
CI / benchmark-publish (pull_request) Has been skipped
CI / lint (pull_request) Successful in 3m18s
CI / typecheck (pull_request) Successful in 4m3s
CI / security (pull_request) Successful in 4m13s
CI / build (pull_request) Successful in 21s
CI / quality (pull_request) Successful in 3m42s
CI / integration_tests (pull_request) Successful in 8m50s
CI / unit_tests (pull_request) Successful in 9m14s
CI / e2e_tests (pull_request) Successful in 9m28s
CI / docker (pull_request) Successful in 1m9s
CI / coverage (pull_request) Successful in 10m24s
CI / status-check (pull_request) Successful in 3s
CI / benchmark-regression (pull_request) Successful in 48m36s
CI / build (push) Successful in 22s
CI / lint (push) Successful in 3m43s
CI / typecheck (push) Successful in 4m19s
CI / benchmark-regression (push) Has been skipped
CI / security (push) Successful in 4m28s
CI / quality (push) Successful in 4m21s
CI / integration_tests (push) Successful in 9m12s
CI / e2e_tests (push) Successful in 9m29s
CI / unit_tests (push) Successful in 9m36s
CI / docker (push) Successful in 1m8s
CI / coverage (push) Successful in 10m33s
CI / status-check (push) Successful in 1s
CI / benchmark-publish (push) Successful in 25m40s
Implement the missing runtime logic for the ACMS context tier service. Previously only data models and manual promote()/demote()/evict_lru() methods existed. This commit adds: - Auto-promotion on access: get() now promotes fragments one tier up when access_count reaches the configurable promotion_threshold (default: 5 accesses). The access counter resets after each successful promotion so fragments must accumulate fresh accesses before the next tier transition. - Staleness enforcement: new enforce_staleness() method demotes hot fragments older than hot_ttl (default: 24h) to warm, and warm fragments older than warm_ttl to cold. A snapshot of existing warm-tier IDs prevents double-demotion in a single pass. - Budget enforcement on store and promote: store() and promote() now enforce TierBudget.max_tokens_hot by evicting LRU hot-tier fragments until the token budget is met. The eviction loop uses incremental token tracking to avoid recomputing the sum. - Event emission: Added TIER_PROMOTED, TIER_DEMOTED, TIER_EVICTED event types to EventType enum. All tier transitions emit DomainEvent instances through the optional EventBus. - Configuration: Added context_tier_promotion_threshold, context_tier_hot_ttl_hours, context_tier_warm_ttl_hours settings. The warm TTL setting also accepts the spec-defined env var CLEVERAGENTS_CTX_WARM_HOURS as an alias. - DI wiring: container.py now injects event_bus into context_tier_service. Review fixes applied (code review on PR #1150): - C1: Reset access_count to 0 after each auto-promotion to prevent chain promotion that bypassed the warm tier. - C2: Call _enforce_hot_budget() inside promote() warm-to-hot path so auto-promoted fragments respect the token budget. - H1: Corrected _enforce_hot_budget() docstring: actual complexity is O(n + n*k) not O(n), since min() scans remaining entries on each eviction. - M1: Added CLEVERAGENTS_CTX_WARM_HOURS as an additional env var alias for context_tier_warm_ttl_hours per specification line 30555. Review fixes applied (second code review on PR #1150): - B-CRIT-1: Fixed data loss in promote() warm-to-hot: emit TIER_PROMOTED before _enforce_hot_budget(), and if the promoted fragment is evicted by budget, restore it to the warm tier instead of silently losing it. - B-HIGH-1: Fixed self-eviction on store(): fragments whose token_count exceeds the entire hot-tier budget are now redirected to the warm tier with a warning log. - B-MED-1: Wrapped _emit_tier_event() in try/except so a failing event bus does not break tier operations (best-effort emission). - B-MED-2: Fixed event ordering so TIER_PROMOTED fires before any budget-triggered TIER_EVICTED events. - D-LOW-1: Fixed type hint in Robot helper (dict[str, Callable]). - D-LOW-2: Added __all__ export to context_tiers.py. - S-LOW-1: Added thread-safety docstring note to ContextTierService. Review fixes applied (third code review on PR #1150): - B-MED-1: Added TIER_DEMOTED event emission for oversized fragment redirect in store(), closing the observability gap where the only tier transition without event emission was the hot-to-warm redirect for fragments exceeding the entire hot-tier budget. - S-LOW-1: Added CLEVERAGENTS_CTX_HOT_HOURS as an additional env var alias for context_tier_hot_ttl_hours, for consistency with the warm-tier alias CLEVERAGENTS_CTX_WARM_HOURS. - S-LOW-2: Added docstring note to enforce_staleness() reconciling the hot-tier TTL with the specification statement that hot-tier retention is "Until resource removed" (TTL controls tier placement, not data retention). Review fixes applied (fourth code review on PR #1150): - B-HIGH-1: Reset access_count to 0 on demotion so that demoted fragments must accumulate fresh accesses before re-promotion. Without this reset, a previously popular fragment whose access_count already exceeded the promotion threshold would be re-promoted on the very next get() call, making staleness enforcement ineffective. Review fixes applied (freemo APPROVED review on PR #1150): - #1: Removed all # type: ignore annotations from test files. Fixed _EventCollector, _FailingBus, and _NullBus subscribe() signatures to use Callable[[DomainEvent], None] matching the EventBus protocol. Replaced dict-spread TieredFragment construction with explicit keyword arguments and post-construction assignment. - #2: Extracted runtime policy logic (enforce_staleness, _maybe_auto_promote, _re_fetch_after_promotion, _enforce_hot_budget, _emit_tier_event) into TierRuntimeMixin in tier_runtime.py to reduce context_tiers.py toward the 500-line guideline. - #3: Added fragment_id non-empty validation guard to promote() and demote() per CONTRIBUTING.md argument validation policy. - #8: Renamed _resolve to _re_fetch_after_promotion for clarity. Removed @tdd_expected_fail from TDD tests (Behave + Robot) as the bug is now fixed. All 3 TDD scenarios pass normally. Tests: 27 Behave scenarios (24 feature + 3 TDD), 4 Robot integration tests, 4 ASV benchmark suites. ISSUES CLOSED: #821
140 lines
3.8 KiB
Python
140 lines
3.8 KiB
Python
"""ASV benchmarks for context tier runtime logic (issue #821).
|
|
|
|
Measures the overhead of auto-promotion on access, staleness
|
|
enforcement, and budget-based eviction.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import importlib
|
|
import sys
|
|
from datetime import UTC, datetime, timedelta
|
|
from pathlib import Path
|
|
|
|
# Ensure source tree is importable
|
|
_SRC = str(Path(__file__).resolve().parents[1] / "src")
|
|
if _SRC not in sys.path:
|
|
sys.path.insert(0, _SRC)
|
|
import cleveragents # noqa: E402
|
|
|
|
importlib.reload(cleveragents)
|
|
|
|
from cleveragents.application.services.context_tiers import ( # noqa: E402
|
|
ContextTierService,
|
|
)
|
|
from cleveragents.domain.models.acms.tiers import ( # noqa: E402
|
|
ContextTier,
|
|
TierBudget,
|
|
TieredFragment,
|
|
)
|
|
|
|
|
|
def _make_frag(
|
|
fid: str,
|
|
tier: ContextTier,
|
|
tokens: int = 50,
|
|
last_accessed: datetime | None = None,
|
|
) -> TieredFragment:
|
|
frag = TieredFragment(
|
|
fragment_id=fid,
|
|
content="bench",
|
|
tier=tier,
|
|
token_count=tokens,
|
|
project_name="bench",
|
|
)
|
|
if last_accessed is not None:
|
|
frag.last_accessed = last_accessed
|
|
return frag
|
|
|
|
|
|
class AutoPromotionSuite:
|
|
"""Benchmark auto-promotion on repeated ``get()`` calls."""
|
|
|
|
timeout = 60
|
|
|
|
def setup(self) -> None:
|
|
self.service = ContextTierService(settings=None)
|
|
frag = _make_frag("bench-promote", ContextTier.COLD)
|
|
self.service.store(frag)
|
|
|
|
def time_auto_promote_5_accesses(self) -> None:
|
|
for _ in range(5):
|
|
self.service.get("bench-promote")
|
|
|
|
|
|
class StalenessEnforcementSuite:
|
|
"""Benchmark ``enforce_staleness()`` with varying fragment counts."""
|
|
|
|
timeout = 60
|
|
|
|
def setup(self) -> None:
|
|
self.service = ContextTierService(settings=None)
|
|
stale = datetime.now(tz=UTC) - timedelta(hours=25)
|
|
for i in range(100):
|
|
frag = _make_frag(f"stale-{i:04d}", ContextTier.HOT, last_accessed=stale)
|
|
self.service.store(frag)
|
|
|
|
def time_enforce_staleness_100_fragments(self) -> None:
|
|
self.service.enforce_staleness()
|
|
|
|
|
|
class BudgetEvictionSuite:
|
|
"""Benchmark budget-based eviction on hot-tier overflow."""
|
|
|
|
timeout = 60
|
|
|
|
def setup(self) -> None:
|
|
self.service = ContextTierService(settings=None)
|
|
self.service._budget = TierBudget(max_tokens_hot=500)
|
|
old_time = datetime.now(tz=UTC) - timedelta(minutes=100)
|
|
for i in range(10):
|
|
ts = old_time + timedelta(minutes=i)
|
|
frag = _make_frag(
|
|
f"budget-{i:03d}",
|
|
ContextTier.HOT,
|
|
tokens=50,
|
|
last_accessed=ts,
|
|
)
|
|
self.service.store(frag)
|
|
self.overflow_frag = _make_frag(
|
|
"overflow",
|
|
ContextTier.HOT,
|
|
tokens=50,
|
|
)
|
|
|
|
def time_store_with_budget_eviction(self) -> None:
|
|
self.service.store(self.overflow_frag)
|
|
|
|
|
|
class TierEventEmissionSuite:
|
|
"""Benchmark tier transition event emission overhead."""
|
|
|
|
timeout = 60
|
|
|
|
def setup(self) -> None:
|
|
from collections.abc import Callable
|
|
|
|
from cleveragents.infrastructure.events.models import DomainEvent
|
|
from cleveragents.infrastructure.events.types import EventType
|
|
|
|
class _NullBus:
|
|
def emit(self, event: DomainEvent) -> None:
|
|
pass
|
|
|
|
def subscribe(
|
|
self,
|
|
event_type: EventType,
|
|
handler: Callable[[DomainEvent], None],
|
|
) -> None:
|
|
pass
|
|
|
|
self.service = ContextTierService(
|
|
settings=None,
|
|
event_bus=_NullBus(),
|
|
)
|
|
frag = _make_frag("evt-bench", ContextTier.COLD)
|
|
self.service.store(frag)
|
|
|
|
def time_promote_with_event(self) -> None:
|
|
self.service.promote("evt-bench")
|