hurui200320
2005b8ef82
CI / push-validation (push) Successful in 18s
CI / build (push) Successful in 19s
CI / helm (push) Successful in 24s
CI / lint (push) Successful in 29s
CI / security (push) Successful in 1m11s
CI / e2e_tests (push) Successful in 2m56s
CI / quality (push) Successful in 3m40s
CI / typecheck (push) Successful in 3m59s
CI / integration_tests (push) Successful in 4m3s
CI / unit_tests (push) Successful in 4m55s
CI / docker (push) Successful in 10s
CI / coverage (push) Successful in 10m44s
CI / status-check (push) Successful in 1s
CI / benchmark-regression (push) Has been skipped
CI / benchmark-publish (push) Successful in 1h13m28s
## Summary Replaces all 234 bare `@skip` occurrences across 82 Behave feature files with the correct TDD issue-capture tagging system described in CONTRIBUTING.md § Bug Fix Workflow. Previously, the noxfile ran Behave with `--tags=not @skip`, silently excluding all `@skip`-tagged scenarios from every CI run. These tests never ran, never inverted results via the `@tdd_expected_fail` mechanism, and never contributed to coverage — defeating the purpose of TDD issue-capture testing. Every `@skip` occurrence had a commented-out hint line immediately above it showing the intended proper tags (e.g., `# @tdd_issue @tdd_issue_4272 @tdd_expected_fail @skip`), confirming they were all intended for conversion. ## Changes ### Mechanical conversion (234 replacements across 82 files) - Extracted the proper TDD tags from the comment hint above each `@skip` line, removed `@skip` from the tag set, and replaced the `@skip` line with those tags. - Removed the now-redundant comment hint lines alongside each replacement. ### Bug-fixed scenarios — `@tdd_expected_fail` removed (84 scenarios) - After conversion, ran `nox -s unit_tests` to identify which newly-enabled `@tdd_expected_fail` scenarios now **pass** (their referenced bugs have already been fixed). Removed `@tdd_expected_fail` from those 84 scenarios and their corresponding feature-level tags, leaving only the permanent `@tdd_issue @tdd_issue_<N>` regression-guard tags. - Affected features include: `tdd_tool_runner_env_precedence`, `tdd_automation_profile_session_leak`, `tls_certificate_check`, `project_create_persist`, `resource_type_bootstrap_*`, and 18 others. ### Noxfile cleanup - Removed all four `--tags=not @skip` arguments from `noxfile.py` (unit_tests and coverage sessions). With zero `@skip` tags remaining in the codebase, this filter was dead code and its presence would mislead future maintainers into thinking `@skip` is still a supported escape mechanism. ### Regression guard files - Split the regression guards into two focused files: - `tdd_regression_guards_exec_env.feature` for bug #4281 (exec-env precedence) - `tdd_regression_guards_session_list.feature` for bug #4271 (session list summary) - Each file carries only its own `@tdd_issue` tags at the feature level, avoiding cross-contamination via Behave tag inheritance. The `Background` step (`session-list-summary mock`) only appears in the session-list file where it is actually needed. ### Duplicate tag cleanup - Removed duplicate `@tdd_issue @tdd_issue_4287` tag lines in `tdd_skill_add_regression.feature` (lines 20 and 29). ### Inline comment for retained `@tdd_expected_fail` - Added inline comment in `ci_workflow_validation.feature:134` explaining why this specific #4227 scenario retains `@tdd_expected_fail` despite #4227 being closed (CI YAML does not encode threshold as a machine-readable value). ### Known edge cases — `@tdd_expected_fail` retained (closed issues, fix on master, scenarios still fail) The following issues are **closed** and their fixes **are on master**, but the specific test assertions still fail because the fixes address other aspects of the bugs. The `@tdd_expected_fail` tags are functionally correct and must remain until the specific scenario assertions pass: - `tdd_exec_env_resolution_precedence.feature` — bug #1080 (closed 2026-03-31). The precedence-level-2-vs-4 scenario still fails. - `session_list_summary_dedup.feature` — bug #3046 (closed 2026-04-05). The dedup-consistency scenarios still fail. - `actor_add_update_enforcement.feature` — bug #2609 (closed 2026-04-05). The enforcement scenarios still fail. - `ci_workflow_validation.feature:134` — #4227 (closed 2026-04-08). The CI YAML threshold assertion still fails. ## Verification - `grep -r "@skip" features/ --include="*.feature"` → **zero results** ✓ - `grep -n "tags=not @skip" noxfile.py` → **zero results** ✓ - `nox -s unit_tests` → **629 features passed, 0 failed** ✓ (up from ~545 before this PR) - CI all green (coverage ≥ 97%) ✓ - Integration tests (Robot Framework) do not use `@skip` — confirmed no action needed ✓ - E2E tests (Robot Framework) do not use `@skip` — confirmed no action needed ✓ - `CHANGELOG.md` updated with entry for this change ✓ - `CONTRIBUTORS.md` — Rui Hu already listed ✓ ## Issues Addressed Closes #7025 Co-authored-by: CleverThis <hal9000@cleverthis.com> Reviewed-on: #7221 Reviewed-by: HAL 9000 <HAL9000@cleverthis.com> Reviewed-by: HAL9001 <hal9001@cleverthis.com> Co-authored-by: Rui Hu <rui.hu@cleverthis.com> Co-committed-by: Rui Hu <rui.hu@cleverthis.com>
185 lines
8.7 KiB
Gherkin
185 lines
8.7 KiB
Gherkin
Feature: Automation Profile CLI commands
|
|
As a developer
|
|
I want to manage automation profiles via CLI commands
|
|
So that I can control plan execution autonomy levels
|
|
|
|
Background:
|
|
Given an automation profile CLI runner with mocks
|
|
|
|
# Add command tests
|
|
Scenario: Add profile via config file
|
|
Given a valid automation profile config YAML file
|
|
When I run automation-profile add with --config pointing to the YAML file
|
|
Then the automation-profile add should succeed
|
|
And the automation-profile output should contain "acme/strict"
|
|
|
|
Scenario: Add profile with --update for existing custom profile
|
|
Given a valid automation profile config YAML file
|
|
And the custom profile "acme/strict" already exists
|
|
When I run automation-profile add with --config and --update
|
|
Then the automation-profile add should succeed
|
|
And the automation-profile output should contain "Updated"
|
|
|
|
Scenario: Add profile conflict without --update
|
|
Given a valid automation profile config YAML file
|
|
And the custom profile "acme/strict" already exists
|
|
When I run automation-profile add with --config without --update
|
|
Then the automation-profile command should abort
|
|
And the automation-profile output should contain "Conflict"
|
|
|
|
Scenario: Add profile with missing config file fails
|
|
When I run automation-profile add with --config pointing to a missing file
|
|
Then the automation-profile command should abort
|
|
|
|
Scenario: Add profile with invalid YAML fails
|
|
Given an invalid YAML automation profile config file
|
|
When I run automation-profile add with --config pointing to the invalid YAML file
|
|
Then the automation-profile command should abort
|
|
|
|
Scenario: Add profile with invalid name fails
|
|
Given an automation profile config YAML file with invalid name
|
|
When I run automation-profile add with --config pointing to the invalid name YAML file
|
|
Then the automation-profile command should abort
|
|
|
|
Scenario: Add profile with invalid threshold fails
|
|
Given an automation profile config YAML file with invalid threshold
|
|
When I run automation-profile add with --config pointing to the invalid threshold YAML file
|
|
Then the automation-profile command should abort
|
|
|
|
Scenario: Add profile with legacy threshold keys fails
|
|
Given an automation profile config YAML file with legacy threshold keys
|
|
When I run automation-profile add with --config pointing to the legacy threshold YAML file
|
|
Then the automation-profile command should abort
|
|
And the automation-profile output should contain "auto_strategize"
|
|
|
|
Scenario: Add profile cannot overwrite built-in
|
|
Given an automation profile config YAML file with built-in name "manual"
|
|
When I run automation-profile add with --config pointing to the built-in name YAML file
|
|
Then the automation-profile command should abort
|
|
And the automation-profile output should contain "built-in"
|
|
|
|
Scenario: Add profile with unsupported schema version
|
|
Given an automation profile config YAML file with schema_version "2.0"
|
|
When I run automation-profile add with --config pointing to the unsupported schema YAML file
|
|
Then the automation-profile command should abort
|
|
And the automation-profile output should contain "schema_version"
|
|
|
|
# List command tests
|
|
Scenario: List profiles shows built-in profiles
|
|
When I run automation-profile list
|
|
Then the automation-profile list should succeed
|
|
And the automation-profile output should contain "manual"
|
|
And the automation-profile output should contain "auto"
|
|
|
|
Scenario: List profiles with namespace filter
|
|
Given a custom profile "acme/strict" has been added
|
|
When I run automation-profile list with namespace filter "acme"
|
|
Then the automation-profile list should succeed
|
|
And the automation-profile output should contain "acme/strict"
|
|
|
|
Scenario: List profiles with regex filter
|
|
When I run automation-profile list with regex "caut.*"
|
|
Then the automation-profile list should succeed
|
|
And the automation-profile output should contain "cautious"
|
|
|
|
Scenario: List profiles with invalid regex
|
|
When I run automation-profile list with regex "[invalid"
|
|
Then the automation-profile command should abort
|
|
|
|
Scenario: List profiles with --format json output snapshot
|
|
When I run automation-profile list with --format json
|
|
Then the automation-profile list should succeed
|
|
And the automation-profile json output should contain "profiles"
|
|
And the automation-profile json output should contain "summary"
|
|
And the automation-profile json output should contain "built_in"
|
|
And the automation-profile json output should contain "select_tool"
|
|
|
|
@tdd_issue @tdd_issue_4235 @tdd_expected_fail
|
|
Scenario: List profiles JSON output has spec-required profiles wrapper with summary
|
|
When I run automation-profile list with --format json
|
|
Then the automation-profile list should succeed
|
|
And the automation-profile list json output has profiles wrapper with summary
|
|
|
|
Scenario: List profiles YAML output has spec-required profiles wrapper
|
|
When I run automation-profile list with --format yaml
|
|
Then the automation-profile list should succeed
|
|
And the automation-profile yaml output should contain "profiles:"
|
|
And the automation-profile yaml output should contain "summary:"
|
|
And the automation-profile yaml output should contain "built_in:"
|
|
And the automation-profile yaml output should contain "select_tool:"
|
|
|
|
Scenario: List profiles rich output has Auto-Apply column header
|
|
When I run automation-profile list
|
|
Then the automation-profile list should succeed
|
|
And the automation-profile output should contain "Auto-Ap"
|
|
|
|
Scenario: List profiles rich output has Summary panel
|
|
When I run automation-profile list
|
|
Then the automation-profile list should succeed
|
|
And the automation-profile output should contain "Summary"
|
|
And the automation-profile output should contain "Built-in:"
|
|
|
|
Scenario: List profiles with no matches
|
|
When I run automation-profile list with namespace filter "nonexistent"
|
|
Then the automation-profile output should contain "No profiles found"
|
|
|
|
# Show command tests
|
|
Scenario: Show built-in profile details
|
|
When I run automation-profile show "manual"
|
|
Then the automation-profile show should succeed
|
|
And the automation-profile output should contain "manual"
|
|
And the automation-profile output should contain "1.0"
|
|
|
|
Scenario: Show profile not found
|
|
When I run automation-profile show "nonexistent/profile"
|
|
Then the automation-profile command should abort
|
|
And the automation-profile output should contain "not found"
|
|
|
|
Scenario: Show profile with --format yaml output snapshot
|
|
When I run automation-profile show "manual" with --format yaml
|
|
Then the automation-profile show should succeed
|
|
And the automation-profile yaml output should contain "name: manual"
|
|
And the automation-profile yaml output should contain "decompose_task"
|
|
|
|
Scenario: Show profile with --format json
|
|
When I run automation-profile show "manual" with --format json
|
|
Then the automation-profile show should succeed
|
|
And the automation-profile json output should contain "name"
|
|
|
|
Scenario: Show profile with --format plain
|
|
When I run automation-profile show "manual" with --format plain
|
|
Then the automation-profile show should succeed
|
|
And the automation-profile output should contain "name: manual"
|
|
|
|
Scenario: Show profile with --format table
|
|
When I run automation-profile show "manual" with --format table
|
|
Then the automation-profile show should succeed
|
|
|
|
# Remove command tests
|
|
Scenario: Remove custom profile with confirmation
|
|
Given a custom profile "acme/strict" has been added
|
|
When I run automation-profile remove "acme/strict" with --yes
|
|
Then the automation-profile remove should succeed
|
|
And the automation-profile output should contain "removed"
|
|
|
|
Scenario: Remove built-in profile fails
|
|
When I run automation-profile remove "manual" with --yes
|
|
Then the automation-profile command should abort
|
|
And the automation-profile output should contain "built-in"
|
|
|
|
Scenario: Remove nonexistent profile fails
|
|
When I run automation-profile remove "nonexistent/profile" with --yes
|
|
Then the automation-profile command should abort
|
|
And the automation-profile output should contain "not found"
|
|
|
|
Scenario: Remove profile with --format json
|
|
Given a custom profile "acme/toremove" has been added
|
|
When I run automation-profile remove "acme/toremove" with --yes and --format json
|
|
Then the automation-profile remove should succeed
|
|
And the automation-profile json output should contain "removed"
|
|
|
|
# Legacy flag removal tests
|
|
Scenario: Legacy --automation-level flag is rejected on plan use
|
|
When I invoke plan use with --automation-level "manual"
|
|
Then the plan output should contain "No such option: --automation-level"
|