Files
cleveragents-core/robot/helper_cli_lifecycle.py
hurui200320 414abb1396
CI / benchmark-publish (push) Waiting to run
CI / lint (push) Successful in 19s
CI / build (push) Successful in 20s
CI / quality (push) Successful in 3m49s
CI / typecheck (push) Successful in 3m58s
CI / benchmark-regression (push) Waiting to run
CI / security (push) Successful in 4m7s
CI / integration_tests (push) Successful in 6m48s
CI / unit_tests (push) Successful in 7m30s
CI / docker (push) Successful in 1m12s
CI / e2e_tests (push) Successful in 10m1s
CI / coverage (push) Successful in 11m48s
CI / status-check (push) Successful in 1s
fix(cli): add missing --yes flag to plan apply command (#1127)
## Summary

Adds the `--yes`/`-y` flag to the `lifecycle-apply` CLI command as required by the specification (`agents plan apply [--yes|-y] <PLAN_ID>`). Without `--yes`, a confirmation prompt now displays before proceeding with the destructive Apply phase. With `--yes`, the apply proceeds immediately without prompting.

Closes #932

## Changes

### Source Code
- **`src/cleveragents/cli/commands/plan.py`**: Added `yes: Annotated[bool, typer.Option("--yes", "-y", help="Skip confirmation prompt")] = False` parameter to `lifecycle_apply_plan`. Added `typer.confirm()` prompt before the apply operation, consistent with the pattern used by `rollback_plan`, `correct_plan`, and other destructive commands.
  - Confirmation prompt text matches spec exactly: `"Apply changes for plan {plan_id}?"` producing `Apply changes for plan <ID>? [y/N]:`.
  - Fixed redundant plan ID display when `pre_plan` is `None` — now shows `"Apply changes for plan X?"` instead of `"Apply plan X (X)?"`.
  - Added `except ValueError` handler consistent with sibling commands `lifecycle_execute_plan` and `_lifecycle_apply_with_id`.
  - Added `except Exception` catch-all handler with `isinstance(e, (typer.Abort, typer.Exit))` re-raise guard, consistent with `lifecycle_execute_plan`.
  - Moved `PlanPhase` and `ProcessingState` imports to module level per CONTRIBUTING.md §Import Guidelines.

### TDD Tag Removal (Bug Fix Workflow)
- **`features/tdd_plan_apply_yes_flag.feature`**: Removed `@tdd_expected_fail` tag (leaving `@tdd_bug` and `@tdd_bug_932` as permanent regression guards).
- **`robot/tdd_plan_apply_yes_flag.robot`**: Removed `tdd_expected_fail` tag (leaving `tdd_bug` and `tdd_bug_932`).

### Test Updates
Updated all existing `lifecycle-apply` invocations across 17 test/benchmark files to pass `--yes`, since the new confirmation prompt would otherwise abort in non-interactive test environments:
- 9 Behave step definition files
- 3 Robot Framework helper scripts
- 2 Robot Framework e2e acceptance tests
- 3 ASV benchmark files (4 invocations: `cli_robot_flow_bench.py` ×2, `m1_sourcecode_smoke_bench.py` ×1, `plan_cli_smoke_bench.py` ×1)

### Confirmation Prompt Tests (New + Strengthened)
- **`features/tdd_plan_apply_yes_flag.feature`**: 5 scenarios total:
  - `lifecycle-apply recognises the --yes long flag` — verifies flag acceptance, prompt suppression, exit code 0, and `apply_plan` was called
  - `lifecycle-apply recognises the -y short flag` — same as above for short flag
  - `lifecycle-apply without --yes prompts for confirmation and user declines` — verifies `"Apply cancelled."` message, `exit_code == 0`, and `apply_plan` was NOT called
  - `lifecycle-apply without --yes prompts for confirmation and user accepts` — verifies prompt appears, `exit_code == 0`, and `apply_plan` was called
  - `lifecycle-apply catches unexpected exceptions cleanly` — verifies `"Unexpected error"` output, no traceback leak, non-zero exit code (exercises the `except Exception` catch-all)
- **`features/steps/tdd_plan_apply_yes_flag_steps.py`**: Refactored step definitions:
  - `_make_mock_plan` uses `PlanPhase` and `ProcessingState` enum types instead of raw strings
  - `_make_mock_plan` uses `datetime.now(tz=UTC)` instead of timezone-naive `datetime.now()`
  - Unified prompt suppression step handles both `--yes` and `-y` via parameterised step pattern
  - Added `When` step for unexpected error scenario with `RuntimeError` side_effect
  - Added `Then` step for non-zero exit code assertion
- **Feature/Robot documentation**: Updated stale descriptions that said "implementation does not accept --yes" to reflect the flag is now implemented.

### Documentation
- **`docs/reference/plan_cli.md`**: Updated `lifecycle-apply` section with:
  - `### Synopsis` heading with code block
  - `### Options` table listing `--yes/-y` and `--format/-f` flags
  - `### Arguments` table listing `PLAN_ID`
  - Matches the style used by other command sections in the same file

## Review Fixes (Cycle 3 — Luis's review)

| ID | Severity | Issue | Resolution |
|----|----------|-------|------------|
| M1 | Medium | `typer.Abort()` on user decline produces exit code 1 and redundant "Aborted." | Changed to `raise typer.Exit(0)` — consistent with `correct_decision` and legacy `apply` |
| M2 | Medium | Missing exit code assertion on decline scenario | Added `And the lifecycle-apply exit code should be 0` to the decline scenario |
| M3 | Medium | Spec compliance: "summary of pending changes" not implemented | Deferred — spec example shows summary *after* confirmation, not before; implementation matches spec. Ticket-vs-spec ambiguity noted. |
| L1 | Low | Missing `except Exception` catch-all handler | Added catch-all matching `lifecycle_execute_plan` pattern; re-raises `typer.Abort`/`typer.Exit` |
| L2 | Low | Documentation description not updated | Expanded description in `plan_cli.md` to explain confirmation prompt and `--yes` |
| L3 | Low | Dead code `is not None` guards | Removed both guards — `get_plan()` raises `NotFoundError`, never returns `None` |
| I1 | Info | Duplicate `PlanPhase` import | Hoisted import to top of `try` block, eliminating duplicate at old line 2087 |
| I2 | Info | `typer.confirm` without explicit `default=False` | Added `default=False` for consistency with sibling commands |
| L4 | Low | No test for `--yes` after positional arg | Not addressed — Typer/Click handles both orderings; low risk |
| L5 | Low | No test for auto-select + interactive prompt | Not addressed — separate concern outside ticket scope |
| I3 | Info | Robot helper only tests flag recognition | By design — noted as informational |

## Review Fixes (Cycle 4 — Self-QA)

| ID | Severity | Issue | Resolution |
|----|----------|-------|------------|
| Major-1 | Major | No test for `except Exception` catch-all handler | Added new scenario `"lifecycle-apply catches unexpected exceptions cleanly"` with `RuntimeError` side_effect; asserts `"Unexpected error"` output, no traceback, non-zero exit |
| Minor-2 | Minor | Missing `ValueError` handler inconsistent with siblings | Added `except ValueError as e:` with `"[red]Execution Error:[/red]"` before catch-all, matching `lifecycle_execute_plan` and `_lifecycle_apply_with_id` |
| Minor-3 | Minor | Flag scenarios don't verify `apply_plan` called | Added `And the lifecycle-apply should have called apply` to both `--yes` and `-y` scenarios |
| Minor-4 | Minor | Stale docstring in Robot helper references `tdd_expected_fail` inversion | Updated to reflect bug is fixed and tests serve as regression guards |
| Minor-5 | Minor | `plan_cli.md` lacks Options table for `lifecycle-apply` | Added Synopsis, Options, and Arguments sections matching sibling command style |
| Nit-6 | Nit | Duplicated step defs for `--yes` vs `-y` prompt suppression | Unified into single parameterised step `"the lifecycle-apply {flag} output should not contain the confirmation prompt"` |
| Nit-7 | Nit | `datetime.now()` timezone-naive | Changed to `datetime.now(tz=UTC)` |
| Nit-8 | Nit | `_make_mock_plan` params use `str` instead of enum types | Changed to `PlanPhase` and `ProcessingState` enum types |

## Review Fixes (Cycle 5 — Jeff's approval note)

| ID | Severity | Issue | Resolution |
|----|----------|-------|------------|
| Import-1 | Minor | `PlanPhase`/`ProcessingState` imports inside function body instead of module level | Moved to module-level import per CONTRIBUTING.md §Import Guidelines |

## Known Limitations / Deferred Items

- **M3: Ticket AC mentions "summary of pending changes"** but the spec example only shows `"Apply changes for plan <ID>? [y/N]: y"` without a change summary. The implementation shows plan ID only (matching the spec), not a change summary. This is a ticket-vs-spec ambiguity; recommend discussing with ticket author.
- **Legacy `apply` command** accepts `--yes` but does not pass it to `_lifecycle_apply_with_id()`. This is a pre-existing issue outside the scope of this ticket.
- **`pre_plan is None` branch** has no explicit test. Pre-existing architectural issue; no action taken.

## Quality Gates

| Gate | Result |
|------|--------|
| `nox -s lint` |  passed |
| `nox -s typecheck` |  passed (0 errors) |
| `nox -s unit_tests` |  passed (471 features, 12,424 scenarios, 0 failures) |
| `nox -s integration_tests` |  passed (1,727 tests, 0 failures) |
| `nox -s e2e_tests` |  passed (41 tests, 0 failures) |
| `nox -s coverage_report` |  passed (≥97% coverage) |

Reviewed-on: #1127
Reviewed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com>
Co-authored-by: Rui Hu <rui.hu@cleverthis.com>
Co-committed-by: Rui Hu <rui.hu@cleverthis.com>
2026-03-26 07:50:09 +00:00

426 lines
14 KiB
Python

"""Robot helper for CLI lifecycle E2E with sandbox + ChangeSet verification.
Each subcommand is self-contained and prints a sentinel on success.
Exit code 0 = pass, 1 = failure.
"""
from __future__ import annotations
import os
import shutil
import sys
import tempfile
from datetime import datetime
from pathlib import Path
from typing import NoReturn
from unittest.mock import MagicMock, patch
# Ensure the src directory is on the import path.
_SRC = str(Path(__file__).resolve().parents[1] / "src")
if _SRC not in sys.path:
sys.path.insert(0, _SRC)
from typer.testing import CliRunner # noqa: E402
from cleveragents.cli.commands.action import app as action_app # noqa: E402
from cleveragents.cli.commands.plan import app as plan_app # noqa: E402
from cleveragents.domain.models.core.action import Action, ActionState # noqa: E402
from cleveragents.domain.models.core.change import ( # noqa: E402
ChangeEntry,
ChangeOperation,
InMemoryChangeSetStore,
SpecChangeSet,
)
from cleveragents.domain.models.core.plan import ( # noqa: E402
AutomationProfileProvenance,
AutomationProfileRef,
NamespacedName,
Plan,
PlanIdentity,
PlanPhase,
PlanTimestamps,
ProcessingState,
ProjectLink,
)
runner = CliRunner()
_PLAN_ULID = "01KHDE6WWS2171PWW3GJEBXZ8R"
_VALID_YAML = """\
name: local/lifecycle-action
description: Lifecycle test action
strategy_actor: openai/gpt-4
execution_actor: openai/gpt-4
definition_of_done: All lifecycle tests pass
"""
def _mock_action(name: str = "local/lifecycle-action") -> Action:
"""Create a minimal valid Action."""
return Action(
namespaced_name=NamespacedName.parse(name),
description="Lifecycle test action",
long_description=None,
definition_of_done="All lifecycle tests pass",
strategy_actor="openai/gpt-4",
execution_actor="openai/gpt-4",
state=ActionState.AVAILABLE,
reusable=True,
read_only=False,
created_at=datetime.now(),
updated_at=datetime.now(),
created_by=None,
)
def _mock_plan(
phase: PlanPhase = PlanPhase.STRATEGIZE,
state: ProcessingState = ProcessingState.QUEUED,
plan_id: str = _PLAN_ULID,
) -> Plan:
"""Create a minimal valid Plan."""
now = datetime.now()
return Plan(
identity=PlanIdentity(plan_id=plan_id),
namespaced_name=NamespacedName.parse("local/lifecycle-plan"),
description="Lifecycle test plan",
definition_of_done="Tests pass",
action_name="local/lifecycle-action",
phase=phase,
processing_state=state,
project_links=[ProjectLink(project_name="proj-a")],
arguments={"target_coverage": 80},
arguments_order=["target_coverage"],
automation_profile=AutomationProfileRef(
profile_name="trusted",
provenance=AutomationProfileProvenance.PLAN,
),
strategy_actor="openai/gpt-4",
execution_actor="openai/gpt-4",
reusable=True,
read_only=False,
created_by=None,
timestamps=PlanTimestamps(created_at=now, updated_at=now),
)
def _write_yaml(content: str) -> str:
"""Write YAML content to a temp file and return the path."""
fd, path = tempfile.mkstemp(suffix=".yaml")
with os.fdopen(fd, "w") as fh:
fh.write(content)
return path
def _make_store() -> tuple[InMemoryChangeSetStore, str]:
"""Create an InMemoryChangeSetStore with one changeset started."""
store = InMemoryChangeSetStore()
cid = store.start(_PLAN_ULID)
return store, cid
def _fail(msg: str) -> NoReturn:
"""Print failure message and exit (never returns)."""
print(f"FAIL: {msg}", file=sys.stderr)
raise SystemExit(1)
# ---------------------------------------------------------------------------
# Positive subcommands
# ---------------------------------------------------------------------------
def action_create() -> None:
"""Verify action create from config file."""
svc = MagicMock()
svc.create_action.return_value = _mock_action()
yaml_path = _write_yaml(_VALID_YAML)
try:
with patch(
"cleveragents.cli.commands.action._get_lifecycle_service", return_value=svc
):
result = runner.invoke(action_app, ["create", "--config", yaml_path])
if result.exit_code != 0:
_fail(f"action create rc={result.exit_code}\n{result.output}")
print("robot-lifecycle-action-create-ok")
finally:
os.unlink(yaml_path)
def plan_use_sandbox() -> None:
"""Verify plan use with simulated git_worktree sandbox workspace."""
svc = MagicMock()
svc.get_action_by_name.return_value = _mock_action()
svc.use_action.return_value = _mock_plan()
sandbox_dir = tempfile.mkdtemp(prefix="robot_sandbox_")
try:
sb = Path(sandbox_dir)
(sb / ".git").mkdir()
(sb / "src").mkdir()
(sb / "src" / "main.py").write_text("# placeholder\n")
with patch(
"cleveragents.cli.commands.plan._get_lifecycle_service", return_value=svc
):
result = runner.invoke(
plan_app, ["use", "local/lifecycle-action", "proj-a"]
)
if result.exit_code != 0:
_fail(f"plan use rc={result.exit_code}\n{result.output}")
if not sb.exists():
_fail("sandbox directory missing")
print("robot-lifecycle-plan-use-sandbox-ok")
finally:
shutil.rmtree(sandbox_dir, ignore_errors=True)
def plan_execute_changeset() -> None:
"""Verify plan execute and ChangeSet capture records entries."""
svc = MagicMock()
svc.execute_plan.return_value = _mock_plan(phase=PlanPhase.EXECUTE)
svc.get_plan.return_value = _mock_plan(
phase=PlanPhase.STRATEGIZE, state=ProcessingState.COMPLETE
)
store, cid = _make_store()
store.record(
cid,
ChangeEntry(
plan_id=_PLAN_ULID,
resource_id="res-a",
tool_name="builtin/file-write",
operation=ChangeOperation.CREATE,
path="src/new_module.py",
),
)
with (
patch(
"cleveragents.cli.commands.plan._get_lifecycle_service", return_value=svc
),
patch(
"cleveragents.cli.commands.plan._get_plan_executor",
return_value=MagicMock(),
),
):
result = runner.invoke(plan_app, ["execute", _PLAN_ULID])
if result.exit_code != 0:
_fail(f"plan execute rc={result.exit_code}\n{result.output}")
cs: SpecChangeSet | None = store.get(cid)
if cs is None:
_fail("changeset not found")
if len(cs.entries) != 1:
_fail(f"changeset entry count={len(cs.entries)}")
if cs.entries[0].operation != ChangeOperation.CREATE:
_fail(f"expected CREATE, got {cs.entries[0].operation}")
print("robot-lifecycle-plan-execute-changeset-ok")
def plan_apply_changeset() -> None:
"""Verify plan apply with ChangeSet summary verification."""
svc = MagicMock()
svc.apply_plan.return_value = _mock_plan(phase=PlanPhase.APPLY)
store, cid = _make_store()
store.record(
cid,
ChangeEntry(
plan_id=_PLAN_ULID,
resource_id="res-a",
tool_name="builtin/file-write",
operation=ChangeOperation.CREATE,
path="src/new_module.py",
),
)
store.record(
cid,
ChangeEntry(
plan_id=_PLAN_ULID,
resource_id="res-a",
tool_name="builtin/file-edit",
operation=ChangeOperation.MODIFY,
path="src/existing.py",
),
)
with patch(
"cleveragents.cli.commands.plan._get_lifecycle_service", return_value=svc
):
result = runner.invoke(plan_app, ["lifecycle-apply", "--yes", _PLAN_ULID])
if result.exit_code != 0:
_fail(f"plan apply rc={result.exit_code}\n{result.output}")
summary = store.summarize(cid)
if summary.get("total") != 2:
_fail(f"total={summary.get('total')}")
if summary.get("creates") != 1:
_fail(f"creates={summary.get('creates')}")
if summary.get("modifies") != 1:
_fail(f"modifies={summary.get('modifies')}")
print("robot-lifecycle-plan-apply-changeset-ok")
def full_lifecycle() -> None:
"""End-to-end: action create -> plan use -> execute -> apply with sandbox."""
svc = MagicMock()
svc.create_action.return_value = _mock_action()
svc.get_action_by_name.return_value = _mock_action()
svc.use_action.return_value = _mock_plan()
svc.execute_plan.return_value = _mock_plan(phase=PlanPhase.EXECUTE)
svc.get_plan.return_value = _mock_plan(
phase=PlanPhase.STRATEGIZE, state=ProcessingState.COMPLETE
)
svc.apply_plan.return_value = _mock_plan(phase=PlanPhase.APPLY)
sandbox_dir = tempfile.mkdtemp(prefix="robot_full_sandbox_")
yaml_path = _write_yaml(_VALID_YAML)
store, cid = _make_store()
store.record(
cid,
ChangeEntry(
plan_id=_PLAN_ULID,
resource_id="res-a",
tool_name="builtin/file-write",
operation=ChangeOperation.CREATE,
path="src/generated.py",
),
)
try:
with (
patch(
"cleveragents.cli.commands.action._get_lifecycle_service",
return_value=svc,
),
patch(
"cleveragents.cli.commands.plan._get_lifecycle_service",
return_value=svc,
),
patch(
"cleveragents.cli.commands.plan._get_plan_executor",
return_value=MagicMock(),
),
):
r1 = runner.invoke(action_app, ["create", "--config", yaml_path])
assert r1.exit_code == 0, f"action create: {r1.output}"
r2 = runner.invoke(plan_app, ["use", "local/lifecycle-action", "proj-a"])
assert r2.exit_code == 0, f"plan use: {r2.output}"
r3 = runner.invoke(plan_app, ["execute", _PLAN_ULID])
assert r3.exit_code == 0, f"plan execute: {r3.output}"
r4 = runner.invoke(plan_app, ["lifecycle-apply", "--yes", _PLAN_ULID])
assert r4.exit_code == 0, f"plan apply: {r4.output}"
cs = store.get(cid)
assert cs is not None, "changeset not found"
assert len(cs.entries) == 1, f"entries={len(cs.entries)}"
print("robot-lifecycle-full-e2e-sandbox-ok")
except AssertionError as exc:
_fail(str(exc))
finally:
os.unlink(yaml_path)
shutil.rmtree(sandbox_dir, ignore_errors=True)
# ---------------------------------------------------------------------------
# Negative subcommands
# ---------------------------------------------------------------------------
def invalid_project_name() -> None:
"""Verify invalid project name format is handled."""
svc = MagicMock()
svc.get_action_by_name.return_value = _mock_action()
svc.use_action.side_effect = ValueError("Invalid project name")
with patch(
"cleveragents.cli.commands.plan._get_lifecycle_service", return_value=svc
):
result = runner.invoke(plan_app, ["use", "local/lifecycle-action", "bad name!"])
if (
result.exit_code != 0
or "error" in result.output.lower()
or svc.use_action.called
):
print("robot-lifecycle-invalid-project-name-ok")
else:
_fail("expected error for invalid project name")
def missing_resource() -> None:
"""Verify missing action/resource returns appropriate error."""
from cleveragents.core.exceptions import NotFoundError
svc = MagicMock()
svc.get_action_by_name.side_effect = NotFoundError(
"Action 'local/nonexistent' not found"
)
with patch(
"cleveragents.cli.commands.plan._get_lifecycle_service", return_value=svc
):
result = runner.invoke(plan_app, ["use", "local/nonexistent", "proj-a"])
out = result.output.lower()
if result.exit_code != 0 or "error" in out or "not found" in out:
print("robot-lifecycle-missing-resource-ok")
else:
_fail(f"expected error, rc={result.exit_code}\n{result.output}")
def invalid_arg_format() -> None:
"""Verify --arg without '=' separator is rejected."""
svc = MagicMock()
svc.get_action_by_name.return_value = _mock_action()
with patch(
"cleveragents.cli.commands.plan._get_lifecycle_service", return_value=svc
):
result = runner.invoke(
plan_app,
["use", "local/lifecycle-action", "proj-a", "--arg", "no_equals"],
)
out = result.output.lower()
if (
result.exit_code != 0
or "invalid argument format" in out
or "aborted" in out
):
print("robot-lifecycle-invalid-arg-format-ok")
else:
_fail(f"expected rejection, rc={result.exit_code}\n{result.output}")
# ---------------------------------------------------------------------------
# Main dispatcher
# ---------------------------------------------------------------------------
_COMMANDS: dict[str, object] = {
"action-create": action_create,
"plan-use-sandbox": plan_use_sandbox,
"plan-execute-changeset": plan_execute_changeset,
"plan-apply-changeset": plan_apply_changeset,
"full-lifecycle": full_lifecycle,
"invalid-project-name": invalid_project_name,
"missing-resource": missing_resource,
"invalid-arg-format": invalid_arg_format,
}
def main() -> int:
"""Entry point called by Robot Framework ``Run Process``."""
if len(sys.argv) < 2:
print(f"Usage: helper_cli_lifecycle.py <{'|'.join(_COMMANDS)}>")
return 1
command = sys.argv[1]
handler = _COMMANDS.get(command)
if handler is None:
print(f"Unknown command: {command}")
return 1
handler() # type: ignore[operator]
return 0
if __name__ == "__main__":
sys.exit(main())