freemo
2863b5d1e1
CI / benchmark-publish (pull_request) Has been skipped
CI / docker (pull_request) Has been skipped
CI / status-check (pull_request) Failing after 1s
CI / benchmark-regression (pull_request) Successful in 54m43s
CI / build (pull_request) Successful in 18s
CI / quality (pull_request) Successful in 3m41s
CI / typecheck (pull_request) Successful in 3m55s
CI / security (pull_request) Successful in 4m5s
CI / integration_tests (pull_request) Successful in 24m43s
CI / e2e_tests (pull_request) Failing after 15m40s
CI / coverage (pull_request) Successful in 12m44s
CI / helm (pull_request) Successful in 21s
CI / lint (pull_request) Successful in 3m16s
CI / unit_tests (pull_request) Failing after 6m8s
Implements the first-run experience for the TUI as specified in the specification's 'First-Run Experience' section (§ TUI Architecture). On first launch (no personas configured), a centered ActorSelectionOverlay widget is displayed guiding the user to select an actor. The overlay supports keyboard navigation (j/k), fuzzy search (/), and confirmation (enter). Selecting an actor creates a default persona and dismisses the overlay. Changes: - Add src/cleveragents/tui/first_run.py: is_first_run() detection helper and create_default_persona_for_actor() setup helper - Add src/cleveragents/tui/widgets/actor_selection_overlay.py: ActorSelectionOverlay widget with show/hide/navigate/search/confirm API and render_actor_selection() pure rendering function - Update src/cleveragents/tui/app.py: integrate first-run check in on_mount(), yield ActorSelectionOverlay in compose(), add _complete_first_run() method - Update src/cleveragents/tui/widgets/__init__.py: export ActorSelectionOverlay - Add features/tui_first_run.feature + features/steps/tui_first_run_steps.py: comprehensive Behave BDD tests covering all public API paths ISSUES CLOSED: #1007
197 lines
8.4 KiB
Gherkin
197 lines
8.4 KiB
Gherkin
Feature: TUI first-run experience with actor selection overlay
|
|
The TUI shows an actor selection overlay on first launch when no
|
|
personas are configured. After the user selects an actor a default
|
|
persona is created and the overlay is dismissed.
|
|
|
|
# -----------------------------------------------------------------------
|
|
# is_first_run helper
|
|
# -----------------------------------------------------------------------
|
|
|
|
Scenario: is_first_run returns True when registry has no personas
|
|
Given an empty persona registry
|
|
Then is_first_run should return True
|
|
|
|
Scenario: is_first_run returns False when registry has at least one persona
|
|
Given a persona registry with a default persona using actor "local/mock"
|
|
Then is_first_run should return False
|
|
|
|
# -----------------------------------------------------------------------
|
|
# create_default_persona_for_actor helper
|
|
# -----------------------------------------------------------------------
|
|
|
|
Scenario: create_default_persona_for_actor persists a default persona
|
|
Given an empty persona registry
|
|
When I call create_default_persona_for_actor with actor "anthropic/claude-4-sonnet"
|
|
Then the registry should contain a persona named "default"
|
|
And the default persona actor should be "anthropic/claude-4-sonnet"
|
|
|
|
Scenario: create_default_persona_for_actor sets last persona
|
|
Given an empty persona registry
|
|
When I call create_default_persona_for_actor with actor "openai/gpt-4o"
|
|
Then the registry last persona should be "default"
|
|
|
|
# -----------------------------------------------------------------------
|
|
# render_actor_selection helper
|
|
# -----------------------------------------------------------------------
|
|
|
|
Scenario: render_actor_selection includes welcome header
|
|
When I render the actor selection with default actors
|
|
Then the rendered text should contain "Welcome to CleverAgents"
|
|
|
|
Scenario: render_actor_selection marks the first actor as recommended
|
|
When I render the actor selection with default actors
|
|
Then the rendered text should contain "(recommended)"
|
|
|
|
Scenario: render_actor_selection highlights the selected actor with cursor
|
|
When I render the actor selection with selected index 2
|
|
Then the rendered text should contain a cursor marker
|
|
|
|
Scenario: render_actor_selection shows search prompt when query is empty
|
|
When I render the actor selection with default actors
|
|
Then the rendered text should contain "to search..."
|
|
|
|
Scenario: render_actor_selection shows active search query
|
|
When I render the actor selection with search query "claude"
|
|
Then the rendered text should contain "claude"
|
|
|
|
Scenario: render_actor_selection includes footer keybindings
|
|
When I render the actor selection with default actors
|
|
Then the rendered text should contain "enter Select"
|
|
And the rendered text should contain "j/k Navigate"
|
|
And the rendered text should contain "/ Search"
|
|
|
|
# -----------------------------------------------------------------------
|
|
# ActorSelectionOverlay widget
|
|
# -----------------------------------------------------------------------
|
|
|
|
Scenario: ActorSelectionOverlay starts hidden
|
|
Given a new ActorSelectionOverlay
|
|
Then the overlay should not be visible
|
|
|
|
Scenario: ActorSelectionOverlay show makes it visible
|
|
Given a new ActorSelectionOverlay
|
|
When I call show on the overlay
|
|
Then the overlay should be visible
|
|
|
|
Scenario: ActorSelectionOverlay hide makes it invisible
|
|
Given a new ActorSelectionOverlay
|
|
When I call show on the overlay
|
|
And I call hide on the overlay
|
|
Then the overlay should not be visible
|
|
|
|
Scenario: ActorSelectionOverlay show populates default actors
|
|
Given a new ActorSelectionOverlay
|
|
When I call show on the overlay
|
|
Then the overlay actors list should contain "anthropic/claude-4-sonnet"
|
|
|
|
Scenario: ActorSelectionOverlay show accepts custom actor list
|
|
Given a new ActorSelectionOverlay
|
|
When I call show on the overlay with actors ["local/mock-a", "local/mock-b"]
|
|
Then the overlay actors list should contain "local/mock-a"
|
|
And the overlay actors list should contain "local/mock-b"
|
|
|
|
Scenario: ActorSelectionOverlay move_down advances selection
|
|
Given a new ActorSelectionOverlay
|
|
When I call show on the overlay
|
|
And I call move_down on the overlay
|
|
Then the overlay selected index should be 1
|
|
|
|
Scenario: ActorSelectionOverlay move_up wraps to last item
|
|
Given a new ActorSelectionOverlay
|
|
When I call show on the overlay
|
|
And I call move_up on the overlay
|
|
Then the overlay selected index should be the last index
|
|
|
|
Scenario: ActorSelectionOverlay move_down wraps to first item
|
|
Given a new ActorSelectionOverlay
|
|
When I call show on the overlay
|
|
And I move_down past the last actor
|
|
Then the overlay selected index should be 0
|
|
|
|
Scenario: ActorSelectionOverlay set_search filters actors
|
|
Given a new ActorSelectionOverlay
|
|
When I call show on the overlay
|
|
And I call set_search with query "claude"
|
|
Then the overlay filtered actors should only contain actors matching "claude"
|
|
|
|
Scenario: ActorSelectionOverlay set_search with empty string clears filter
|
|
Given a new ActorSelectionOverlay
|
|
When I call show on the overlay
|
|
And I call set_search with query "claude"
|
|
And I call set_search with query ""
|
|
Then the overlay filtered actors count should equal the full actors count
|
|
|
|
Scenario: ActorSelectionOverlay confirm returns selected actor
|
|
Given a new ActorSelectionOverlay
|
|
When I call show on the overlay
|
|
And I call confirm on the overlay
|
|
Then the confirmed actor should be "anthropic/claude-4-sonnet"
|
|
|
|
Scenario: ActorSelectionOverlay confirm hides the overlay
|
|
Given a new ActorSelectionOverlay
|
|
When I call show on the overlay
|
|
And I call confirm on the overlay
|
|
Then the overlay should not be visible
|
|
|
|
Scenario: ActorSelectionOverlay confirm sets confirmed flag
|
|
Given a new ActorSelectionOverlay
|
|
When I call show on the overlay
|
|
And I call confirm on the overlay
|
|
Then the overlay confirmed flag should be True
|
|
|
|
Scenario: ActorSelectionOverlay confirm on empty filtered list returns None
|
|
Given a new ActorSelectionOverlay
|
|
When I call show on the overlay
|
|
And I call set_search with query "zzz_no_match"
|
|
And I call confirm on the overlay
|
|
Then the confirmed actor should be None
|
|
|
|
Scenario: ActorSelectionOverlay move_down on empty list is a no-op
|
|
Given a new ActorSelectionOverlay
|
|
When I call show on the overlay
|
|
And I call set_search with query "zzz_no_match"
|
|
And I call move_down on the overlay
|
|
Then the overlay selected index should be 0
|
|
|
|
Scenario: ActorSelectionOverlay move_up on empty list is a no-op
|
|
Given a new ActorSelectionOverlay
|
|
When I call show on the overlay
|
|
And I call set_search with query "zzz_no_match"
|
|
And I call move_up on the overlay
|
|
Then the overlay selected index should be 0
|
|
|
|
Scenario: ActorSelectionOverlay selected_actor is None before confirm
|
|
Given a new ActorSelectionOverlay
|
|
When I call show on the overlay
|
|
Then the overlay selected_actor should be None
|
|
|
|
Scenario: ActorSelectionOverlay search_query is empty after show
|
|
Given a new ActorSelectionOverlay
|
|
When I call show on the overlay
|
|
Then the overlay search_query should be ""
|
|
|
|
# -----------------------------------------------------------------------
|
|
# TUI app integration: on_mount shows overlay on first run
|
|
# -----------------------------------------------------------------------
|
|
|
|
Scenario: TUI app shows actor selection overlay on first run
|
|
Given the TUI app is initialised with an empty persona registry
|
|
When I call on_mount on the first-run app
|
|
Then the actor selection overlay should be visible
|
|
|
|
Scenario: TUI app hides actor selection overlay when personas exist
|
|
Given the TUI app is initialised with an existing persona registry
|
|
When I call on_mount on the first-run app
|
|
Then the actor selection overlay should not be visible
|
|
|
|
# -----------------------------------------------------------------------
|
|
# TUI app integration: _complete_first_run
|
|
# -----------------------------------------------------------------------
|
|
|
|
Scenario: _complete_first_run creates default persona and refreshes bar
|
|
Given the TUI app is initialised with an empty persona registry
|
|
When I call on_mount on the first-run app
|
|
And I call _complete_first_run with actor "anthropic/claude-4-sonnet"
|
|
Then the registry should contain a persona named "default"
|
|
And the persona bar should reflect the new actor
|