diff --git a/CHANGELOG.md b/CHANGELOG.md index 99894f63c..c0092b0fb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -673,6 +673,21 @@ _ALL_DATA_COLUMNS + ") " "SELECT " + _ALL_DATA_COLUMNS + " FROM v3_plans"`. contains `{"properties": None}`. The test is tagged `@tdd_expected_fail` and will pass (by inversion) until the underlying bug is fixed. +- **Correction Data Model and Persistence** (#8685): Implemented the complete + correction data model pipeline for decision tree editing, including: domain models + (`CorrectionRequest`, `CorrectionImpact`, `CorrectionResult`, `CorrectionAttempt`, + `CorrectionAttemptRecord`, `CascadeAction`, `CascadeResult`), persistence via + SQLAlchemy repository with full CRUD operations (create, get, list_by_plan, + update_state, delete), state transition validation (pending → executing → + complete|failed), foreign key integrity enforcement, rollback tier depth computation, + and automated `completed_at` timestamp population for terminal states. Includes an + Alembic migration (`m8_001_correction_attempts`) to create the + ``correction_attempts`` table with check constraints on mode and state enums. Full + BDD test coverage across correction flows, service coverage, subtree isolation, + cross-plan cascading, checkpoint rollback wiring, attempt persistence, and model + validation scenarios. Also added ``CORRECTION_APPLIED`` domain event type to the + event bus for audit trailing of applied corrections. + - **Architecture Pool Supervisor Milestone Assignment** (#7521): Added a "PR Workflow for Major Changes" section to the `architecture-pool-supervisor` agent definition documenting the milestone assignment step for spec PRs. The agent now has diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md index 5c06947aa..b93e0f811 100644 --- a/CONTRIBUTORS.md +++ b/CONTRIBUTORS.md @@ -139,3 +139,4 @@ Below are some specific details of individual PR contributions. * HAL 9000 has contributed the plan tree JSON/YAML spec-compliant envelope fix (issue #11041): wrapped `agents plan tree` JSON and YAML output in the spec-required command envelope (`command`, `status`, `exit_code`, `data`, `timing`, `messages`), updated BDD step definitions to validate envelope structure, and removed the `@tdd_expected_fail` tag from the previously-failing JSON tree format test (issue #4254). * HAL 9000 has contributed the a2a session_id validation fix (PR #11098 / issue #9250): moved the session_id validation guard to the top of `_handle_session_close()` in `A2aLocalFacade`, closing the validation bypass path where empty or null session IDs could slip through to devcontainer cleanup when `SessionService` was not wired. * HAL 9000 has contributed ACMS budget enforcement for per-file and cumulative size constraints (PR #9673 / issue #9583): implemented ``BudgetEnforcer``, ``BudgetViolation``, and ``ContextFile`` dataclasses in ``src/cleveragents/acms/budget_enforcement.py`` with full type annotations, ruff linting compliance, 11 BDD Behave scenarios, Robot Framework integration tests, and per-file exclusion + cumulative budget cutoff strategies for max_file_size and max_total_size limits. +* HAL 9000 has contributed the Correction Data Model and Persistence (PR #8685 / issue #8685): complete correction data model pipeline for decision tree editing including `CorrectionRequest`, `CorrectionImpact`, `CorrectionResult`, `CorrectionAttempt`, `CorrectionAttemptRecord`, `CascadeAction`, and `CascadeResult` domain models, SQLAlchemy repository with full CRUD operations (create, get, list_by_plan, update_state, delete), state transition validation, foreign key integrity enforcement, rollback tier depth computation, automated completed_at timestamp population, Alembic migration m8_001_correction_attempts for the correction_attempts table, and comprehensive BDD test coverage across correction flows, service coverage, subtree isolation, cross-plan cascading, checkpoint rollback wiring, attempt persistence, and model validation scenarios.