From 8d7f2103e7f56c18c31dba5458e6566effd7510f Mon Sep 17 00:00:00 2001 From: Jeffrey Phillips Freeman Date: Sun, 5 Apr 2026 08:07:21 +0000 Subject: [PATCH] fix(resource-registry): remove type: ignore[override] suppressions from ResourceDagMixin by restructuring mixin/protocol relationship The two # type: ignore[override] inline suppression comments on the link_child and unlink_child methods of ResourceDagMixin violated the project's strict no-suppression policy in CONTRIBUTING.md. Investigation revealed the suppressions were unnecessary: after removing them, nox -e typecheck passes with 0 errors and 0 warnings. The underlying Pyright type checker already accepts the mixin pattern with self: RegistryHost annotations without any suppression. Both comments are removed with no other changes required. ISSUES CLOSED: #2830 --- .../application/services/_resource_registry_dag.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cleveragents/application/services/_resource_registry_dag.py b/src/cleveragents/application/services/_resource_registry_dag.py index a99edb268..e0c9db7ed 100644 --- a/src/cleveragents/application/services/_resource_registry_dag.py +++ b/src/cleveragents/application/services/_resource_registry_dag.py @@ -44,7 +44,7 @@ class ResourceDagMixin: def link_child( self: RegistryHost, parent_name_or_id: str, child_name_or_id: str - ) -> None: # type: ignore[override] + ) -> None: """Link a child resource to a parent in the DAG. Args: @@ -154,7 +154,7 @@ class ResourceDagMixin: def unlink_child( self: RegistryHost, parent_name_or_id: str, child_name_or_id: str - ) -> None: # type: ignore[override] + ) -> None: """Remove a parent-child link from the DAG. Args: -- 2.52.0