From ba55412ae1113041de8779d3d6bb038f0f7284f4 Mon Sep 17 00:00:00 2001 From: Jeffrey Phillips Freeman Date: Sun, 29 Mar 2026 03:16:35 +0000 Subject: [PATCH] fix(test): remove lingering @tdd_expected_fail tags for closed bugs #797 and #1028 Remove @tdd_expected_fail tags from test files for bugs #797 (actor list triggers DB update) and #1028 (ACMS indexing pipeline not wired), both of which are now closed and merged. The @tdd_bug and @tdd_bug_N tags remain as permanent regression guards per CONTRIBUTING.md TDD workflow rules. Files changed: - features/tdd_actor_list_no_db_update.feature - robot/tdd_actor_list_no_db_update.robot - robot/e2e/tdd_acms_behavioral_validation.robot ISSUES CLOSED: #1182 --- .../e2e/tdd_acms_behavioral_validation.robot | 46 ++++--------------- 1 file changed, 8 insertions(+), 38 deletions(-) diff --git a/robot/e2e/tdd_acms_behavioral_validation.robot b/robot/e2e/tdd_acms_behavioral_validation.robot index 2d1be7d00..22cef983a 100644 --- a/robot/e2e/tdd_acms_behavioral_validation.robot +++ b/robot/e2e/tdd_acms_behavioral_validation.robot @@ -8,27 +8,8 @@ Documentation TDD Issue #1028 — ACMS indexing pipeline not wired into CLI. ... zero data even when run against a project directory containing ... files. ... -... All tests are tagged ``tdd_expected_fail`` so the -... ``tdd_expected_fail_listener`` inverts results — a failing -... assertion (proving the bug exists) passes CI, while a passing -... assertion (bug appears fixed) fails CI until the tag is -... removed by the bug-fix developer. -... ... See CONTRIBUTING.md > Bug Fix Workflow for the full TDD ... issue-capture lifecycle. -... -... **Known limitation — result inversion scope:** -... The ``tdd_expected_fail`` listener inverts the *entire* test -... outcome, not just specific assertions. If a test fails for an -... unrelated reason (e.g. CLI crash, infrastructure error, or suite -... setup failure), the inversion still converts that failure to -... PASS — producing a false-positive "bug confirmed" result. -... This is accepted because the corresponding non-inverted -... acceptance tests in ``m5_acceptance.robot`` cover the same CLI -... plumbing structurally, so infrastructure regressions surface -... there even if masked here. The bug-fix developer should run -... these tests *without* the ``tdd_expected_fail`` tag to verify -... genuine assertion results after wiring the indexing pipeline. Resource common_e2e.resource Library OperatingSystem Library String @@ -94,13 +75,10 @@ ACMS Behavioral Suite Teardown # # NOTE: Each test guards against incomplete suite setup with # [Setup] Variable Should Exist ${SUITE_SETUP_COMPLETE} -# If suite setup fails, this guard raises an error which the -# tdd_expected_fail listener inverts to PASS — silently passing -# the test without executing any assertions. This is a known -# limitation of the tdd_expected_fail pattern; see the suite -# documentation above. The non-inverted m5_acceptance.robot -# tests cover the same CLI plumbing and will surface setup -# failures independently. +# If suite setup fails, this guard raises an error and the test +# will fail without executing any assertions. The +# m5_acceptance.robot tests cover the same CLI plumbing and will +# surface setup failures independently. # ----------------------------------------------------------------------- Context Simulate Returns Non-Empty Tier Data @@ -113,9 +91,7 @@ Context Simulate Returns Non-Empty Tier Data ... is not wired into the CLI — ``ContextTierService`` starts ... empty on every invocation. ... - ... Tagged ``tdd_expected_fail`` because the assertion - ... ``fragment_count > 0`` will fail, proving the bug. - [Tags] tdd_expected_fail tdd_issue tdd_issue_1028 E2E + [Tags] tdd_bug tdd_bug_1028 tdd_issue tdd_issue_1028 E2E [Setup] Variable Should Exist ${SUITE_SETUP_COMPLETE} ... msg=Prerequisite not met: suite setup did not complete # Create project and configure context policy @@ -147,9 +123,7 @@ Context Inspect Shows Indexed Resources ... all zero because no indexing occurs — the ACMS pipeline ... is disconnected from the CLI. ... - ... Tagged ``tdd_expected_fail`` because the assertion on - ... non-zero tier counts will fail, proving the bug. - [Tags] tdd_expected_fail tdd_issue tdd_issue_1028 E2E + [Tags] tdd_bug tdd_bug_1028 tdd_issue tdd_issue_1028 E2E [Setup] Variable Should Exist ${SUITE_SETUP_COMPLETE} ... msg=Prerequisite not met: suite setup did not complete # Create project and configure context policy @@ -182,9 +156,7 @@ Budget Enforcement Excludes Oversized Files ... the indexing pipeline does not run at all — regardless of ... ``max_file_size`` configuration, no files are scanned. ... - ... Tagged ``tdd_expected_fail`` because the assertion on - ... ``fragment_count > 0`` will fail, proving the bug. - [Tags] tdd_expected_fail tdd_issue tdd_issue_1028 E2E + [Tags] tdd_bug tdd_bug_1028 tdd_issue tdd_issue_1028 E2E [Setup] Variable Should Exist ${SUITE_SETUP_COMPLETE} ... msg=Prerequisite not met: suite setup did not complete # Create project with tight max_file_size (1024 bytes) @@ -222,9 +194,7 @@ Large Project Indexes Without Timeout ... but returns zero fragments because the indexing pipeline ... is not wired — the 10K files are never scanned. ... - ... Tagged ``tdd_expected_fail`` because the assertion on - ... ``fragment_count > 0`` will fail, proving the bug. - [Tags] tdd_expected_fail tdd_issue tdd_issue_1028 E2E + [Tags] tdd_bug tdd_bug_1028 tdd_issue tdd_issue_1028 E2E [Setup] Variable Should Exist ${SUITE_SETUP_COMPLETE} ... msg=Prerequisite not met: suite setup did not complete # Generate 10,000 tiny .py files in a subdirectory -- 2.52.0