From 4c465553e6c6eb13361ca0fce075c04cf961c8ae Mon Sep 17 00:00:00 2001 From: CleverThis Date: Thu, 30 Apr 2026 05:32:56 +0000 Subject: [PATCH] fix(container): remove devcontainer-file from CONTAINER_RESOURCE_TYPES devcontainer-file is a read-only config file resource, not a running container. Including it in CONTAINER_RESOURCE_TYPES causes validate_container_available() to return True when only a config file is linked, even though no actual container is available. Closes #10598 --- features/execution_environment.feature | 2 +- robot/helper_execution_environment.py | 2 +- .../application/services/execution_environment_resolver.py | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/features/execution_environment.feature b/features/execution_environment.feature index c439136cc..49907d400 100644 --- a/features/execution_environment.feature +++ b/features/execution_environment.feature @@ -131,7 +131,7 @@ Feature: Execution environment routing Given I import CONTAINER_RESOURCE_TYPES Then it should contain "container-instance" And it should contain "devcontainer-instance" - And it should contain "devcontainer-file" + And it should not contain "devcontainer-file" And it should not contain "git-checkout" # ── ContainerUnavailableError ─────────────────────────────────────── diff --git a/robot/helper_execution_environment.py b/robot/helper_execution_environment.py index 3b8ff1777..8fc2c9967 100644 --- a/robot/helper_execution_environment.py +++ b/robot/helper_execution_environment.py @@ -81,7 +81,7 @@ def _run_resource_types() -> None: """Verify container resource types.""" assert "container-instance" in CONTAINER_RESOURCE_TYPES assert "devcontainer-instance" in CONTAINER_RESOURCE_TYPES - assert "devcontainer-file" in CONTAINER_RESOURCE_TYPES + assert "devcontainer-file" not in CONTAINER_RESOURCE_TYPES assert "git-checkout" not in CONTAINER_RESOURCE_TYPES print("resource-types-ok") diff --git a/src/cleveragents/application/services/execution_environment_resolver.py b/src/cleveragents/application/services/execution_environment_resolver.py index a15691465..3cbb67b81 100644 --- a/src/cleveragents/application/services/execution_environment_resolver.py +++ b/src/cleveragents/application/services/execution_environment_resolver.py @@ -55,7 +55,6 @@ CONTAINER_RESOURCE_TYPES: frozenset[str] = frozenset( { "container-instance", "devcontainer-instance", - "devcontainer-file", } ) -- 2.52.0