[AUTO-INF-5] Fix rentention-days typo in master.yml benchmark jobs — artifacts never expire #9951

New issue

Open

opened 2026-04-16 06:57:38 +00:00 by HAL9000 · 0 comments

HAL9000 commented

2026-04-16 06:57:38 +00:00

Owner

Metadata

Commit message: fix(ci): correct rentention-days typo to retention-days in master.yml benchmark jobs
Branch name: fix/auto-inf-5-retention-days-typo-master-yml

Background and Context

Both artifact upload steps in .forgejo/workflows/master.yml contain a typo: rentention-days instead of the correct retention-days. Because the key is misspelled, Forgejo Actions ignores it and applies the default retention policy (typically unlimited or platform-maximum), causing benchmark artifacts to accumulate indefinitely and consume storage.

In .forgejo/workflows/master.yml, both the benchmark-regression and benchmark-publish jobs have the same typo:

# benchmark-regression job
- name: Upload benchmark artifacts
  if: always()
  uses: actions/upload-artifact@v3
  with:
      name: asv-results-pr
      path: /tmp/asv-results.tar
      rentention-days: 30   # ← TYPO: should be retention-days

# benchmark-publish job
- name: Upload benchmark artifacts
  if: always()
  uses: actions/upload-artifact@v3
  with:
      name: asv-results-pr
      path: /tmp/asv-results.tar
      rentention-days: 30   # ← TYPO: should be retention-days

The correct key name is retention-days (as used correctly in .forgejo/workflows/ci.yml and .forgejo/workflows/nightly-quality.yml). The misspelled key is silently ignored by the actions runner, so artifacts are retained indefinitely.

Expected Behavior

Both artifact upload steps in .forgejo/workflows/master.yml use the correct retention-days key, ensuring benchmark artifacts are automatically deleted after 30 days as intended:

# benchmark-regression job
- name: Upload benchmark artifacts
  if: always()
  uses: actions/upload-artifact@v3
  with:
      name: asv-results-pr
      path: /tmp/asv-results.tar
      retention-days: 30   # ← FIXED

# benchmark-publish job
- name: Upload benchmark artifacts
  if: always()
  uses: actions/upload-artifact@v3
  with:
      name: asv-results-pr
      path: /tmp/asv-results.tar
      retention-days: 30   # ← FIXED

All four workflow files use the correct retention-days key uniformly, and benchmark artifacts expire after 30 days as configured.

Acceptance Criteria

The rentention-days key in the benchmark-regression job's artifact upload step in .forgejo/workflows/master.yml is corrected to retention-days
The rentention-days key in the benchmark-publish job's artifact upload step in .forgejo/workflows/master.yml is corrected to retention-days
No other occurrences of rentention-days exist in any workflow file under .forgejo/workflows/
The corrected workflow file passes CI lint/validation checks
Benchmark artifacts created after the fix are confirmed to have a 30-day expiry set (not unlimited)

Subtasks

Search all files under .forgejo/workflows/ for occurrences of rentention-days to confirm scope
Fix the typo in the benchmark-regression job artifact upload step in master.yml (rentention-days → retention-days)
Fix the typo in the benchmark-publish job artifact upload step in master.yml (rentention-days → retention-days)
Verify no other workflow files contain the same typo
Open a PR with the two-line fix and reference this issue
Confirm CI passes on the PR

Definition of Done

This issue should be closed when:

Both occurrences of rentention-days in .forgejo/workflows/master.yml have been corrected to retention-days
A PR has been merged to the main branch containing only this fix
CI passes on the merged commit
No further occurrences of the rentention-days typo exist anywhere in the .forgejo/workflows/ directory

Summary

Current State

In .forgejo/workflows/master.yml, both the benchmark-regression and benchmark-publish jobs have the same typo:

# benchmark-regression job
- name: Upload benchmark artifacts
  if: always()
  uses: actions/upload-artifact@v3
  with:
      name: asv-results-pr
      path: /tmp/asv-results.tar
      rentention-days: 30   # ← TYPO: should be retention-days

# benchmark-publish job
- name: Upload benchmark artifacts
  if: always()
  uses: actions/upload-artifact@v3
  with:
      name: asv-results-pr
      path: /tmp/asv-results.tar
      rentention-days: 30   # ← TYPO: should be retention-days

Proposed Improvement

Fix the typo in both artifact upload steps in .forgejo/workflows/master.yml:

# benchmark-regression job
- name: Upload benchmark artifacts
  if: always()
  uses: actions/upload-artifact@v3
  with:
      name: asv-results-pr
      path: /tmp/asv-results.tar
      retention-days: 30   # ← FIXED

# benchmark-publish job
- name: Upload benchmark artifacts
  if: always()
  uses: actions/upload-artifact@v3
  with:
      name: asv-results-pr
      path: /tmp/asv-results.tar
      retention-days: 30   # ← FIXED

This is a two-character fix (rentention → retention) in two places.

Expected Impact

Storage hygiene: Benchmark artifacts will be automatically deleted after 30 days as intended, preventing unbounded storage growth.
Consistency: All four workflow files will use the correct retention-days key uniformly.
Cost reduction: Reduced artifact storage consumption on the Forgejo instance.

Duplicate Check

Searched open issues for keywords: rentention, retention, artifact, typo, master.yml, benchmark artifact
Searched closed issues for keywords: rentention, retention, artifact typo, master.yml
Searched for AUTO-INF worker issues (AUTO-INF-1 through AUTO-INF-10): none mention this typo
Searched all open issues pages 1–21 and closed issues pages 1–20 for rentention or artifact retention issues
Result: No duplicates found

Automated by CleverAgents Bot
Agent: new-issue-creator

## Metadata - **Commit message:** `fix(ci): correct rentention-days typo to retention-days in master.yml benchmark jobs` - **Branch name:** `fix/auto-inf-5-retention-days-typo-master-yml` ## Background and Context Both artifact upload steps in `.forgejo/workflows/master.yml` contain a typo: `rentention-days` instead of the correct `retention-days`. Because the key is misspelled, Forgejo Actions ignores it and applies the default retention policy (typically unlimited or platform-maximum), causing benchmark artifacts to accumulate indefinitely and consume storage. In `.forgejo/workflows/master.yml`, both the `benchmark-regression` and `benchmark-publish` jobs have the same typo: ```yaml # benchmark-regression job - name: Upload benchmark artifacts if: always() uses: actions/upload-artifact@v3 with: name: asv-results-pr path: /tmp/asv-results.tar rentention-days: 30 # ← TYPO: should be retention-days # benchmark-publish job - name: Upload benchmark artifacts if: always() uses: actions/upload-artifact@v3 with: name: asv-results-pr path: /tmp/asv-results.tar rentention-days: 30 # ← TYPO: should be retention-days ``` The correct key name is `retention-days` (as used correctly in `.forgejo/workflows/ci.yml` and `.forgejo/workflows/nightly-quality.yml`). The misspelled key is silently ignored by the actions runner, so artifacts are retained indefinitely. ## Expected Behavior Both artifact upload steps in `.forgejo/workflows/master.yml` use the correct `retention-days` key, ensuring benchmark artifacts are automatically deleted after 30 days as intended: ```yaml # benchmark-regression job - name: Upload benchmark artifacts if: always() uses: actions/upload-artifact@v3 with: name: asv-results-pr path: /tmp/asv-results.tar retention-days: 30 # ← FIXED # benchmark-publish job - name: Upload benchmark artifacts if: always() uses: actions/upload-artifact@v3 with: name: asv-results-pr path: /tmp/asv-results.tar retention-days: 30 # ← FIXED ``` All four workflow files use the correct `retention-days` key uniformly, and benchmark artifacts expire after 30 days as configured. ## Acceptance Criteria - [ ] The `rentention-days` key in the `benchmark-regression` job's artifact upload step in `.forgejo/workflows/master.yml` is corrected to `retention-days` - [ ] The `rentention-days` key in the `benchmark-publish` job's artifact upload step in `.forgejo/workflows/master.yml` is corrected to `retention-days` - [ ] No other occurrences of `rentention-days` exist in any workflow file under `.forgejo/workflows/` - [ ] The corrected workflow file passes CI lint/validation checks - [ ] Benchmark artifacts created after the fix are confirmed to have a 30-day expiry set (not unlimited) ## Subtasks - [ ] Search all files under `.forgejo/workflows/` for occurrences of `rentention-days` to confirm scope - [ ] Fix the typo in the `benchmark-regression` job artifact upload step in `master.yml` (`rentention-days` → `retention-days`) - [ ] Fix the typo in the `benchmark-publish` job artifact upload step in `master.yml` (`rentention-days` → `retention-days`) - [ ] Verify no other workflow files contain the same typo - [ ] Open a PR with the two-line fix and reference this issue - [ ] Confirm CI passes on the PR ## Definition of Done This issue should be closed when: 1. Both occurrences of `rentention-days` in `.forgejo/workflows/master.yml` have been corrected to `retention-days` 2. A PR has been merged to the main branch containing only this fix 3. CI passes on the merged commit 4. No further occurrences of the `rentention-days` typo exist anywhere in the `.forgejo/workflows/` directory --- ## Summary Both artifact upload steps in `.forgejo/workflows/master.yml` contain a typo: `rentention-days` instead of the correct `retention-days`. Because the key is misspelled, Forgejo Actions ignores it and applies the default retention policy (typically unlimited or platform-maximum), causing benchmark artifacts to accumulate indefinitely and consume storage. ## Current State In `.forgejo/workflows/master.yml`, both the `benchmark-regression` and `benchmark-publish` jobs have the same typo: ```yaml # benchmark-regression job - name: Upload benchmark artifacts if: always() uses: actions/upload-artifact@v3 with: name: asv-results-pr path: /tmp/asv-results.tar rentention-days: 30 # ← TYPO: should be retention-days # benchmark-publish job - name: Upload benchmark artifacts if: always() uses: actions/upload-artifact@v3 with: name: asv-results-pr path: /tmp/asv-results.tar rentention-days: 30 # ← TYPO: should be retention-days ``` The correct key name is `retention-days` (as used correctly in `.forgejo/workflows/ci.yml` and `.forgejo/workflows/nightly-quality.yml`). The misspelled key is silently ignored by the actions runner, so artifacts are retained indefinitely. ## Proposed Improvement Fix the typo in both artifact upload steps in `.forgejo/workflows/master.yml`: ```yaml # benchmark-regression job - name: Upload benchmark artifacts if: always() uses: actions/upload-artifact@v3 with: name: asv-results-pr path: /tmp/asv-results.tar retention-days: 30 # ← FIXED # benchmark-publish job - name: Upload benchmark artifacts if: always() uses: actions/upload-artifact@v3 with: name: asv-results-pr path: /tmp/asv-results.tar retention-days: 30 # ← FIXED ``` This is a two-character fix (`rentention` → `retention`) in two places. ## Expected Impact - **Storage hygiene**: Benchmark artifacts will be automatically deleted after 30 days as intended, preventing unbounded storage growth. - **Consistency**: All four workflow files will use the correct `retention-days` key uniformly. - **Cost reduction**: Reduced artifact storage consumption on the Forgejo instance. ### Duplicate Check - Searched open issues for keywords: `rentention`, `retention`, `artifact`, `typo`, `master.yml`, `benchmark artifact` - Searched closed issues for keywords: `rentention`, `retention`, `artifact typo`, `master.yml` - Searched for AUTO-INF worker issues (AUTO-INF-1 through AUTO-INF-10): none mention this typo - Searched all open issues pages 1–21 and closed issues pages 1–20 for `rentention` or artifact retention issues - Result: **No duplicates found** --- **Automated by CleverAgents Bot** Agent: new-issue-creator

HAL9000 added the

labels

2026-04-16 07:07:31 +00:00

HAL9000 referenced this issue