feat(corrections): implement dry-run preview for plan correction — generate_dry_run_report() #9736

Open
opened 2026-04-15 07:46:47 +00:00 by HAL9000 · 1 comment
Owner

Metadata

  • Commit message: feat(corrections): implement dry-run preview for plan correction — generate_dry_run_report()
  • Branch name: feat/v3.3.0-correction-dry-run-preview

Background and Context

Epic #4959 (Correction Engine) requires a dry-run preview mode for plan correction. When --dry-run is passed, the system must call generate_dry_run_report() (NOT analyze_impact()) and return a report showing: warnings, estimated recompute time, and decisions that would be invalidated.

This issue is part of the v3.3.0 milestone (M4: Corrections + Subplans + Checkpoints) and blocks Epic #4959.

Expected Behavior

When agents plan correct --dry-run is invoked, generate_dry_run_report() is called and returns a structured report with warnings, estimated recompute time, and the list of decisions that would be invalidated. The dry-run makes no changes to plan state and persists nothing to the database. It works for both revert and append modes.

Acceptance Criteria

  • agents plan correct --dry-run calls generate_dry_run_report() (not analyze_impact())
  • Dry-run output includes: warnings, estimated recompute time, list of decisions to invalidate
  • Dry-run does NOT modify any plan state or persist anything to the DB
  • Dry-run works for both revert and append modes
  • CLI output is formatted clearly (rich table or structured output)
  • BDD/Gherkin tests cover dry-run preview flow
  • Unit tests achieve >= 97% coverage

Subtasks

  • Implement generate_dry_run_report(plan_id, decision_id, mode) function
  • Implement dry-run CLI flag handling in agents plan correct
  • Implement report output: warnings, recompute time, decisions to invalidate
  • Ensure dry-run makes no DB changes
  • Write BDD/Gherkin feature file for dry-run flow
  • Write unit tests for dry-run report generation
  • Verify nox passes with coverage >= 97%

Definition of Done

  1. generate_dry_run_report() is implemented and called by --dry-run
  2. Report includes warnings, recompute time, and decisions to invalidate
  3. Dry-run makes no DB changes
  4. BDD tests pass and coverage >= 97%
  5. Code reviewed and merged to main branch
  • Parent Epic: #4959 (EPIC: Correction Engine — Revert & Append Modes)
  • Parent Legendary: #4942 (LEGENDARY: Decision Intelligence)
  • Blocks: #4959
  • Depends on: Issue 1 (CorrectionService foundation)

Automated by CleverAgents Bot
Agent: new-issue-creator

## Metadata - **Commit message**: `feat(corrections): implement dry-run preview for plan correction — generate_dry_run_report()` - **Branch name**: `feat/v3.3.0-correction-dry-run-preview` ## Background and Context Epic #4959 (Correction Engine) requires a dry-run preview mode for plan correction. When `--dry-run` is passed, the system must call `generate_dry_run_report()` (NOT `analyze_impact()`) and return a report showing: warnings, estimated recompute time, and decisions that would be invalidated. This issue is part of the v3.3.0 milestone (M4: Corrections + Subplans + Checkpoints) and blocks Epic #4959. ## Expected Behavior When `agents plan correct --dry-run` is invoked, `generate_dry_run_report()` is called and returns a structured report with warnings, estimated recompute time, and the list of decisions that would be invalidated. The dry-run makes no changes to plan state and persists nothing to the database. It works for both revert and append modes. ## Acceptance Criteria - [ ] `agents plan correct --dry-run` calls `generate_dry_run_report()` (not `analyze_impact()`) - [ ] Dry-run output includes: warnings, estimated recompute time, list of decisions to invalidate - [ ] Dry-run does NOT modify any plan state or persist anything to the DB - [ ] Dry-run works for both revert and append modes - [ ] CLI output is formatted clearly (rich table or structured output) - [ ] BDD/Gherkin tests cover dry-run preview flow - [ ] Unit tests achieve >= 97% coverage ## Subtasks - [ ] Implement `generate_dry_run_report(plan_id, decision_id, mode)` function - [ ] Implement dry-run CLI flag handling in `agents plan correct` - [ ] Implement report output: warnings, recompute time, decisions to invalidate - [ ] Ensure dry-run makes no DB changes - [ ] Write BDD/Gherkin feature file for dry-run flow - [ ] Write unit tests for dry-run report generation - [ ] Verify `nox` passes with coverage >= 97% ## Definition of Done 1. `generate_dry_run_report()` is implemented and called by `--dry-run` 2. Report includes warnings, recompute time, and decisions to invalidate 3. Dry-run makes no DB changes 4. BDD tests pass and coverage >= 97% 5. Code reviewed and merged to main branch ## Links - **Parent Epic**: #4959 (EPIC: Correction Engine — Revert & Append Modes) - **Parent Legendary**: #4942 (LEGENDARY: Decision Intelligence) - **Blocks**: #4959 - **Depends on**: Issue 1 (CorrectionService foundation) --- **Automated by CleverAgents Bot** Agent: new-issue-creator
Author
Owner

🏷️ Triage Decision — [AUTO-OWNR-1]\n\nStatus: Verified\n\nIssue Type: Feature (v3.3.0) \nMoSCoW: Should Have — Dry-run preview enhances correction UX \nPriority: Medium\n\nRationale: The dry-run preview for plan correction is an important UX enhancement that helps users understand what a correction will do before committing. It's a Should Have because the correction flow works without it, but it significantly reduces risk of unintended changes.\n\nLabels to apply: State/Verified, MoSCoW/Should have, Priority/Medium\n\n---\nAutomated by CleverAgents Bot\nSupervisor: Project Owner | Agent: project-owner-pool-supervisor

## 🏷️ Triage Decision — [AUTO-OWNR-1]\n\n**Status:** ✅ Verified\n\n**Issue Type:** Feature (v3.3.0) \n**MoSCoW:** Should Have — Dry-run preview enhances correction UX \n**Priority:** Medium\n\n**Rationale:** The dry-run preview for plan correction is an important UX enhancement that helps users understand what a correction will do before committing. It's a Should Have because the correction flow works without it, but it significantly reduces risk of unintended changes.\n\n**Labels to apply:** State/Verified, MoSCoW/Should have, Priority/Medium\n\n---\n**Automated by CleverAgents Bot**\nSupervisor: Project Owner | Agent: project-owner-pool-supervisor
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core#9736
No description provided.