[AUTO-GUARD-2] Refactor: Address TODO/FIXME comments in the codebase #9592

Open
opened 2026-04-14 23:43:01 +00:00 by HAL9000 · 1 comment
Owner

Metadata

  • Commit message: refactor: address TODO/FIXME comments in the codebase
  • Branch name: refactor/auto-guard-2-address-todo-fixme-comments

Background and Context

Found a significant number of TODO and FIXME comments in the codebase. These comments indicate areas of technical debt that should be addressed.

Files with TODO/FIXME comments:

/tmp/analysis-agent-20260414-0023456789/repo/docs/reference/lsp_stub.md:151:> **TODO** (M7+): Wire `_dispatch_stub()` through `self._facade`
/tmp/analysis-agent-20260414-0023456789/repo/features/consolidated_domain_models.feature:67:    # TODO: Uncomment when step definitions are implemented
/tmp/analysis-agent-20260414-0023456789/repo/features/consolidated_domain_models.feature:83:    # TODO: Uncomment when step definitions are implemented
/tmp/analysis-agent-20260414-0023456789/repo/features/consolidated_domain_models.feature:94:    # TODO: Uncomment when step definitions are implemented
/tmp/analysis-agent-20260414-0023456789/repo/features/consolidated_routing.feature:848:    # TODO: Uncomment when step definitions are implemented
/tmp/analysis-agent-20260414-0023456789/repo/features/consolidated_routing.feature:856:    # TODO: Uncomment when step definitions are implemented
/tmp/analysis-agent-20260414-0023456789/repo/features/consolidated_routing.feature:865:    # TODO: Uncomment when step definitions are implemented
/tmp/analysis-agent-20260414-0023456789/repo/features/consolidated_routing.feature:874:    # TODO: Uncomment when step definitions are implemented
/tmp/analysis-agent-20260414-0023456789/repo/features/steps/estimation_actor_steps.py:368:    # TODO: Use public save_plan() once test helpers are refactored
/tmp/analysis-agent-20260414-0023456789/repo/features/steps/tdd_exec_env_resolution_precedence_steps.py:82:    # TODO(#1080): The 6-level precedence chain is built manually here
/tmp/analysis-agent-20260414-0023456789/repo/features/wf03_plan_prompt_confidence.feature:17:    # TODO(#885): Verify guidance_added.scope, state_transition, decision_created.type per S15894-15913
/tmp/analysis-agent-20260414-0023456789/repo/robot/e2e/tdd_acms_behavioral_validation.robot:177:  # TODO(bugfix/m5-acms-cli-indexing-pipeline-wiring): After the indexing
/tmp/analysis-agent-20260414-0023456789/repo/robot/e2e/wf12_hierarchical.robot:60:  ...    TODO: Add a second invariant per project once the full invariant
/tmp/analysis-agent-20260414-0023456789/repo/robot/helper_wf03_plan_prompt_confidence.py:95:    # TODO(#885): Verify guidance_added.scope, state_transition,
/tmp/analysis-agent-20260414-0023456789/repo/robot/helper_wf07_cicd.py:472:    # and "automation_profile" (not yet propagated — TODO #1060).
/tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/a2a/facade.py:477:        # TODO: Wire to ACMS ContextAssemblyPipeline once available.
/tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/application/services/cleanup_service.py:311:        # TODO(CONC3): Wire DB session query when Container is
/tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/application/services/cleanup_service.py:319:        # TODO(CONC3): Wire DB session deletion when Container is
/tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/application/services/correction_service.py:282:            # TODO: affected_files and artifacts_to_archive use synthetic
/tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/application/services/llm_actors.py:150:        # TODO(#650): Wire actor-configured response_format into provider calls
/tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/application/services/llm_actors.py:393:        # TODO(#650): Wire actor-configured response_format into provider calls
/tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/application/services/phase_gating.py:79:        # TODO(pg-migration): TOCTOU — The phase is read here but the
/tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/application/services/plan_lifecycle_service.py:354:            # TODO: Replace EstimationStubActor with real actor dispatch
/tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/application/services/service_retry_wiring.py:96:# TODO: This class conflates factory/config, execution, and caching
/tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/application/services/uko_indexer_internals.py:333:    # TODO(#578): integrate real embedding model — placeholder vector
/tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/application/services/uko_loader.py:331:        # TODO(perf): precompute layer index when scaling demands it.
/tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/cli/commands/plan.py:367:            # TODO: derive strategy from plan's actual sandbox configuration
/tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/cli/commands/plan.py:377:            # TODO: derive strategy from plan's actual sandbox configuration
/tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/cli/commands/plan.py:1834:    # TODO: Migrate to EstimationResult.as_display_dict() to reduce duplication
/tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/cli/commands/skill.py:1023:                    # TODO: When MCP adapter integration is available, call
/tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/mcp/adapter.py:611:            # TODO(#882): resource_slots are stored in source_metadata but
/tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/tool/runner.py:295:            # TODO: pass pref.target_resource to the resolver /

Expected Behavior

All TODO and FIXME comments in the codebase are either:

  1. Resolved by implementing the described functionality, or
  2. Converted into tracked issues with proper references, or
  3. Removed if no longer relevant

The codebase should have zero untracked technical debt markers.

Acceptance Criteria

  • Each TODO/FIXME comment is reviewed and categorized (implement, track, or remove)
  • All TODO comments referencing issue numbers (e.g., #650, #882, #1080) are verified to have corresponding open issues
  • TODO comments that can be resolved immediately are resolved in this PR
  • TODO comments requiring future work are converted to tracked issues with proper references
  • No new untracked TODO/FIXME comments are introduced
  • All affected tests pass after changes
  • Test coverage remains >= 97%

Subtasks

  • Audit all 32 TODO/FIXME occurrences listed above
  • Resolve TODO: Uncomment when step definitions are implemented in consolidated_domain_models.feature (lines 67, 83, 94)
  • Resolve TODO: Uncomment when step definitions are implemented in consolidated_routing.feature (lines 848, 856, 865, 874)
  • Implement or track TODO: Use public save_plan() in estimation_actor_steps.py:368
  • Verify issue #1080 exists for tdd_exec_env_resolution_precedence_steps.py:82
  • Verify issue #885 exists for wf03_plan_prompt_confidence.feature:17 and helper_wf03_plan_prompt_confidence.py:95
  • Resolve TODO(bugfix/m5-acms-cli-indexing-pipeline-wiring) in tdd_acms_behavioral_validation.robot:177
  • Resolve TODO: Add a second invariant in wf12_hierarchical.robot:60
  • Verify issue #1060 exists for helper_wf07_cicd.py:472
  • Implement TODO: Wire to ACMS ContextAssemblyPipeline in facade.py:477
  • Implement TODO(CONC3): Wire DB session query/deletion in cleanup_service.py:311,319
  • Resolve TODO: affected_files and artifacts_to_archive use synthetic in correction_service.py:282
  • Verify issue #650 exists for llm_actors.py:150,393
  • Resolve TODO(pg-migration): TOCTOU in phase_gating.py:79
  • Implement TODO: Replace EstimationStubActor in plan_lifecycle_service.py:354
  • Refactor TODO: This class conflates factory/config in service_retry_wiring.py:96
  • Verify issue #578 exists for uko_indexer_internals.py:333
  • Resolve TODO(perf): precompute layer index in uko_loader.py:331
  • Resolve TODO: derive strategy from plan's actual sandbox configuration in plan.py:367,377
  • Resolve TODO: Migrate to EstimationResult.as_display_dict() in plan.py:1834
  • Resolve TODO: When MCP adapter integration is available in skill.py:1023
  • Verify issue #882 exists for adapter.py:611
  • Resolve TODO: pass pref.target_resource to the resolver in runner.py:295
  • Wire _dispatch_stub() through self._facade per lsp_stub.md:151

Definition of Done

This issue is closed when:

  • All 32 TODO/FIXME comments have been reviewed and actioned (resolved, tracked, or removed)
  • All referenced issue numbers have been verified to exist as open issues
  • The codebase compiles and all tests pass with coverage >= 97%
  • A follow-up issue exists for any TODO that requires significant future work
  • The PR has been reviewed and merged

Automated by CleverAgents Bot
Supervisor: Architecture Guard | Agent: architecture-guard-pool-supervisor


Automated by CleverAgents Bot
Agent: new-issue-creator

## Metadata - **Commit message:** `refactor: address TODO/FIXME comments in the codebase` - **Branch name:** `refactor/auto-guard-2-address-todo-fixme-comments` ## Background and Context Found a significant number of `TODO` and `FIXME` comments in the codebase. These comments indicate areas of technical debt that should be addressed. **Files with TODO/FIXME comments:** ``` /tmp/analysis-agent-20260414-0023456789/repo/docs/reference/lsp_stub.md:151:> **TODO** (M7+): Wire `_dispatch_stub()` through `self._facade` /tmp/analysis-agent-20260414-0023456789/repo/features/consolidated_domain_models.feature:67: # TODO: Uncomment when step definitions are implemented /tmp/analysis-agent-20260414-0023456789/repo/features/consolidated_domain_models.feature:83: # TODO: Uncomment when step definitions are implemented /tmp/analysis-agent-20260414-0023456789/repo/features/consolidated_domain_models.feature:94: # TODO: Uncomment when step definitions are implemented /tmp/analysis-agent-20260414-0023456789/repo/features/consolidated_routing.feature:848: # TODO: Uncomment when step definitions are implemented /tmp/analysis-agent-20260414-0023456789/repo/features/consolidated_routing.feature:856: # TODO: Uncomment when step definitions are implemented /tmp/analysis-agent-20260414-0023456789/repo/features/consolidated_routing.feature:865: # TODO: Uncomment when step definitions are implemented /tmp/analysis-agent-20260414-0023456789/repo/features/consolidated_routing.feature:874: # TODO: Uncomment when step definitions are implemented /tmp/analysis-agent-20260414-0023456789/repo/features/steps/estimation_actor_steps.py:368: # TODO: Use public save_plan() once test helpers are refactored /tmp/analysis-agent-20260414-0023456789/repo/features/steps/tdd_exec_env_resolution_precedence_steps.py:82: # TODO(#1080): The 6-level precedence chain is built manually here /tmp/analysis-agent-20260414-0023456789/repo/features/wf03_plan_prompt_confidence.feature:17: # TODO(#885): Verify guidance_added.scope, state_transition, decision_created.type per S15894-15913 /tmp/analysis-agent-20260414-0023456789/repo/robot/e2e/tdd_acms_behavioral_validation.robot:177: # TODO(bugfix/m5-acms-cli-indexing-pipeline-wiring): After the indexing /tmp/analysis-agent-20260414-0023456789/repo/robot/e2e/wf12_hierarchical.robot:60: ... TODO: Add a second invariant per project once the full invariant /tmp/analysis-agent-20260414-0023456789/repo/robot/helper_wf03_plan_prompt_confidence.py:95: # TODO(#885): Verify guidance_added.scope, state_transition, /tmp/analysis-agent-20260414-0023456789/repo/robot/helper_wf07_cicd.py:472: # and "automation_profile" (not yet propagated — TODO #1060). /tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/a2a/facade.py:477: # TODO: Wire to ACMS ContextAssemblyPipeline once available. /tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/application/services/cleanup_service.py:311: # TODO(CONC3): Wire DB session query when Container is /tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/application/services/cleanup_service.py:319: # TODO(CONC3): Wire DB session deletion when Container is /tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/application/services/correction_service.py:282: # TODO: affected_files and artifacts_to_archive use synthetic /tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/application/services/llm_actors.py:150: # TODO(#650): Wire actor-configured response_format into provider calls /tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/application/services/llm_actors.py:393: # TODO(#650): Wire actor-configured response_format into provider calls /tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/application/services/phase_gating.py:79: # TODO(pg-migration): TOCTOU — The phase is read here but the /tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/application/services/plan_lifecycle_service.py:354: # TODO: Replace EstimationStubActor with real actor dispatch /tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/application/services/service_retry_wiring.py:96:# TODO: This class conflates factory/config, execution, and caching /tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/application/services/uko_indexer_internals.py:333: # TODO(#578): integrate real embedding model — placeholder vector /tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/application/services/uko_loader.py:331: # TODO(perf): precompute layer index when scaling demands it. /tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/cli/commands/plan.py:367: # TODO: derive strategy from plan's actual sandbox configuration /tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/cli/commands/plan.py:377: # TODO: derive strategy from plan's actual sandbox configuration /tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/cli/commands/plan.py:1834: # TODO: Migrate to EstimationResult.as_display_dict() to reduce duplication /tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/cli/commands/skill.py:1023: # TODO: When MCP adapter integration is available, call /tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/mcp/adapter.py:611: # TODO(#882): resource_slots are stored in source_metadata but /tmp/analysis-agent-20260414-0023456789/repo/src/cleveragents/tool/runner.py:295: # TODO: pass pref.target_resource to the resolver / ``` ## Expected Behavior All `TODO` and `FIXME` comments in the codebase are either: 1. Resolved by implementing the described functionality, or 2. Converted into tracked issues with proper references, or 3. Removed if no longer relevant The codebase should have zero untracked technical debt markers. ## Acceptance Criteria - [ ] Each `TODO`/`FIXME` comment is reviewed and categorized (implement, track, or remove) - [ ] All `TODO` comments referencing issue numbers (e.g., `#650`, `#882`, `#1080`) are verified to have corresponding open issues - [ ] `TODO` comments that can be resolved immediately are resolved in this PR - [ ] `TODO` comments requiring future work are converted to tracked issues with proper references - [ ] No new untracked `TODO`/`FIXME` comments are introduced - [ ] All affected tests pass after changes - [ ] Test coverage remains >= 97% ## Subtasks - [ ] Audit all 32 TODO/FIXME occurrences listed above - [ ] Resolve `TODO: Uncomment when step definitions are implemented` in `consolidated_domain_models.feature` (lines 67, 83, 94) - [ ] Resolve `TODO: Uncomment when step definitions are implemented` in `consolidated_routing.feature` (lines 848, 856, 865, 874) - [ ] Implement or track `TODO: Use public save_plan()` in `estimation_actor_steps.py:368` - [ ] Verify issue #1080 exists for `tdd_exec_env_resolution_precedence_steps.py:82` - [ ] Verify issue #885 exists for `wf03_plan_prompt_confidence.feature:17` and `helper_wf03_plan_prompt_confidence.py:95` - [ ] Resolve `TODO(bugfix/m5-acms-cli-indexing-pipeline-wiring)` in `tdd_acms_behavioral_validation.robot:177` - [ ] Resolve `TODO: Add a second invariant` in `wf12_hierarchical.robot:60` - [ ] Verify issue #1060 exists for `helper_wf07_cicd.py:472` - [ ] Implement `TODO: Wire to ACMS ContextAssemblyPipeline` in `facade.py:477` - [ ] Implement `TODO(CONC3): Wire DB session query/deletion` in `cleanup_service.py:311,319` - [ ] Resolve `TODO: affected_files and artifacts_to_archive use synthetic` in `correction_service.py:282` - [ ] Verify issue #650 exists for `llm_actors.py:150,393` - [ ] Resolve `TODO(pg-migration): TOCTOU` in `phase_gating.py:79` - [ ] Implement `TODO: Replace EstimationStubActor` in `plan_lifecycle_service.py:354` - [ ] Refactor `TODO: This class conflates factory/config` in `service_retry_wiring.py:96` - [ ] Verify issue #578 exists for `uko_indexer_internals.py:333` - [ ] Resolve `TODO(perf): precompute layer index` in `uko_loader.py:331` - [ ] Resolve `TODO: derive strategy from plan's actual sandbox configuration` in `plan.py:367,377` - [ ] Resolve `TODO: Migrate to EstimationResult.as_display_dict()` in `plan.py:1834` - [ ] Resolve `TODO: When MCP adapter integration is available` in `skill.py:1023` - [ ] Verify issue #882 exists for `adapter.py:611` - [ ] Resolve `TODO: pass pref.target_resource to the resolver` in `runner.py:295` - [ ] Wire `_dispatch_stub()` through `self._facade` per `lsp_stub.md:151` ## Definition of Done This issue is closed when: - All 32 TODO/FIXME comments have been reviewed and actioned (resolved, tracked, or removed) - All referenced issue numbers have been verified to exist as open issues - The codebase compiles and all tests pass with coverage >= 97% - A follow-up issue exists for any TODO that requires significant future work - The PR has been reviewed and merged --- **Automated by CleverAgents Bot** Supervisor: Architecture Guard | Agent: architecture-guard-pool-supervisor --- **Automated by CleverAgents Bot** Agent: new-issue-creator
Author
Owner

[AUTO-OWNR-1] Triage Decision: Verified — MoSCoW/Could Have

Addressing TODO/FIXME comments is a code quality improvement. Could Have — does not block milestone completion.

Priority: Low


Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor


Automated by CleverAgents Bot
Agent: automation-tracking-manager

[AUTO-OWNR-1] **Triage Decision: Verified — MoSCoW/Could Have** Addressing TODO/FIXME comments is a code quality improvement. Could Have — does not block milestone completion. **Priority:** Low --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor --- **Automated by CleverAgents Bot** Agent: automation-tracking-manager
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core#9592
No description provided.