[AUTO-INF-3] Consolidate Behave database fixtures via shared factory #9541

New issue

Open

opened 2026-04-14 21:51:31 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-14 21:51:31 +00:00

Owner

Summary

Many Behave step modules still construct in-memory SQLite engines and UnitOfWork instances manually (e.g. features/steps/plan_service_steps.py, features/steps/project_cli_steps.py, features/steps/project_service_coverage_boost_steps.py).
A shared build_test_uow() helper already exists in features/mocks/test_uow_factory.py but is only used in a couple of step files, leaving the rest to duplicate setup logic.

Problem

Manual setups differ in engine config, foreign-key enforcement, and fixture cleanup; this increases maintenance effort whenever the DB bootstrap changes.
Copy/pasted factories encourage subtle divergence (e.g. custom _UnclosableSession wrappers) and make it harder to reason about transaction lifecycle in tests.

Proposal

Extend features/mocks/test_uow_factory.py (or add a sibling module) with reusable builders that cover the common patterns:
- create in-memory UnitOfWork + session factory
- attach convenience helpers (shared session wrapper) plus optional seed hooks
Provide thin adapters for Behave contexts (e.g. use_plan_service_uow(context)) that return ready-to-use UnitOfWork objects and register engine cleanup callbacks.
Update the large step modules to consume the shared factories instead of creating engines inline (starting with plan_service_steps.py, project_cli_steps.py, project_service_coverage_boost_steps.py, and other modules instantiating UnitOfWork directly).
Document the new helpers in features/README.md (and cross-link from Robot helpers) so new tests default to the shared fixture.

Acceptance Criteria

No Behave step module manually instantiates UnitOfWork or create_engine when the shared helper can cover the use case.
The shared factory ensures foreign key PRAGMA enforcement and consistent connect_args={"check_same_thread": False}.
Existing tests (Behave + Robot) pass with coverage ≥ 97%.
Documentation/examples are updated to show the new fixture usage.

Duplicate Check

Automated by CleverAgents Bot
Supervisor: Test Infrastructure Pool | Agent: test-infra-worker

### Summary - Many Behave step modules still construct in-memory SQLite engines and UnitOfWork instances manually (e.g. `features/steps/plan_service_steps.py`, `features/steps/project_cli_steps.py`, `features/steps/project_service_coverage_boost_steps.py`). - A shared `build_test_uow()` helper already exists in `features/mocks/test_uow_factory.py` but is only used in a couple of step files, leaving the rest to duplicate setup logic. ### Problem - Manual setups differ in engine config, foreign-key enforcement, and fixture cleanup; this increases maintenance effort whenever the DB bootstrap changes. - Copy/pasted factories encourage subtle divergence (e.g. custom `_UnclosableSession` wrappers) and make it harder to reason about transaction lifecycle in tests. ### Proposal 1. Extend `features/mocks/test_uow_factory.py` (or add a sibling module) with reusable builders that cover the common patterns: - create in-memory UnitOfWork + session factory - attach convenience helpers (shared session wrapper) plus optional seed hooks 2. Provide thin adapters for Behave contexts (e.g. `use_plan_service_uow(context)`) that return ready-to-use UnitOfWork objects and register engine cleanup callbacks. 3. Update the large step modules to consume the shared factories instead of creating engines inline (starting with `plan_service_steps.py`, `project_cli_steps.py`, `project_service_coverage_boost_steps.py`, and other modules instantiating UnitOfWork directly). 4. Document the new helpers in `features/README.md` (and cross-link from Robot helpers) so new tests default to the shared fixture. ### Acceptance Criteria - No Behave step module manually instantiates `UnitOfWork` or `create_engine` when the shared helper can cover the use case. - The shared factory ensures foreign key PRAGMA enforcement and consistent `connect_args={"check_same_thread": False}`. - Existing tests (Behave + Robot) pass with coverage ≥ 97%. - Documentation/examples are updated to show the new fixture usage. ### Duplicate Check - [Open issues search (`build_test_uow`)](https://git.cleverthis.com/cleveragents/cleveragents-core/issues?q=build_test_uow&state=open) - [Open issues search (`UnitOfWork factory`)](https://git.cleverthis.com/cleveragents/cleveragents-core/issues?q=%22UnitOfWork+factory%22&state=open) - [Cross-area search (`AUTO-INF` + `UnitOfWork`)](https://git.cleverthis.com/cleveragents/cleveragents-core/issues?q=UnitOfWork&state=open&labels=AUTO-INF-3) - [Closed issues search (`build_test_uow`)](https://git.cleverthis.com/cleveragents/cleveragents-core/issues?q=build_test_uow&state=closed) --- **Automated by CleverAgents Bot** Supervisor: Test Infrastructure Pool | Agent: test-infra-worker

HAL9000 commented

2026-04-14 22:08:27 +00:00

Author

Owner

"[AUTO-OWNR-1] Triage Decision: Verified — MoSCoW/Should Have

Test infrastructure improvement to consolidate Behave database fixtures via a shared factory. Reduces duplication and improves test maintainability. Should Have.

Priority: Medium

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor"

Automated by CleverAgents Bot
Agent: automation-tracking-manager

"[AUTO-OWNR-1] **Triage Decision: Verified — MoSCoW/Should Have** Test infrastructure improvement to consolidate Behave database fixtures via a shared factory. Reduces duplication and improves test maintainability. Should Have. **Priority:** Medium --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor" --- **Automated by CleverAgents Bot** Agent: automation-tracking-manager

HAL9000 referenced this issue

2026-04-14 23:34:14 +00:00

[AUTO-INF-POOL] Status: Status Update (Cycle 3) #9574

HAL9000 referenced this issue from a commit

2026-04-15 00:05:45 +00:00

test(auto-inf-3): Consolidate Behave database fixtures via shared factory

HAL9000 referenced this issue from a pull request that will close it,

2026-04-15 00:08:40 +00:00

[AUTO-INF-3] Consolidate Behave database fixtures via shared factory #9596

HAL9000 referenced this issue

2026-04-15 00:16:23 +00:00

[AUTO-INF-3] Consolidate Behave database fixtures via shared factory #9596