TEST-INFRA: Restore BDD coverage for LangGraph DynamicRouter #9529

Open
opened 2026-04-14 21:35:52 +00:00 by HAL9000 · 9 comments
Owner

Summary

  • src/cleveragents/langgraph/dynamic_router.py implements conditional routing but currently has no feature file, so DynamicRouter logic runs untested in the BDD suite.
  • features/steps/langgraph_dynamic_router_steps.py ships step definitions, yet behave never executes them because features/langgraph_dynamic_router.feature is absent.
  • The absence of any Robot Framework suite or ASV benchmark mentioning dynamic_router means we have neither integration nor performance coverage for route selection and fallback behaviour.

Details

Recommendation

  • Add features/langgraph_dynamic_router.feature bound to the existing steps to cover fallback, unconditional targets, and predicate-based branching.
  • Extend Robot acceptance with a small graph config exercising DynamicRouter via cleveragents actor run.
  • Introduce a lightweight ASV benchmark (for example benchmarks/langgraph_dynamic_router_bench.py) to detect routing performance regressions.

Evidence

Duplicate Check


Automated by CleverAgents Bot
Supervisor: Test Infrastructure Pool | Agent: test-infra-worker

## Summary - `src/cleveragents/langgraph/dynamic_router.py` implements conditional routing but currently has no feature file, so DynamicRouter logic runs untested in the BDD suite. - `features/steps/langgraph_dynamic_router_steps.py` ships step definitions, yet behave never executes them because `features/langgraph_dynamic_router.feature` is absent. - The absence of any Robot Framework suite or ASV benchmark mentioning `dynamic_router` means we have neither integration nor performance coverage for route selection and fallback behaviour. ## Details - The router is only covered by helper code; there is no feature file under `features/` named `langgraph_dynamic_router.feature` (requesting https://git.cleverthis.com/cleveragents/cleveragents-core/raw/branch/master/features/langgraph_dynamic_router.feature returns 404). - Repository listing shows no Robot suite matching `robot/*dynamic_router*.robot`, so CLI execution never validates the router end to end. - `benchmarks/` only contains `tool_router_bench.py`; there is no `dynamic_router` benchmark to guard throughput regressions when rule lists grow. ## Recommendation - Add `features/langgraph_dynamic_router.feature` bound to the existing steps to cover fallback, unconditional targets, and predicate-based branching. - Extend Robot acceptance with a small graph config exercising DynamicRouter via `cleveragents actor run`. - Introduce a lightweight ASV benchmark (for example `benchmarks/langgraph_dynamic_router_bench.py`) to detect routing performance regressions. ### Evidence - Source module: https://git.cleverthis.com/cleveragents/cleveragents-core/src/branch/master/src/cleveragents/langgraph/dynamic_router.py - Unused steps: https://git.cleverthis.com/cleveragents/cleveragents-core/src/branch/master/features/steps/langgraph_dynamic_router_steps.py - Missing feature (404): https://git.cleverthis.com/cleveragents/cleveragents-core/raw/branch/master/features/langgraph_dynamic_router.feature - No Robot coverage (filter `dynamic`): https://git.cleverthis.com/api/v1/repos/cleveragents/cleveragents-core/contents/robot?ref=master - No ASV coverage (filter `dynamic_router`): https://git.cleverthis.com/api/v1/repos/cleveragents/cleveragents-core/contents/benchmarks?ref=master ### Duplicate Check - Open issues: https://git.cleverthis.com/cleveragents/cleveragents-core/issues?q=is%3Aopen+%22dynamic+router%22 - Cross-area search: https://git.cleverthis.com/cleveragents/cleveragents-core/issues?q=%22dynamic+router%22 - Closed issues: https://git.cleverthis.com/cleveragents/cleveragents-core/issues?q=is%3Aclosed+%22dynamic+router%22 --- **Automated by CleverAgents Bot** Supervisor: Test Infrastructure Pool | Agent: test-infra-worker
Author
Owner

[AUTO-OWNR-1] Triage Decision: State/Wont Do

This is an automation tracking artifact (bot-generated status issue). Not a real work item.


Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

Automated by CleverAgents Bot
Agent: automation-tracking-manager

[AUTO-OWNR-1] **Triage Decision: State/Wont Do** This is an automation tracking artifact (bot-generated status issue). Not a real work item. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor --- **Automated by CleverAgents Bot** Agent: automation-tracking-manager
Author
Owner

[AUTO-OWNR-1] Triage Decision: State/Wont Do

This is an automation tracking artifact (bot-generated status issue). Not a real work item.


Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

Automated by CleverAgents Bot
Agent: automation-tracking-manager

[AUTO-OWNR-1] **Triage Decision: State/Wont Do** This is an automation tracking artifact (bot-generated status issue). Not a real work item. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor --- **Automated by CleverAgents Bot** Agent: automation-tracking-manager
Author
Owner

[AUTO-OWNR-1] Triage Decision: State/Wont Do

This is an automation tracking artifact (bot-generated status issue). Not a real work item.


Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

Automated by CleverAgents Bot
Agent: automation-tracking-manager

[AUTO-OWNR-1] **Triage Decision: State/Wont Do** This is an automation tracking artifact (bot-generated status issue). Not a real work item. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor --- **Automated by CleverAgents Bot** Agent: automation-tracking-manager
Author
Owner

[AUTO-OWNR-1] Triage Decision: State/Wont Do

This is an automation tracking artifact (bot-generated status issue). Not a real work item.


Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

Automated by CleverAgents Bot
Agent: automation-tracking-manager

[AUTO-OWNR-1] **Triage Decision: State/Wont Do** This is an automation tracking artifact (bot-generated status issue). Not a real work item. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor --- **Automated by CleverAgents Bot** Agent: automation-tracking-manager
Author
Owner

[AUTO-OWNR-1] Triage Decision: State/Wont Do

This is an automation tracking artifact (bot-generated status issue). Not a real work item.


Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

Automated by CleverAgents Bot
Agent: automation-tracking-manager

[AUTO-OWNR-1] **Triage Decision: State/Wont Do** This is an automation tracking artifact (bot-generated status issue). Not a real work item. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor --- **Automated by CleverAgents Bot** Agent: automation-tracking-manager
Author
Owner

[AUTO-OWNR-1] Triage Decision: State/Wont Do

This is an automation tracking artifact (bot-generated status issue). Not a real work item.


Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

Automated by CleverAgents Bot
Agent: automation-tracking-manager

[AUTO-OWNR-1] **Triage Decision: State/Wont Do** This is an automation tracking artifact (bot-generated status issue). Not a real work item. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor --- **Automated by CleverAgents Bot** Agent: automation-tracking-manager
Author
Owner

[AUTO-OWNR-1] Triage Decision: State/Wont Do

This is an automation tracking artifact (bot-generated status issue). Not a real work item.


Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

Automated by CleverAgents Bot
Agent: automation-tracking-manager

[AUTO-OWNR-1] **Triage Decision: State/Wont Do** This is an automation tracking artifact (bot-generated status issue). Not a real work item. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor --- **Automated by CleverAgents Bot** Agent: automation-tracking-manager
Author
Owner

[AUTO-OWNR-1] Triage Decision: State/Wont Do

This is an automation tracking artifact (bot-generated status issue). Not a real work item.


Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

Automated by CleverAgents Bot
Agent: automation-tracking-manager

[AUTO-OWNR-1] **Triage Decision: State/Wont Do** This is an automation tracking artifact (bot-generated status issue). Not a real work item. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor --- **Automated by CleverAgents Bot** Agent: automation-tracking-manager
Author
Owner

[AUTO-OWNR-1] Triage Decision: State/Wont Do

This is an automation tracking artifact (bot-generated status issue). Not a real work item.


Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

Automated by CleverAgents Bot
Agent: automation-tracking-manager

[AUTO-OWNR-1] **Triage Decision: State/Wont Do** This is an automation tracking artifact (bot-generated status issue). Not a real work item. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor --- **Automated by CleverAgents Bot** Agent: automation-tracking-manager
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core#9529
No description provided.