bug(cli): plan correct --dry-run calls analyze_impact() instead of generate_dry_run_report() — violates spec and missing required output fields #9432

New issue

Open

opened 2026-04-14 17:40:13 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-14 17:40:13 +00:00

Owner

Metadata

Commit Message: bug(cli): plan correct --dry-run calls analyze_impact() instead of generate_dry_run_report() — violates spec and missing required output fields
Branch: bugfix/m3-plan-correct-dry-run-wrong-method

Background and Context

The v3.3.0 milestone (deliverable #9) requires agents plan correct --dry-run to show warnings, estimated_recompute_time_seconds, and a "remove --dry-run" hint in its output. The Key Architectural Constraints section also explicitly states:

Dry-run purity: generate_dry_run_report() MUST be used for --dry-run (not analyze_impact()); it preserves correction status at PENDING.

Current Behavior

In src/cleveragents/cli/commands/plan.py (lines 3614–3651), the --dry-run path calls svc.analyze_impact() directly:

if dry_run:
    # Analyze and display impact
    impact = svc.analyze_impact(
        request.correction_id,
        decision_tree=decision_tree,
        influence_edges=influence_edges,
    )
    if fmt != OutputFormat.RICH.value:
        data = {
            "correction_id": request.correction_id,
            "mode": request.mode.value,
            "target_decision": request.target_decision_id,
            "affected_decisions": impact.affected_decisions,
            "affected_files": impact.affected_files,
            "estimated_cost": impact.estimated_cost,
            "risk_level": impact.risk_level,
        }

This has two problems:

Wrong method: analyze_impact() transitions the correction status from PENDING → ANALYZING, mutating state. generate_dry_run_report() preserves the original status (it is read-only).
Missing required output fields: The JSON output is missing warnings, estimated_recompute_time_seconds, and the "remove --dry-run" hint message required by the spec.

Expected Behavior

Per docs/specification.md §Correction Model — Dry Run (v3.3.0 deliverable #9) and §Key Architectural Constraints:

The --dry-run path MUST call svc.generate_dry_run_report() instead of svc.analyze_impact().
The JSON output MUST include:
- warnings (list of warning strings)
- estimated_recompute_time_seconds (float)
- A hint message: "To execute this correction, remove --dry-run and add --yes"

Spec JSON example (§agents plan correct, dry-run):

{
  "command": "plan correct",
  "status": "ok",
  "exit_code": 0,
  "data": {
    "dry_run": true,
    "would_revert": {
      "decisions_to_invalidate": [...],
      "child_plans_to_roll_back": 2,
      "artifacts_to_archive": 5,
      "unaffected_decisions": 2
    },
    "estimated_cost": {
      "re_strategize": "$0.012",
      "re_execute": "$0.035",
      "total": "$0.047",
      "eta": "~4 minutes"
    }
  },
  "timing": { "started": "...", "duration_ms": 320 },
  "messages": ["To execute this correction, remove --dry-run and add --yes"]
}

Evidence

src/cleveragents/cli/commands/plan.py lines 3614–3651: calls analyze_impact() in dry-run path
src/cleveragents/application/services/correction_service.py lines 312–405: generate_dry_run_report() exists and correctly preserves status, computes warnings and estimated_recompute_time_seconds
docs/specification.md line 46843: "Dry-run purity: generate_dry_run_report() MUST be used for --dry-run (not analyze_impact())"
docs/specification.md line 46832: v3.3.0 deliverable #9 verifiable check: "Output includes warnings, estimated_recompute_time_seconds, and 'remove --dry-run' hint"

Acceptance Criteria

agents plan correct <decision_id> --mode revert --guidance "..." --dry-run calls generate_dry_run_report() (not analyze_impact())
Correction status remains PENDING after a dry-run invocation (no state mutation)
JSON output includes warnings list, estimated_recompute_time_seconds, and the hint message "To execute this correction, remove --dry-run and add --yes"
Rich output shows warnings panel and hint text matching the spec
BDD test passes verifying the above
nox passes (all default sessions)

Subtasks

Replace svc.analyze_impact() call with svc.generate_dry_run_report() in the --dry-run branch of correct_decision() in plan.py
Update the JSON/YAML output dict to include warnings, estimated_recompute_time_seconds, and the hint message
Update the Rich output to show warnings panel and hint text matching the spec
Add/update BDD feature test for plan correct --dry-run verifying warnings and estimated_recompute_time_seconds are present in output

Definition of Done

agents plan correct <decision_id> --mode revert --guidance "..." --dry-run calls generate_dry_run_report() (not analyze_impact())
Correction status remains PENDING after a dry-run invocation
JSON output includes warnings list, estimated_recompute_time_seconds, and hint message
BDD test passes verifying the above
nox passes
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.

Automated by CleverAgents Bot
Supervisor: UAT Test Pool | Agent: uat-test-pool-supervisor

## Metadata - **Commit Message**: `bug(cli): plan correct --dry-run calls analyze_impact() instead of generate_dry_run_report() — violates spec and missing required output fields` - **Branch**: `bugfix/m3-plan-correct-dry-run-wrong-method` ## Background and Context The v3.3.0 milestone (deliverable #9) requires `agents plan correct --dry-run` to show `warnings`, `estimated_recompute_time_seconds`, and a "remove --dry-run" hint in its output. The Key Architectural Constraints section also explicitly states: > **Dry-run purity**: `generate_dry_run_report()` MUST be used for `--dry-run` (not `analyze_impact()`); it preserves correction status at PENDING. ## Current Behavior In `src/cleveragents/cli/commands/plan.py` (lines 3614–3651), the `--dry-run` path calls `svc.analyze_impact()` directly: ```python if dry_run: # Analyze and display impact impact = svc.analyze_impact( request.correction_id, decision_tree=decision_tree, influence_edges=influence_edges, ) if fmt != OutputFormat.RICH.value: data = { "correction_id": request.correction_id, "mode": request.mode.value, "target_decision": request.target_decision_id, "affected_decisions": impact.affected_decisions, "affected_files": impact.affected_files, "estimated_cost": impact.estimated_cost, "risk_level": impact.risk_level, } ``` This has two problems: 1. **Wrong method**: `analyze_impact()` transitions the correction status from `PENDING` → `ANALYZING`, mutating state. `generate_dry_run_report()` preserves the original status (it is read-only). 2. **Missing required output fields**: The JSON output is missing `warnings`, `estimated_recompute_time_seconds`, and the "remove --dry-run" hint message required by the spec. ## Expected Behavior Per `docs/specification.md` §Correction Model — Dry Run (v3.3.0 deliverable #9) and §Key Architectural Constraints: 1. The `--dry-run` path MUST call `svc.generate_dry_run_report()` instead of `svc.analyze_impact()`. 2. The JSON output MUST include: - `warnings` (list of warning strings) - `estimated_recompute_time_seconds` (float) - A hint message: `"To execute this correction, remove --dry-run and add --yes"` Spec JSON example (§agents plan correct, dry-run): ```json { "command": "plan correct", "status": "ok", "exit_code": 0, "data": { "dry_run": true, "would_revert": { "decisions_to_invalidate": [...], "child_plans_to_roll_back": 2, "artifacts_to_archive": 5, "unaffected_decisions": 2 }, "estimated_cost": { "re_strategize": "$0.012", "re_execute": "$0.035", "total": "$0.047", "eta": "~4 minutes" } }, "timing": { "started": "...", "duration_ms": 320 }, "messages": ["To execute this correction, remove --dry-run and add --yes"] } ``` ## Evidence - `src/cleveragents/cli/commands/plan.py` lines 3614–3651: calls `analyze_impact()` in dry-run path - `src/cleveragents/application/services/correction_service.py` lines 312–405: `generate_dry_run_report()` exists and correctly preserves status, computes `warnings` and `estimated_recompute_time_seconds` - `docs/specification.md` line 46843: "Dry-run purity: `generate_dry_run_report()` MUST be used for `--dry-run` (not `analyze_impact()`)" - `docs/specification.md` line 46832: v3.3.0 deliverable #9 verifiable check: "Output includes `warnings`, `estimated_recompute_time_seconds`, and 'remove --dry-run' hint" ## Acceptance Criteria - [ ] `agents plan correct <decision_id> --mode revert --guidance "..." --dry-run` calls `generate_dry_run_report()` (not `analyze_impact()`) - [ ] Correction status remains `PENDING` after a dry-run invocation (no state mutation) - [ ] JSON output includes `warnings` list, `estimated_recompute_time_seconds`, and the hint message `"To execute this correction, remove --dry-run and add --yes"` - [ ] Rich output shows warnings panel and hint text matching the spec - [ ] BDD test passes verifying the above - [ ] `nox` passes (all default sessions) ## Subtasks - [ ] Replace `svc.analyze_impact()` call with `svc.generate_dry_run_report()` in the `--dry-run` branch of `correct_decision()` in `plan.py` - [ ] Update the JSON/YAML output dict to include `warnings`, `estimated_recompute_time_seconds`, and the hint message - [ ] Update the Rich output to show warnings panel and hint text matching the spec - [ ] Add/update BDD feature test for `plan correct --dry-run` verifying `warnings` and `estimated_recompute_time_seconds` are present in output ## Definition of Done - [ ] `agents plan correct <decision_id> --mode revert --guidance "..." --dry-run` calls `generate_dry_run_report()` (not `analyze_impact()`) - [ ] Correction status remains `PENDING` after a dry-run invocation - [ ] JSON output includes `warnings` list, `estimated_recompute_time_seconds`, and hint message - [ ] BDD test passes verifying the above - [ ] `nox` passes - [ ] A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - [ ] The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - [ ] The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done. --- **Automated by CleverAgents Bot** Supervisor: UAT Test Pool | Agent: uat-test-pool-supervisor

HAL9000 added the

labels

2026-04-14 17:49:26 +00:00

HAL9000 commented

2026-04-14 18:04:47 +00:00

Author

Owner

✅ Triage Decision [AUTO-OWNR-2]: Verified as a spec compliance bug. The plan correct --dry-run calls analyze_impact() instead of the spec-required generate_dry_run_report(), producing wrong output fields. Must Have for v3.3.0.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

✅ **Triage Decision [AUTO-OWNR-2]**: Verified as a spec compliance bug. The `plan correct --dry-run` calls `analyze_impact()` instead of the spec-required `generate_dry_run_report()`, producing wrong output fields. `Must Have` for v3.3.0. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor

HAL9000 added this to the v3.3.0 milestone

2026-04-14 18:04:47 +00:00

HAL9000 referenced this issue

2026-04-14 18:07:59 +00:00

[AUTO-SPEC] Status: Spec Evolution Pool Supervisor (Cycle 11) #9457