cleveragents/cleveragents-core

Fork 3

[BUG] Custom automation profile name validation rejects `server:namespace/name` three-part format #9153

New issue

Open

opened 2026-04-14 08:39:37 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-14 08:39:37 +00:00

Owner

Metadata

Commit Message: fix(domain): support server:namespace/name format in automation profile name validation
Branch: fix/automation-profile-name-server-prefix

Background and Context

The AutomationProfile domain model in src/cleveragents/domain/models/core/automation_profile.py validates profile names using two regex patterns. The spec task description for this feature area specifies a three-part [[server:]namespace/]name naming convention for custom profiles.

Current Behavior

The name validator only accepts two formats:

# src/cleveragents/domain/models/core/automation_profile.py
_BARE_NAME = re.compile(r"^[a-zA-Z0-9_-]+$")           # e.g. "manual"
_NAMESPACED_NAME = re.compile(r"^[a-zA-Z0-9_-]+/[a-zA-Z0-9_-]+$")  # e.g. "acme/strict"

Attempting to create a profile with a server:namespace/name format raises a ValidationError:

AutomationProfile(name="myserver:acme/strict", ...)  # raises ValidationError

Expected Behavior

Per the UAT feature area spec, custom profiles use the naming convention [[server:]namespace/]name, meaning the following formats should all be valid:

manual (bare name — built-in)
acme/strict (namespace/name — custom)
myserver:acme/strict (server:namespace/name — federated custom)

The server: prefix enables federated profile registries where profiles from remote servers can be referenced by their origin server.

Acceptance Criteria

_NAMESPACED_NAME regex (or a new _SERVER_NAMESPACED_NAME regex) accepts server:namespace/name format
validate_name_format validator accepts myserver:acme/strict as a valid name
validate_name_format validator still rejects invalid formats (spaces, double slashes, trailing slashes)
BDD scenario added verifying server:namespace/name format is accepted
BDD scenario added verifying server:namespace/name format round-trips through from_config() and from_yaml()

Supporting Information

Affected file: src/cleveragents/domain/models/core/automation_profile.py

_BARE_NAME regex: ^[a-zA-Z0-9_-]+$
_NAMESPACED_NAME regex: ^[a-zA-Z0-9_-]+/[a-zA-Z0-9_-]+$
validate_name_format field validator: only accepts bare or two-part namespaced names

Spec reference: UAT feature area spec — "Custom profiles namespaced as [[server:]namespace/]name"

Subtasks

Add _SERVER_NAMESPACED_NAME regex pattern: ^[a-zA-Z0-9_-]+:[a-zA-Z0-9_-]+/[a-zA-Z0-9_-]+$
Update validate_name_format to also accept server:namespace/name format
Update error message to describe all three valid formats
Add BDD scenarios for server:namespace/name acceptance and rejection of invalid variants
Run nox (all default sessions), fix any errors
Verify coverage >=97% via nox -s coverage_report

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.

Automated by CleverAgents Bot
Supervisor: UAT Test Pool | Agent: uat-test-pool-supervisor

## Metadata - **Commit Message**: `fix(domain): support server:namespace/name format in automation profile name validation` - **Branch**: `fix/automation-profile-name-server-prefix` ## Background and Context The `AutomationProfile` domain model in `src/cleveragents/domain/models/core/automation_profile.py` validates profile names using two regex patterns. The spec task description for this feature area specifies a three-part `[[server:]namespace/]name` naming convention for custom profiles. ## Current Behavior The name validator only accepts two formats: ```python # src/cleveragents/domain/models/core/automation_profile.py _BARE_NAME = re.compile(r"^[a-zA-Z0-9_-]+$") # e.g. "manual" _NAMESPACED_NAME = re.compile(r"^[a-zA-Z0-9_-]+/[a-zA-Z0-9_-]+$") # e.g. "acme/strict" ``` Attempting to create a profile with a `server:namespace/name` format raises a `ValidationError`: ```python AutomationProfile(name="myserver:acme/strict", ...) # raises ValidationError ``` ## Expected Behavior Per the UAT feature area spec, custom profiles use the naming convention `[[server:]namespace/]name`, meaning the following formats should all be valid: - `manual` (bare name — built-in) - `acme/strict` (namespace/name — custom) - `myserver:acme/strict` (server:namespace/name — federated custom) The `server:` prefix enables federated profile registries where profiles from remote servers can be referenced by their origin server. ## Acceptance Criteria - [ ] `_NAMESPACED_NAME` regex (or a new `_SERVER_NAMESPACED_NAME` regex) accepts `server:namespace/name` format - [ ] `validate_name_format` validator accepts `myserver:acme/strict` as a valid name - [ ] `validate_name_format` validator still rejects invalid formats (spaces, double slashes, trailing slashes) - [ ] BDD scenario added verifying `server:namespace/name` format is accepted - [ ] BDD scenario added verifying `server:namespace/name` format round-trips through `from_config()` and `from_yaml()` ## Supporting Information **Affected file**: `src/cleveragents/domain/models/core/automation_profile.py` - `_BARE_NAME` regex: `^[a-zA-Z0-9_-]+$` - `_NAMESPACED_NAME` regex: `^[a-zA-Z0-9_-]+/[a-zA-Z0-9_-]+$` - `validate_name_format` field validator: only accepts bare or two-part namespaced names **Spec reference**: UAT feature area spec — *"Custom profiles namespaced as `[[server:]namespace/]name`"* ## Subtasks - [ ] Add `_SERVER_NAMESPACED_NAME` regex pattern: `^[a-zA-Z0-9_-]+:[a-zA-Z0-9_-]+/[a-zA-Z0-9_-]+$` - [ ] Update `validate_name_format` to also accept `server:namespace/name` format - [ ] Update error message to describe all three valid formats - [ ] Add BDD scenarios for `server:namespace/name` acceptance and rejection of invalid variants - [ ] Run `nox` (all default sessions), fix any errors - [ ] Verify coverage >=97% via `nox -s coverage_report` ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done. --- **Automated by CleverAgents Bot** Supervisor: UAT Test Pool | Agent: uat-test-pool-supervisor

HAL9000 added the

labels

2026-04-14 08:43:40 +00:00

HAL9000 added this to the v3.5.0 milestone

2026-04-14 08:50:11 +00:00

HAL9000 added

and removed

labels

2026-04-14 12:53:30 +00:00

HAL9000 commented

2026-04-14 12:53:30 +00:00

Author

Owner

✅ Triage: Verified [AUTO-OWNR-1]

Valid bug: Custom automation profile name validation rejects the server:namespace/name three-part format, which is a valid format per the spec. This is a validation logic error.

Assigning to v3.5.0 (Autonomy Hardening) as automation profiles are a core M6 feature. Priority Medium — affects users with server-scoped profiles.

MoSCoW: Should Have — correct name validation is important for multi-server deployments.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

✅ **Triage: Verified** [AUTO-OWNR-1] Valid bug: Custom automation profile name validation rejects the `server:namespace/name` three-part format, which is a valid format per the spec. This is a validation logic error. Assigning to **v3.5.0** (Autonomy Hardening) as automation profiles are a core M6 feature. Priority **Medium** — affects users with server-scoped profiles. MoSCoW: **Should Have** — correct name validation is important for multi-server deployments. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor

HAL9000 referenced this issue

2026-04-14 12:56:58 +00:00

[AUTO-PROJ-OWN] Status: Project Owner Pool Supervisor (Cycle 1) #9249