fix(test): remove skip guard from scientific paper basic test #894

New issue

Closed

opened 2026-03-13 23:46:31 +00:00 by freemo · 0 comments

freemo commented

2026-03-13 23:46:31 +00:00

Owner

Metadata

Commit Message: fix(test): remove skip guard from scientific paper basic test
Branch: fix/integration-paper-basic-skip-guard

Background

The scientific paper basic test (robot/scientific_paper_basic.robot, 89 lines) has a Require OpenAI Key skip guard in its Suite Setup (lines 86–88, called on line 66) that silently skips the entire suite when OPENAI_API_KEY is absent.

Robot Framework treats skipped tests as non-failures (exit code 0), so CI reports green even though no tests actually ran. This is the same pattern found across all E2E tests, now discovered in an integration test.

Acceptance Criteria

Require OpenAI Key skip guard is removed from Suite Setup
The Require OpenAI Key keyword definition is removed if defined locally in the file
If the test genuinely requires an OpenAI key at runtime, it should fail with a clear error rather than silently skip
nox -s integration_tests passes

Subtasks

Remove Require OpenAI Key from Suite Setup (line 66)
Remove the Require OpenAI Key keyword definition (lines 86–88)
Verify the test either passes or fails with a meaningful error (not a silent skip)
Run nox -s integration_tests and verify the test suite passes
Verify coverage >= 97% via nox -s coverage_report

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.

## Metadata - **Commit Message**: `fix(test): remove skip guard from scientific paper basic test` - **Branch**: `fix/integration-paper-basic-skip-guard` ## Background The scientific paper basic test (`robot/scientific_paper_basic.robot`, 89 lines) has a `Require OpenAI Key` skip guard in its Suite Setup (lines 86–88, called on line 66) that silently skips the entire suite when `OPENAI_API_KEY` is absent. Robot Framework treats skipped tests as non-failures (exit code 0), so CI reports green even though no tests actually ran. This is the same pattern found across all E2E tests, now discovered in an integration test. ## Acceptance Criteria - [ ] `Require OpenAI Key` skip guard is removed from Suite Setup - [ ] The `Require OpenAI Key` keyword definition is removed if defined locally in the file - [ ] If the test genuinely requires an OpenAI key at runtime, it should fail with a clear error rather than silently skip - [ ] `nox -s integration_tests` passes ## Subtasks - [ ] Remove `Require OpenAI Key` from Suite Setup (line 66) - [ ] Remove the `Require OpenAI Key` keyword definition (lines 86–88) - [ ] Verify the test either passes or fails with a meaningful error (not a silent skip) - [ ] Run `nox -s integration_tests` and verify the test suite passes - [ ] Verify coverage >= 97% via `nox -s coverage_report` ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

Rows
Columns