cleveragents/cleveragents-core

Fork 3

spec: consider adding maximum length constraint to persona `greeting` field #8779

New issue

Open

opened 2026-04-13 23:35:45 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-13 23:35:45 +00:00

Owner

Metadata

Priority: Low / Backlog
Milestone: v3.7.0 (TUI Implementation)

Background and Context

In PR #4979 (docs: architecture — clarify TUI session export formats and persona schema fields), @freemo (Founder/CTO) noted that the greeting field in the persona schema currently has no maximum length constraint. His decision was: "Any size is fine for now, write an issue making a note of this, as a low priority bug so we can consider it later on."

This is a tracking issue to revisit the greeting field constraint in the future.

Current State

The greeting field in the persona schema is currently an unconstrained str. There is no maximum length validation. This means:

Implementers cannot validate the field length
Very long greetings could cause UI display issues in the TUI
No guidance is given to persona authors about appropriate greeting length

Proposed Future Action

When this issue is picked up, consider:

Adding a maximum length constraint (suggested: ≤ 200 characters, but open to discussion)
Adding validation in the persona schema model
Updating the specification to document the constraint
Adding a test to verify the constraint is enforced

Acceptance Criteria (when addressed)

A maximum length for greeting is decided and documented in the spec
The persona schema model validates the constraint
Tests verify the constraint is enforced
The spec is updated to document the constraint

Subtasks

Research appropriate maximum length for greeting field (UX + TUI display considerations)
Decide on constraint value (suggested: ≤ 200 characters)
Add max_length validation to the persona schema model
Update the specification to document the constraint
Add tests to verify the constraint is enforced

Definition of Done

Maximum length constraint decided and documented
Validation added to persona schema model
Tests pass with coverage ≥ 97%
Specification updated and PR merged

Automated by CleverAgents Bot
Agent: new-issue-creator

## Metadata - **Priority**: Low / Backlog - **Milestone**: v3.7.0 (TUI Implementation) ## Background and Context In PR #4979 (docs: architecture — clarify TUI session export formats and persona schema fields), @freemo (Founder/CTO) noted that the `greeting` field in the persona schema currently has no maximum length constraint. His decision was: "Any size is fine for now, write an issue making a note of this, as a low priority bug so we can consider it later on." This is a tracking issue to revisit the `greeting` field constraint in the future. ## Current State The `greeting` field in the persona schema is currently an unconstrained `str`. There is no maximum length validation. This means: - Implementers cannot validate the field length - Very long greetings could cause UI display issues in the TUI - No guidance is given to persona authors about appropriate greeting length ## Proposed Future Action When this issue is picked up, consider: - Adding a maximum length constraint (suggested: ≤ 200 characters, but open to discussion) - Adding validation in the persona schema model - Updating the specification to document the constraint - Adding a test to verify the constraint is enforced ## Acceptance Criteria (when addressed) - [ ] A maximum length for `greeting` is decided and documented in the spec - [ ] The persona schema model validates the constraint - [ ] Tests verify the constraint is enforced - [ ] The spec is updated to document the constraint ## Subtasks - [ ] Research appropriate maximum length for greeting field (UX + TUI display considerations) - [ ] Decide on constraint value (suggested: ≤ 200 characters) - [ ] Add `max_length` validation to the persona schema model - [ ] Update the specification to document the constraint - [ ] Add tests to verify the constraint is enforced ## Definition of Done - Maximum length constraint decided and documented - Validation added to persona schema model - Tests pass with coverage ≥ 97% - Specification updated and PR merged --- **Automated by CleverAgents Bot** Agent: new-issue-creator

HAL9000 added this to the v3.7.0 milestone

2026-04-13 23:35:49 +00:00

HAL9000 added the

labels

2026-04-13 23:37:14 +00:00

HAL9000 referenced this issue

2026-04-13 23:38:36 +00:00

[AUTO-HUMAN] Status: Human Liaison Pool Supervisor (Cycle 1) #8771

HAL9000 added

and removed

labels

2026-04-14 00:04:16 +00:00

HAL9000 commented

2026-04-14 00:04:16 +00:00

Author

Owner

✅ Triage Decision: Verified — Could Have / Low Priority

This issue has been reviewed and verified by the Project Owner Pool Supervisor.

Rationale:

CTO-requested: This tracking issue was explicitly requested by @freemo (Founder/CTO) in PR #4979 review. The decision was "write an issue making a note of this, as a low priority bug so we can consider it later on."
No immediate harm: The unconstrained greeting field does not cause functional failures today, but could cause TUI display issues with very long values.
Scope: Correctly assigned to v3.7.0 (TUI milestone). Persona schema validation is a TUI concern.
MoSCoW: Could Have — desirable quality improvement but not blocking any release. TUI can ship without this constraint.
Priority: Confirmed Low — backlog item, address after Must Have and Should Have items are complete.

Next steps: Pick up when v3.7.0 Must Have items are complete. Decide on max length (suggested ≤ 200 chars), add validation, update spec.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor
Worker: [AUTO-OWNR-1]

## ✅ Triage Decision: Verified — Could Have / Low Priority This issue has been reviewed and verified by the Project Owner Pool Supervisor. **Rationale:** - **CTO-requested**: This tracking issue was explicitly requested by @freemo (Founder/CTO) in PR #4979 review. The decision was "write an issue making a note of this, as a low priority bug so we can consider it later on." - **No immediate harm**: The unconstrained `greeting` field does not cause functional failures today, but could cause TUI display issues with very long values. - **Scope**: Correctly assigned to v3.7.0 (TUI milestone). Persona schema validation is a TUI concern. - **MoSCoW**: **Could Have** — desirable quality improvement but not blocking any release. TUI can ship without this constraint. - **Priority**: Confirmed **Low** — backlog item, address after Must Have and Should Have items are complete. **Next steps**: Pick up when v3.7.0 Must Have items are complete. Decide on max length (suggested ≤ 200 chars), add validation, update spec. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor Worker: [AUTO-OWNR-1]

HAL9000 referenced this issue

2026-04-14 00:05:27 +00:00

[AUTO-PROJ-OWN] Status: Project Owner Pool Supervisor (Cycle 15) #8804

HAL9000 referenced this issue

2026-05-17 07:09:35 +00:00

fix(events): add unsubscribe() to EventBus protocol and implementations (#10356) #11197