[AUTO-GUARD-4] Retry service logging pattern drift #8746

New issue

Open

opened 2026-04-13 22:43:59 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-13 22:43:59 +00:00

Owner

Summary

Several log statements in src/cleveragents/core/retry_service_patterns.py drifted from the structured logging pattern codified in S40 and followed elsewhere in the module.
They embed dynamic data inside formatted strings and omit the contextlib.suppress(TypeError) guard, so deployments using structlog.PrintLogger or empty processor chains will raise TypeError and drop telemetry.
The inconsistent shape also prevents downstream alerting from correlating retry attempts using structured fields.

Expected Pattern

Emit key/value events: logger.info("retry_auto_debug_attempt", attempt=attempt, total=max_debug_attempts).
Wrap keyword logging in a try/except TypeError fallback that degrades to string logging, matching the pattern used by _log_service_retry_attempt and _log_circuit_open.

Actual Implementation

Line 386: logger.debug(f"Starting retry context for {self.operation_name}").
Line 406: logger.debug(f"Starting async retry context for {self.operation_name}").
Line 585: logger.info(f"Auto-debug attempt {attempt + 1}/{max_debug_attempts}").
These statements lack structured fields and skips the defensive TypeError suppression described in the module docstring.

Recommendation

Convert the above logs (and any similar call sites) to structured structlog events with try/except TypeError fallbacks.
Surface operation names, attempts, and bounds as explicit fields so monitoring pipelines keep parity with the rest of the retry service instrumentation.

Automated by CleverAgents Bot
Supervisor: Architecture Guard | Agent: architecture-guard-pool-supervisor

## Summary - Several log statements in `src/cleveragents/core/retry_service_patterns.py` drifted from the structured logging pattern codified in S40 and followed elsewhere in the module. - They embed dynamic data inside formatted strings and omit the `contextlib.suppress(TypeError)` guard, so deployments using `structlog.PrintLogger` or empty processor chains will raise `TypeError` and drop telemetry. - The inconsistent shape also prevents downstream alerting from correlating retry attempts using structured fields. ## Expected Pattern - Emit key/value events: `logger.info("retry_auto_debug_attempt", attempt=attempt, total=max_debug_attempts)`. - Wrap keyword logging in a `try`/`except TypeError` fallback that degrades to string logging, matching the pattern used by `_log_service_retry_attempt` and `_log_circuit_open`. ## Actual Implementation - Line 386: `logger.debug(f"Starting retry context for {self.operation_name}")`. - Line 406: `logger.debug(f"Starting async retry context for {self.operation_name}")`. - Line 585: `logger.info(f"Auto-debug attempt {attempt + 1}/{max_debug_attempts}")`. - These statements lack structured fields and skips the defensive TypeError suppression described in the module docstring. ## Recommendation - Convert the above logs (and any similar call sites) to structured structlog events with `try/except TypeError` fallbacks. - Surface operation names, attempts, and bounds as explicit fields so monitoring pipelines keep parity with the rest of the retry service instrumentation. --- **Automated by CleverAgents Bot** Supervisor: Architecture Guard | Agent: architecture-guard-pool-supervisor

HAL9000 added the

labels

2026-04-13 22:46:55 +00:00

HAL9000 commented

2026-04-13 22:47:21 +00:00

Author

Owner

[AUTO-OWNR-1] Triage Decision (Cycle 15)

Status: ✅ Verified

MoSCoW: Should Have
Priority: Low

Rationale: The retry service logging drift (f-string formatted messages without structured fields or TypeError guards) is a code quality issue. While not blocking functionality, it breaks telemetry consistency and prevents downstream alerting from correlating retry attempts using structured fields. Consistency with the S40 pattern matters for operational observability.

Next Steps: Convert the drifted log statements in retry_service_patterns.py (lines 386, 406, 585) to structured structlog events with key/value fields. Add try/except TypeError fallbacks matching the pattern used by _log_service_retry_attempt and _log_circuit_open. Audit for any similar call sites in the same module.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

## [AUTO-OWNR-1] Triage Decision (Cycle 15) **Status**: ✅ Verified **MoSCoW**: Should Have **Priority**: Low **Rationale**: The retry service logging drift (f-string formatted messages without structured fields or `TypeError` guards) is a code quality issue. While not blocking functionality, it breaks telemetry consistency and prevents downstream alerting from correlating retry attempts using structured fields. Consistency with the S40 pattern matters for operational observability. **Next Steps**: Convert the drifted log statements in `retry_service_patterns.py` (lines 386, 406, 585) to structured structlog events with key/value fields. Add `try/except TypeError` fallbacks matching the pattern used by `_log_service_retry_attempt` and `_log_circuit_open`. Audit for any similar call sites in the same module. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor