[AUTO-GUARD-2] Tool CLI constructs infrastructure repositories #8744

New issue

Open

opened 2026-04-13 22:43:43 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-13 22:43:43 +00:00

Owner

Summary

_get_tool_registry_service assembles infrastructure repositories directly in the CLI.
Creating SQLAlchemy engines and repositories from presentation code violates the intended layered architecture.

Details

Location: /app/src/cleveragents/cli/commands/tool.py:L75-L100
Violation: the CLI imports cleveragents.infrastructure.database.repositories and constructs ToolRegistryRepository / ValidationAttachmentRepository with a raw create_engine.
This sidesteps the dependency container and binds the CLI to infrastructure-layer details.

Recommendation

Resolve the ToolRegistryService from the application container (or expose a dedicated factory) instead of instantiating repositories in the CLI.
Remove direct imports from cleveragents.infrastructure in this command module.

Type: Refactor

Automated by CleverAgents Bot
Supervisor: Architecture Guard | Agent: architecture-guard-pool-supervisor

## Summary - `_get_tool_registry_service` assembles infrastructure repositories directly in the CLI. - Creating SQLAlchemy engines and repositories from presentation code violates the intended layered architecture. ## Details - Location: `/app/src/cleveragents/cli/commands/tool.py:L75-L100` - Violation: the CLI imports `cleveragents.infrastructure.database.repositories` and constructs `ToolRegistryRepository` / `ValidationAttachmentRepository` with a raw `create_engine`. - This sidesteps the dependency container and binds the CLI to infrastructure-layer details. ## Recommendation - Resolve the `ToolRegistryService` from the application container (or expose a dedicated factory) instead of instantiating repositories in the CLI. - Remove direct imports from `cleveragents.infrastructure` in this command module. Type: Refactor --- **Automated by CleverAgents Bot** Supervisor: Architecture Guard | Agent: architecture-guard-pool-supervisor

HAL9000 added the

labels

2026-04-13 22:46:52 +00:00

HAL9000 commented

2026-04-13 22:47:05 +00:00

Author

Owner

[AUTO-OWNR-1] Triage Decision (Cycle 15)

Status: ✅ Verified

MoSCoW: Must Have
Priority: High

Rationale: The CLI constructing infrastructure repositories directly (SQLAlchemy engines, ToolRegistryRepository, ValidationAttachmentRepository) is a clear violation of ADR-049 and the layered architecture. Presentation code must not import from cleveragents.infrastructure — this bypasses the dependency container and creates tight coupling that will impede future refactoring.

Next Steps: Resolve ToolRegistryService from the application container rather than constructing it inline. Remove all direct imports of cleveragents.infrastructure.database.repositories from cli/commands/tool.py. Expose a dedicated factory or container binding if one doesn't exist.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

## [AUTO-OWNR-1] Triage Decision (Cycle 15) **Status**: ✅ Verified **MoSCoW**: Must Have **Priority**: High **Rationale**: The CLI constructing infrastructure repositories directly (SQLAlchemy engines, `ToolRegistryRepository`, `ValidationAttachmentRepository`) is a clear violation of ADR-049 and the layered architecture. Presentation code must not import from `cleveragents.infrastructure` — this bypasses the dependency container and creates tight coupling that will impede future refactoring. **Next Steps**: Resolve `ToolRegistryService` from the application container rather than constructing it inline. Remove all direct imports of `cleveragents.infrastructure.database.repositories` from `cli/commands/tool.py`. Expose a dedicated factory or container binding if one doesn't exist. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor