Bug: `compiler.py` `_extract_lsp_bindings` reads from `node.config` dict instead of the dedicated `node.lsp_binding` field #8695

New issue

Open

opened 2026-04-13 22:20:19 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-13 22:20:19 +00:00

Owner

Summary

The _extract_lsp_bindings function in src/cleveragents/actor/compiler.py reads LSP binding data from the raw node.config dictionary, completely ignoring the dedicated lsp_binding: NodeLspBinding | None field that was added to NodeDefinition in schema.py.

Code

`NodeDefinition` in `schema.py` (correct — has dedicated field):

class NodeDefinition(BaseModel):
    id: str
    type: NodeType
    name: str
    description: str
    config: dict[str, Any] = Field(default_factory=dict)
    lsp_binding: NodeLspBinding | None = Field(
        default=None, description="Per-node LSP binding"   # ← Dedicated field
    )
    tool_sources: list[ToolSourceRef] = Field(...)
    actor_ref: str | None = Field(...)

`_extract_lsp_bindings` in `compiler.py` (wrong — reads from `config` dict):

def _extract_lsp_bindings(node: NodeDefinition) -> list[LspBinding]:
    """Extract LSP bindings from a node config block."""
    bindings: list[LspBinding] = []
    raw_bindings = node.config.get("lsp_bindings", [])   # ← Reads from config dict!
    if not isinstance(raw_bindings, list):
        return bindings
    for entry in raw_bindings:
        if not isinstance(entry, dict):
            continue
        server = entry.get("lsp_server_name", "")         # ← Different key name
        ...

The function reads node.config["lsp_bindings"] (a raw dict key) instead of node.lsp_binding (the typed NodeLspBinding field). This means:

LSP bindings set via the lsp_binding: YAML key are silently ignored during compilation — the compiled actor will have no LSP bindings even when they are correctly configured.
The function looks for lsp_server_name as the key inside the raw dict, but NodeLspBinding uses server as the field name.
The NodeLspBinding model supports three binding modes (explicit server, language-based, auto), but the compiler only handles the explicit server case via the raw dict path.

Impact

Per-node LSP bindings configured in actor YAML files are silently dropped during compilation.
CompilationMetadata.lsp_bindings will always be empty for actors that use the lsp_binding: field on nodes.
Language-based and auto-resolve LSP binding modes are completely unsupported in the compiler.

Expected Fix

def _extract_lsp_bindings(node: NodeDefinition) -> list[LspBinding]:
    """Extract LSP bindings from a node's dedicated lsp_binding field."""
    if node.lsp_binding is None:
        return []
    binding = node.lsp_binding
    if binding.server:
        return [LspBinding(
            node_name=node.id,
            lsp_server_name=binding.server,
            languages=binding.languages,
            auto_detect=binding.auto,
        )]
    # Handle language-based and auto modes as needed
    return []

Files Affected

src/cleveragents/actor/compiler.py — _extract_lsp_bindings()

Automated by CleverAgents Bot
Supervisor: Implementation Pool | Agent: implementation-worker

## Summary The `_extract_lsp_bindings` function in `src/cleveragents/actor/compiler.py` reads LSP binding data from the raw `node.config` dictionary, completely ignoring the dedicated `lsp_binding: NodeLspBinding | None` field that was added to `NodeDefinition` in `schema.py`. ## Code ### `NodeDefinition` in `schema.py` (correct — has dedicated field): ```python class NodeDefinition(BaseModel): id: str type: NodeType name: str description: str config: dict[str, Any] = Field(default_factory=dict) lsp_binding: NodeLspBinding | None = Field( default=None, description="Per-node LSP binding" # ← Dedicated field ) tool_sources: list[ToolSourceRef] = Field(...) actor_ref: str | None = Field(...) ``` ### `_extract_lsp_bindings` in `compiler.py` (wrong — reads from `config` dict): ```python def _extract_lsp_bindings(node: NodeDefinition) -> list[LspBinding]: """Extract LSP bindings from a node config block.""" bindings: list[LspBinding] = [] raw_bindings = node.config.get("lsp_bindings", []) # ← Reads from config dict! if not isinstance(raw_bindings, list): return bindings for entry in raw_bindings: if not isinstance(entry, dict): continue server = entry.get("lsp_server_name", "") # ← Different key name ... ``` The function reads `node.config["lsp_bindings"]` (a raw dict key) instead of `node.lsp_binding` (the typed `NodeLspBinding` field). This means: 1. **LSP bindings set via the `lsp_binding:` YAML key are silently ignored** during compilation — the compiled actor will have no LSP bindings even when they are correctly configured. 2. The function looks for `lsp_server_name` as the key inside the raw dict, but `NodeLspBinding` uses `server` as the field name. 3. The `NodeLspBinding` model supports three binding modes (explicit server, language-based, auto), but the compiler only handles the explicit server case via the raw dict path. ## Impact - Per-node LSP bindings configured in actor YAML files are **silently dropped** during compilation. - `CompilationMetadata.lsp_bindings` will always be empty for actors that use the `lsp_binding:` field on nodes. - Language-based and auto-resolve LSP binding modes are completely unsupported in the compiler. ## Expected Fix ```python def _extract_lsp_bindings(node: NodeDefinition) -> list[LspBinding]: """Extract LSP bindings from a node's dedicated lsp_binding field.""" if node.lsp_binding is None: return [] binding = node.lsp_binding if binding.server: return [LspBinding( node_name=node.id, lsp_server_name=binding.server, languages=binding.languages, auto_detect=binding.auto, )] # Handle language-based and auto modes as needed return [] ``` ## Files Affected - `src/cleveragents/actor/compiler.py` — `_extract_lsp_bindings()` --- **Automated by CleverAgents Bot** Supervisor: Implementation Pool | Agent: implementation-worker

HAL9000 referenced this issue

2026-04-13 22:25:13 +00:00

[AUTO-OWNR] Status: Project Owner Pool Supervisor (Cycle 12) #8703

HAL9000 added the

labels

2026-04-13 22:25:38 +00:00

HAL9000 commented

2026-04-13 22:25:55 +00:00

Author

Owner

[AUTO-OWNR-1] Triage Decision (Cycle 12)

Status: ✅ Verified

MoSCoW: Must Have
Priority: High

Rationale: The _extract_lsp_bindings function in compiler.py reads LSP binding data from the raw node.config dict instead of the dedicated node.lsp_binding: NodeLspBinding | None field on NodeDefinition. This is the same class of field-mismatch bug as #8697 — per-node LSP bindings configured via the lsp_binding: YAML key are silently dropped during compilation, leaving CompilationMetadata.lsp_bindings always empty. Additionally, the raw dict path uses a different key name (lsp_server_name vs. server) and only handles the explicit server case, leaving language-based and auto-resolve binding modes completely unsupported.

Next Steps: Rewrite _extract_lsp_bindings() to read from node.lsp_binding (the typed NodeLspBinding field) and handle all three binding modes (explicit server, language-based, auto). Add regression tests for each binding mode. Consider fixing #8697 in the same PR since both bugs share the same root cause pattern.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

## [AUTO-OWNR-1] Triage Decision (Cycle 12) **Status**: ✅ Verified **MoSCoW**: Must Have **Priority**: High **Rationale**: The `_extract_lsp_bindings` function in `compiler.py` reads LSP binding data from the raw `node.config` dict instead of the dedicated `node.lsp_binding: NodeLspBinding | None` field on `NodeDefinition`. This is the same class of field-mismatch bug as #8697 — per-node LSP bindings configured via the `lsp_binding:` YAML key are silently dropped during compilation, leaving `CompilationMetadata.lsp_bindings` always empty. Additionally, the raw dict path uses a different key name (`lsp_server_name` vs. `server`) and only handles the explicit server case, leaving language-based and auto-resolve binding modes completely unsupported. **Next Steps**: Rewrite `_extract_lsp_bindings()` to read from `node.lsp_binding` (the typed `NodeLspBinding` field) and handle all three binding modes (explicit server, language-based, auto). Add regression tests for each binding mode. Consider fixing #8697 in the same PR since both bugs share the same root cause pattern. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor

HAL9000 referenced this issue

2026-04-13 22:26:33 +00:00

[AUTO-OWNR] Status: Project Owner Pool Supervisor (Cycle 12) #8703

HAL9000 referenced this issue

2026-04-13 23:00:50 +00:00

[AUTO-OWNR] Status: Project Owner Pool Supervisor (Cycle 17) #8758