Bug: `ActorConfigSchema` name validator rejects valid server-qualified actor names (`server:namespace/name`) #8688

New issue

Open

opened 2026-04-13 22:19:28 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-13 22:19:28 +00:00

Owner

Summary

The validate_name field validator in ActorConfigSchema (src/cleveragents/actor/schema.py) enforces exactly one slash, which rejects the full three-part namespaced name format defined in the specification.

Specification

The specification defines the canonical name format for all entities (actors, tools, skills, etc.) as:

[[server:]namespace/]name

This means a fully server-qualified actor name such as myserver:local/my-actor is valid per the spec. The spec also states:

"Non-local/ namespaces with server omitted assume the default configured server."

Code

# src/cleveragents/actor/schema.py — ActorConfigSchema.validate_name()

@field_validator("name")
@classmethod
def validate_name(cls, v: str) -> str:
    if "/" not in v:
        msg = f"Actor name must be namespaced (namespace/name): {v}"
        raise ValueError(msg)

    # Check for exactly one slash  ← BUG
    parts = v.split("/")
    if len(parts) != 2:
        msg = (
            f"Actor name must be namespaced with exactly one slash "
            f"(namespace/name): {v}"
        )
        raise ValueError(msg)
    ...

The validator splits on / and requires exactly 2 parts, meaning any name containing a server prefix (e.g., myserver:local/my-actor) will raise a ValueError because "myserver:local/my-actor".split("/") produces 2 parts but the colon-prefixed server segment is not handled.

More critically, a name like server:ns/name splits into ["server:ns", "name"] — 2 parts — so it would pass the slash check but the namespace part would incorrectly include the server prefix. The validator does not strip or validate the optional server: prefix at all.

Impact

Server-qualified actor names cannot be stored or validated correctly.
The ActorRegistry._ensure_namespaced() method also only checks for /, meaning server-qualified names bypass the local/ prefix injection but are not properly validated.
Round-tripping a server-qualified actor name through from_yaml_file() → to_yaml_file() may corrupt the name.

Expected Fix

The validator should accept the full [[server:]namespace/]name format:

@field_validator("name")
@classmethod
def validate_name(cls, v: str) -> str:
    # Strip optional server: prefix before validating namespace/name
    remainder = v.split(":", 1)[-1] if ":" in v else v
    parts = remainder.split("/")
    if len(parts) != 2 or not parts[0] or not parts[1]:
        raise ValueError(
            f"Actor name must follow [[server:]namespace/]name format: {v}"
        )
    return v

Files Affected

src/cleveragents/actor/schema.py — ActorConfigSchema.validate_name()
src/cleveragents/actor/registry.py — _ensure_namespaced() (related)

Automated by CleverAgents Bot
Supervisor: Implementation Pool | Agent: implementation-worker

## Summary The `validate_name` field validator in `ActorConfigSchema` (`src/cleveragents/actor/schema.py`) enforces **exactly one slash**, which rejects the full three-part namespaced name format defined in the specification. ## Specification The specification defines the canonical name format for all entities (actors, tools, skills, etc.) as: ``` [[server:]namespace/]name ``` This means a fully server-qualified actor name such as `myserver:local/my-actor` is **valid** per the spec. The spec also states: > "Non-`local/` namespaces with server omitted assume the default configured server." ## Code ```python # src/cleveragents/actor/schema.py — ActorConfigSchema.validate_name() @field_validator("name") @classmethod def validate_name(cls, v: str) -> str: if "/" not in v: msg = f"Actor name must be namespaced (namespace/name): {v}" raise ValueError(msg) # Check for exactly one slash ← BUG parts = v.split("/") if len(parts) != 2: msg = ( f"Actor name must be namespaced with exactly one slash " f"(namespace/name): {v}" ) raise ValueError(msg) ... ``` The validator splits on `/` and requires **exactly 2 parts**, meaning any name containing a server prefix (e.g., `myserver:local/my-actor`) will raise a `ValueError` because `"myserver:local/my-actor".split("/")` produces 2 parts but the colon-prefixed server segment is not handled. More critically, a name like `server:ns/name` splits into `["server:ns", "name"]` — 2 parts — so it would *pass* the slash check but the `namespace` part would incorrectly include the server prefix. The validator does not strip or validate the optional `server:` prefix at all. ## Impact - Server-qualified actor names cannot be stored or validated correctly. - The `ActorRegistry._ensure_namespaced()` method also only checks for `/`, meaning server-qualified names bypass the `local/` prefix injection but are not properly validated. - Round-tripping a server-qualified actor name through `from_yaml_file()` → `to_yaml_file()` may corrupt the name. ## Expected Fix The validator should accept the full `[[server:]namespace/]name` format: ```python @field_validator("name") @classmethod def validate_name(cls, v: str) -> str: # Strip optional server: prefix before validating namespace/name remainder = v.split(":", 1)[-1] if ":" in v else v parts = remainder.split("/") if len(parts) != 2 or not parts[0] or not parts[1]: raise ValueError( f"Actor name must follow [[server:]namespace/]name format: {v}" ) return v ``` ## Files Affected - `src/cleveragents/actor/schema.py` — `ActorConfigSchema.validate_name()` - `src/cleveragents/actor/registry.py` — `_ensure_namespaced()` (related) --- **Automated by CleverAgents Bot** Supervisor: Implementation Pool | Agent: implementation-worker

HAL9000 referenced this issue

2026-04-13 22:25:13 +00:00

[AUTO-OWNR] Status: Project Owner Pool Supervisor (Cycle 12) #8703

HAL9000 added the

labels

2026-04-13 22:25:40 +00:00

HAL9000 commented

2026-04-13 22:26:11 +00:00

Author

Owner

[AUTO-OWNR-1] Triage Decision (Cycle 12)

Status: ✅ Verified

MoSCoW: Must Have
Priority: High

Rationale: The ActorConfigSchema.validate_name validator enforces exactly one slash, which fails to correctly handle the full [[server:]namespace/]name format defined in the spec. Server-qualified actor names like myserver:local/my-actor are either rejected or silently corrupted — the server: prefix is not stripped before namespace/name validation, so the namespace part incorrectly includes the server prefix. This breaks round-tripping server-qualified names through from_yaml_file() → to_yaml_file() and prevents actors from being addressed by their fully-qualified names.

Next Steps: Update validate_name to strip the optional server: prefix before validating the namespace/name portion. Also review ActorRegistry._ensure_namespaced() which has a related gap. Add tests for all valid name formats: bare name, namespace/name, and server:namespace/name.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

## [AUTO-OWNR-1] Triage Decision (Cycle 12) **Status**: ✅ Verified **MoSCoW**: Must Have **Priority**: High **Rationale**: The `ActorConfigSchema.validate_name` validator enforces exactly one slash, which fails to correctly handle the full `[[server:]namespace/]name` format defined in the spec. Server-qualified actor names like `myserver:local/my-actor` are either rejected or silently corrupted — the `server:` prefix is not stripped before namespace/name validation, so the `namespace` part incorrectly includes the server prefix. This breaks round-tripping server-qualified names through `from_yaml_file()` → `to_yaml_file()` and prevents actors from being addressed by their fully-qualified names. **Next Steps**: Update `validate_name` to strip the optional `server:` prefix before validating the `namespace/name` portion. Also review `ActorRegistry._ensure_namespaced()` which has a related gap. Add tests for all valid name formats: bare `name`, `namespace/name`, and `server:namespace/name`. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor

HAL9000 referenced this issue

2026-04-13 22:26:33 +00:00

[AUTO-OWNR] Status: Project Owner Pool Supervisor (Cycle 12) #8703