cleveragents/cleveragents-core

Fork 3

_sanitize_error_message defines _MAX_SANITIZE_INPUT as a local variable instead of a module-level constant #8463

New issue

Open

opened 2026-04-13 19:22:31 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-13 19:22:31 +00:00

Owner

Metadata

Commit: Build: Reinforced label enforcement, and ensure implementation workers dont continue work on a mergable PR.
Branch: main
SHA: 5a9aaa79ed

Background and Context

In src/cleveragents/core/retry_patterns.py, the _sanitize_error_message function defines _MAX_SANITIZE_INPUT = 2000 as a local variable inside the function body. The ALL_CAPS naming convention in Python indicates a module-level constant, and the comment references it as a design decision ("P2-26"), suggesting it was intended to be a module-level constant.

Defining it as a local variable means:

The value is re-created on every function call (minor performance overhead in hot retry paths).
The constant cannot be referenced or overridden from outside the function.
It violates the naming convention: local variables should use snake_case, not UPPER_CASE.
It is inconsistent with other module-level constants in the same file (DEFAULT_MAX_ATTEMPTS, DEFAULT_MIN_WAIT, DEFAULT_MAX_WAIT, DEFAULT_EXPONENTIAL_BASE).

Current Behavior

def _sanitize_error_message(error: BaseException | None) -> str | None:
    ...
    _MAX_SANITIZE_INPUT = 2000   # ← local variable, re-created on every call
    if len(msg) > _MAX_SANITIZE_INPUT:
        msg = msg[:_MAX_SANITIZE_INPUT]

Expected Behavior

_MAX_SANITIZE_INPUT should be defined at module level alongside the other constants:

# Module-level constants
DEFAULT_MAX_ATTEMPTS = 3
DEFAULT_MIN_WAIT = 1
DEFAULT_MAX_WAIT = 60
DEFAULT_EXPONENTIAL_BASE = 2
_MAX_SANITIZE_INPUT = 2000   # ← module-level constant

def _sanitize_error_message(error: BaseException | None) -> str | None:
    ...
    if len(msg) > _MAX_SANITIZE_INPUT:
        msg = msg[:_MAX_SANITIZE_INPUT]

Acceptance Criteria

_MAX_SANITIZE_INPUT is defined at module level in retry_patterns.py
_sanitize_error_message references the module-level constant
The function behaviour is unchanged
No existing tests break

Subtasks

Move _MAX_SANITIZE_INPUT = 2000 to module level in retry_patterns.py
Remove the local variable definition from _sanitize_error_message
Verify all tests pass

Definition of Done

The issue is closed when _MAX_SANITIZE_INPUT is a module-level constant in retry_patterns.py, with all tests passing, merged to main.

Automated by CleverAgents Bot
Supervisor: Bug Hunt Pool | Agent: bug-hunt-pool-supervisor

## Metadata - **Commit**: Build: Reinforced label enforcement, and ensure implementation workers dont continue work on a mergable PR. - **Branch**: main - **SHA**: 5a9aaa79edaefb1a257114f054ea87facb8efe69 ## Background and Context In `src/cleveragents/core/retry_patterns.py`, the `_sanitize_error_message` function defines `_MAX_SANITIZE_INPUT = 2000` as a **local variable** inside the function body. The ALL_CAPS naming convention in Python indicates a module-level constant, and the comment references it as a design decision ("P2-26"), suggesting it was intended to be a module-level constant. Defining it as a local variable means: 1. The value is re-created on every function call (minor performance overhead in hot retry paths). 2. The constant cannot be referenced or overridden from outside the function. 3. It violates the naming convention: local variables should use `snake_case`, not `UPPER_CASE`. 4. It is inconsistent with other module-level constants in the same file (`DEFAULT_MAX_ATTEMPTS`, `DEFAULT_MIN_WAIT`, `DEFAULT_MAX_WAIT`, `DEFAULT_EXPONENTIAL_BASE`). ## Current Behavior ```python def _sanitize_error_message(error: BaseException | None) -> str | None: ... _MAX_SANITIZE_INPUT = 2000 # ← local variable, re-created on every call if len(msg) > _MAX_SANITIZE_INPUT: msg = msg[:_MAX_SANITIZE_INPUT] ``` ## Expected Behavior `_MAX_SANITIZE_INPUT` should be defined at module level alongside the other constants: ```python # Module-level constants DEFAULT_MAX_ATTEMPTS = 3 DEFAULT_MIN_WAIT = 1 DEFAULT_MAX_WAIT = 60 DEFAULT_EXPONENTIAL_BASE = 2 _MAX_SANITIZE_INPUT = 2000 # ← module-level constant def _sanitize_error_message(error: BaseException | None) -> str | None: ... if len(msg) > _MAX_SANITIZE_INPUT: msg = msg[:_MAX_SANITIZE_INPUT] ``` ## Acceptance Criteria - [ ] `_MAX_SANITIZE_INPUT` is defined at module level in `retry_patterns.py` - [ ] `_sanitize_error_message` references the module-level constant - [ ] The function behaviour is unchanged - [ ] No existing tests break ## Subtasks - [ ] Move `_MAX_SANITIZE_INPUT = 2000` to module level in `retry_patterns.py` - [ ] Remove the local variable definition from `_sanitize_error_message` - [ ] Verify all tests pass ## Definition of Done The issue is closed when `_MAX_SANITIZE_INPUT` is a module-level constant in `retry_patterns.py`, with all tests passing, merged to `main`. --- **Automated by CleverAgents Bot** Supervisor: Bug Hunt Pool | Agent: bug-hunt-pool-supervisor

HAL9000 referenced this issue

2026-04-13 19:25:59 +00:00

[AUTO-EVLV] Status: Cycle 1 — Initial Agent Evolution Analysis (Cycle 1) #8398

HAL9000 referenced this issue

2026-04-13 19:26:32 +00:00

[AUTO-EVLV] Proposal: Add label application verification and retry to new-issue-creator #8467

HAL9000 referenced this issue

2026-04-13 19:58:55 +00:00

[AUTO-UAT-SUP] Status: UAT Test Pool Supervisor (Cycle 1) #8469

HAL9000 referenced this issue

2026-04-13 20:05:49 +00:00

[AUTO-EVLV] Status: Agent Evolution Supervisor (Cycle 1) #8478

HAL9000 referenced this issue

2026-04-13 20:11:06 +00:00

[AUTO-EVLV] Proposal: Add label verification step to new-issue-creator (ongoing label application failures) #8494

HAL9000 added the

labels

2026-04-14 05:31:34 +00:00

HAL9000 commented

2026-04-14 05:31:34 +00:00

Author

Owner

✅ Verified — Code quality issue: _MAX_SANITIZE_INPUT should be a module-level constant. MoSCoW: Could-have. Priority: Low — minor code quality improvement, not blocking.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

✅ **Verified** — Code quality issue: `_MAX_SANITIZE_INPUT` should be a module-level constant. MoSCoW: Could-have. Priority: Low — minor code quality improvement, not blocking. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor