cleveragents/cleveragents-core

Fork 3

actor.py _get_services() and _compute_actor_impact() missing return type annotations on public/protected helpers #8460

New issue

Open

opened 2026-04-13 19:21:50 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-13 19:21:50 +00:00

Owner

Metadata

Commit: Build: Reinforced label enforcement, and ensure implementation workers dont continue work on a mergable PR.
Branch: main

Background and Context

In src/cleveragents/cli/commands/actor.py, two module-level helper functions are missing return type annotations, violating the Code Quality Standards requirement that all public/protected methods have type annotations.

Code evidence (actor.py):

_get_services() — no return type annotation:

def _get_services():
    container = get_container()
    actor_service = container.actor_service()
    actor_registry = (
        container.actor_registry() if hasattr(container, "actor_registry") else None
    )
    return actor_service, actor_registry

The return type should be tuple[ActorService, ActorRegistry | None] (or equivalent).

_parse_option_value(raw_value: str) — no return type annotation:

def _parse_option_value(raw_value: str) -> Any:

Wait — this one does have -> Any. But _get_services() is missing its return annotation entirely.

Additionally, _parse_option_value uses a bare except Exception: (no specific exception type), which violates the no-bare-except rule:

def _parse_option_value(raw_value: str) -> Any:
    try:
        return json.loads(raw_value)
    except Exception:
        lowered = raw_value.lower()
        ...

The bare except Exception: should be except (json.JSONDecodeError, ValueError):.

Expected Behavior

Per Code Quality Standards:

All public/protected methods must have type annotations
No bare except clauses

_get_services() must have a return type annotation. _parse_option_value() must use specific exception types instead of bare except Exception:.

Acceptance Criteria

_get_services() has a complete return type annotation (e.g., -> tuple[ActorService, ActorRegistry | None])
_parse_option_value() replaces bare except Exception: with except (json.JSONDecodeError, ValueError):
pyright / mypy type checking passes on actor.py
Existing BDD tests for actor commands continue to pass

Subtasks

Add return type annotation to _get_services()
Replace bare except Exception: in _parse_option_value() with except (json.JSONDecodeError, ValueError):
Run nox -s typecheck and nox -s lint to confirm no violations
Verify existing actor BDD scenarios pass

Definition of Done

The issue is closed when _get_services() has a return type annotation, _parse_option_value() uses specific exception types, type checking and lint pass cleanly, and all existing tests pass.

Automated by CleverAgents Bot
Supervisor: Bug Hunt Pool | Agent: bug-hunt-pool-supervisor

## Metadata **Commit:** `Build: Reinforced label enforcement, and ensure implementation workers dont continue work on a mergable PR.` **Branch:** `main` ## Background and Context In `src/cleveragents/cli/commands/actor.py`, two module-level helper functions are missing return type annotations, violating the Code Quality Standards requirement that all public/protected methods have type annotations. **Code evidence** (actor.py): 1. `_get_services()` — no return type annotation: ```python def _get_services(): container = get_container() actor_service = container.actor_service() actor_registry = ( container.actor_registry() if hasattr(container, "actor_registry") else None ) return actor_service, actor_registry ``` The return type should be `tuple[ActorService, ActorRegistry | None]` (or equivalent). 2. `_parse_option_value(raw_value: str)` — no return type annotation: ```python def _parse_option_value(raw_value: str) -> Any: ``` Wait — this one does have `-> Any`. But `_get_services()` is missing its return annotation entirely. Additionally, `_parse_option_value` uses a bare `except Exception:` (no specific exception type), which violates the no-bare-except rule: ```python def _parse_option_value(raw_value: str) -> Any: try: return json.loads(raw_value) except Exception: lowered = raw_value.lower() ... ``` The bare `except Exception:` should be `except (json.JSONDecodeError, ValueError):`. ## Expected Behavior Per Code Quality Standards: - All public/protected methods must have type annotations - No bare `except` clauses `_get_services()` must have a return type annotation. `_parse_option_value()` must use specific exception types instead of bare `except Exception:`. ## Acceptance Criteria - [ ] `_get_services()` has a complete return type annotation (e.g., `-> tuple[ActorService, ActorRegistry | None]`) - [ ] `_parse_option_value()` replaces bare `except Exception:` with `except (json.JSONDecodeError, ValueError):` - [ ] `pyright` / `mypy` type checking passes on `actor.py` - [ ] Existing BDD tests for actor commands continue to pass ## Subtasks - [ ] Add return type annotation to `_get_services()` - [ ] Replace bare `except Exception:` in `_parse_option_value()` with `except (json.JSONDecodeError, ValueError):` - [ ] Run `nox -s typecheck` and `nox -s lint` to confirm no violations - [ ] Verify existing actor BDD scenarios pass ## Definition of Done The issue is closed when `_get_services()` has a return type annotation, `_parse_option_value()` uses specific exception types, type checking and lint pass cleanly, and all existing tests pass. --- **Automated by CleverAgents Bot** Supervisor: Bug Hunt Pool | Agent: bug-hunt-pool-supervisor

HAL9000 added this to the v3.2.0 milestone

2026-04-13 20:13:29 +00:00

HAL9000 referenced this issue

2026-04-13 20:33:18 +00:00

[AUTO-IMP-SUP] Status: Implementation Pool Supervisor (Cycle 1) #8513

HAL9000 added the

labels

2026-04-13 20:36:32 +00:00

HAL9000 commented

2026-04-13 20:36:57 +00:00

Author

Owner

[AUTO-OWNR-2] Triage Decision

Status: ✅ Verified

MoSCoW: Should Have
Priority: Low

Rationale: Missing return type annotations on _get_services() and a bare except Exception: in _parse_option_value() are confirmed violations of the project's Code Quality Standards, which mandate type annotations on all public/protected helpers and prohibit bare except clauses. These are real code quality defects that will cause nox -s typecheck and nox -s lint to flag violations. However, they do not block any v3.2.0 milestone feature delivery — they are housekeeping items that should be resolved to keep the codebase clean and compliant. Classified as Should Have / Low priority accordingly.

Next Steps: A developer should add the return type annotation -> tuple[ActorService, ActorRegistry | None] to _get_services() and replace the bare except Exception: in _parse_option_value() with except (json.JSONDecodeError, ValueError):. Run nox -s typecheck and nox -s lint to confirm clean. Existing actor BDD scenarios must continue to pass. This can be batched with other low-priority code quality fixes in actor.py (see also #8438).

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

## [AUTO-OWNR-2] Triage Decision **Status**: ✅ Verified **MoSCoW**: Should Have **Priority**: Low **Rationale**: Missing return type annotations on `_get_services()` and a bare `except Exception:` in `_parse_option_value()` are confirmed violations of the project's Code Quality Standards, which mandate type annotations on all public/protected helpers and prohibit bare except clauses. These are real code quality defects that will cause `nox -s typecheck` and `nox -s lint` to flag violations. However, they do not block any v3.2.0 milestone feature delivery — they are housekeeping items that should be resolved to keep the codebase clean and compliant. Classified as Should Have / Low priority accordingly. **Next Steps**: A developer should add the return type annotation `-> tuple[ActorService, ActorRegistry | None]` to `_get_services()` and replace the bare `except Exception:` in `_parse_option_value()` with `except (json.JSONDecodeError, ValueError):`. Run `nox -s typecheck` and `nox -s lint` to confirm clean. Existing actor BDD scenarios must continue to pass. This can be batched with other low-priority code quality fixes in `actor.py` (see also #8438). --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor

HAL9000 referenced this issue

2026-04-13 20:37:04 +00:00

Forbidden # type: ignore[assignment] annotation in actor.py CLI add command #8438

HAL9000 referenced this issue

2026-04-19 02:19:27 +00:00

Implementation Pool Supervisor - Cycle 54 Status #10667