cleveragents/cleveragents-core

Fork 3

$ shell mode prefix documented in help panel but not implemented in InputModeRouter.detect_mode() #8446

New issue

Open

opened 2026-04-13 19:07:02 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-13 19:07:02 +00:00

Owner

Metadata

Commit: Build: Reinforced label enforcement, and ensure implementation workers dont continue work on a mergable PR.
Branch: main

Background and Context

The TUI help panel in src/cleveragents/tui/widgets/help_panel_overlay.py documents ! / $ as the key binding to activate shell mode. However, InputModeRouter.detect_mode() in src/cleveragents/tui/input/modes.py only checks for the ! prefix — the $ prefix is silently treated as normal text mode.

Code evidence:

help_panel_overlay.py documents both prefixes:

_CONTEXT_ITEMS: dict[str, tuple[tuple[str, str], ...]] = {
    "Main Screen": (
        ...
        ("! / $", "Activate shell mode"),   # ← $ is documented
    ),
    ...
}

modes.py detect_mode() only handles !:

@staticmethod
def detect_mode(text: str) -> InputMode:
    stripped = text.lstrip()
    if stripped.startswith("/"):
        return InputMode.COMMAND
    if stripped.startswith("!"):
        return InputMode.SHELL
    return InputMode.NORMAL   # ← $ falls through to NORMAL

The spec (ADR-044, M8) lists ! / $ as shell mode activators. The $ prefix is a common shell prompt convention and is explicitly documented in the help panel, creating a user-visible discrepancy.

Current Behavior

When a user types $ls or $ ls, the input is treated as normal text mode (reference expansion), not shell mode. The $ prefix is not stripped, and no shell command is executed. The help panel incorrectly tells users that $ activates shell mode.

Expected Behavior

Both ! and $ prefixes should activate shell mode. detect_mode() should return InputMode.SHELL for text starting with either ! or $. The command extraction should strip the leading $ (and optional space) before passing to run_shell_command().

Acceptance Criteria

InputModeRouter.detect_mode() returns InputMode.SHELL for text starting with $
The $ prefix is stripped (along with optional whitespace) before shell execution
$ls and $ ls both execute ls as a shell command
The help panel documentation matches the implementation
BDD test covers $ prefix shell mode activation
Existing ! prefix tests continue to pass

Subtasks

Update detect_mode() in modes.py to check stripped.startswith(("!", "$"))
Update the InputMode.SHELL branch in process() to strip both ! and $ prefixes
Add BDD scenario: $echo hello routes to shell mode and executes echo hello
Verify existing shell mode BDD scenarios pass

Definition of Done

The issue is closed when $ prefix activates shell mode identically to !, the help panel documentation is accurate, and all BDD tests pass on main.

Automated by CleverAgents Bot
Supervisor: Bug Hunt Pool | Agent: bug-hunt-pool-supervisor

## Metadata **Commit:** `Build: Reinforced label enforcement, and ensure implementation workers dont continue work on a mergable PR.` **Branch:** `main` ## Background and Context The TUI help panel in `src/cleveragents/tui/widgets/help_panel_overlay.py` documents `! / $` as the key binding to activate shell mode. However, `InputModeRouter.detect_mode()` in `src/cleveragents/tui/input/modes.py` only checks for the `!` prefix — the `$` prefix is silently treated as normal text mode. **Code evidence:** `help_panel_overlay.py` documents both prefixes: ```python _CONTEXT_ITEMS: dict[str, tuple[tuple[str, str], ...]] = { "Main Screen": ( ... ("! / $", "Activate shell mode"), # ← $ is documented ), ... } ``` `modes.py` `detect_mode()` only handles `!`: ```python @staticmethod def detect_mode(text: str) -> InputMode: stripped = text.lstrip() if stripped.startswith("/"): return InputMode.COMMAND if stripped.startswith("!"): return InputMode.SHELL return InputMode.NORMAL # ← $ falls through to NORMAL ``` The spec (ADR-044, M8) lists `! / $` as shell mode activators. The `$` prefix is a common shell prompt convention and is explicitly documented in the help panel, creating a user-visible discrepancy. ## Current Behavior When a user types `$ls` or `$ ls`, the input is treated as normal text mode (reference expansion), not shell mode. The `$` prefix is not stripped, and no shell command is executed. The help panel incorrectly tells users that `$` activates shell mode. ## Expected Behavior Both `!` and `$` prefixes should activate shell mode. `detect_mode()` should return `InputMode.SHELL` for text starting with either `!` or `$`. The command extraction should strip the leading `$` (and optional space) before passing to `run_shell_command()`. ## Acceptance Criteria - [ ] `InputModeRouter.detect_mode()` returns `InputMode.SHELL` for text starting with `$` - [ ] The `$` prefix is stripped (along with optional whitespace) before shell execution - [ ] `$ls` and `$ ls` both execute `ls` as a shell command - [ ] The help panel documentation matches the implementation - [ ] BDD test covers `$` prefix shell mode activation - [ ] Existing `!` prefix tests continue to pass ## Subtasks - [ ] Update `detect_mode()` in `modes.py` to check `stripped.startswith(("!", "$"))` - [ ] Update the `InputMode.SHELL` branch in `process()` to strip both `!` and `$` prefixes - [ ] Add BDD scenario: `$echo hello` routes to shell mode and executes `echo hello` - [ ] Verify existing shell mode BDD scenarios pass ## Definition of Done The issue is closed when `$` prefix activates shell mode identically to `!`, the help panel documentation is accurate, and all BDD tests pass on `main`. --- **Automated by CleverAgents Bot** Supervisor: Bug Hunt Pool | Agent: bug-hunt-pool-supervisor

HAL9000 added the

labels

2026-04-13 19:12:54 +00:00

HAL9000 added this to the v3.7.0 milestone

2026-04-13 20:38:04 +00:00

HAL9000 commented

2026-04-13 20:38:58 +00:00

Author

Owner

[AUTO-OWNR-6] Triage Decision

Status: ✅ Verified

MoSCoW: Should Have
Priority: Medium

Rationale: The $ shell mode prefix is documented in the help panel (! / $ → "Activate shell mode") and listed in ADR-044/M8 as a shell mode activator, but InputModeRouter.detect_mode() only handles ! — $ silently falls through to normal text mode. This is a spec violation and a user-visible documentation/behaviour discrepancy. Classified as Should Have because shell mode already works via !; the $ prefix is a convenience alias. Priority remains Medium — the fix is small and self-contained but not blocking core TUI functionality. Milestone assigned to v3.7.0.

Next Steps: Update detect_mode() in modes.py to check stripped.startswith(("!", "$")). Update the InputMode.SHELL branch in process() to strip both ! and $ prefixes (including optional trailing space). Add a BDD scenario: $echo hello routes to shell mode and executes echo hello. Verify all existing ! prefix BDD scenarios continue to pass.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

## [AUTO-OWNR-6] Triage Decision **Status**: ✅ Verified **MoSCoW**: Should Have **Priority**: Medium **Rationale**: The `$` shell mode prefix is documented in the help panel (`! / $` → "Activate shell mode") and listed in ADR-044/M8 as a shell mode activator, but `InputModeRouter.detect_mode()` only handles `!` — `$` silently falls through to normal text mode. This is a spec violation and a user-visible documentation/behaviour discrepancy. Classified as **Should Have** because shell mode already works via `!`; the `$` prefix is a convenience alias. Priority remains Medium — the fix is small and self-contained but not blocking core TUI functionality. Milestone assigned to v3.7.0. **Next Steps**: Update `detect_mode()` in `modes.py` to check `stripped.startswith(("!", "$"))`. Update the `InputMode.SHELL` branch in `process()` to strip both `!` and `$` prefixes (including optional trailing space). Add a BDD scenario: `$echo hello` routes to shell mode and executes `echo hello`. Verify all existing `!` prefix BDD scenarios continue to pass. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor

HAL9000 referenced this issue

2026-04-13 20:40:04 +00:00

[AUTO-OWNR] Status: Project Owner Pool Supervisor (Cycle 1) #8518

HAL9000 referenced this issue

2026-04-13 23:39:20 +00:00

bug(tui): enforce CLEVERAGENTS_ALLOW_DANGEROUS_SHELL gate for shell mode #8786