cleveragents/cleveragents-core

Fork 3

`_get_tool_registry_service()` creates undisposed SQLAlchemy engine on every CLI invocation (connection pool leak) #8415

New issue

Open

opened 2026-04-13 18:43:01 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-13 18:43:01 +00:00

Owner

Metadata

Commit message: Build: Reinforced label enforcement, and ensure implementation workers dont continue work on a mergable PR.
Branch: master

Background and Context

In src/cleveragents/cli/commands/tool.py, the function _get_tool_registry_service() creates a new SQLAlchemy engine (and its associated connection pool) on every call, but never disposes it:

def _get_tool_registry_service() -> Any:
    ...
    engine = create_engine(database_url, echo=False)   # new engine + connection pool created
    factory = sessionmaker(bind=engine, expire_on_commit=False)
    tool_repo = ToolRegistryRepository(session_factory=factory)
    attachment_repo = ValidationAttachmentRepository(session_factory=factory)
    return ToolRegistryService(tool_repo=tool_repo, attachment_repo=attachment_repo)
    # engine.dispose() is never called — connection pool is leaked

Every invocation of agents tool add, agents tool remove, agents tool list, or agents tool show calls _get_tool_registry_service(), which creates a new engine. The engine's connection pool is never closed or disposed. For a CLI tool that is invoked repeatedly (e.g., in scripts or automation), this leaks database connections until the process exits.

Current Behavior

Each call to any agents tool subcommand creates a new SQLAlchemy engine with a connection pool. The engine is never disposed. In long-running scripts or automation that invoke agents tool commands in a loop, this causes connection pool exhaustion and potential database connection leaks.

Expected Behavior

Per resource management best practices:

The SQLAlchemy engine should be obtained from the application container (which manages its lifecycle), OR
If a local engine must be created, it must be disposed after use via engine.dispose() or a context manager.
The preferred fix is to obtain ToolRegistryService from the DI container (which already manages the engine lifecycle), eliminating the need for a locally-created engine entirely.

Acceptance Criteria

No locally-created SQLAlchemy engine exists in src/cleveragents/cli/commands/tool.py.
The ToolRegistryService is obtained via the application container.
All agents tool subcommands continue to function correctly.
A Behave BDD scenario verifies that repeated invocations do not leak connections.
nox passes (all sessions).
Coverage remains ≥ 97%.

Subtasks

Remove the locally-created engine and factory from _get_tool_registry_service()
Obtain ToolRegistryService from the application container instead
Verify no engine is created outside the container lifecycle
Add/update Behave BDD scenarios for affected commands
Run nox and confirm all sessions pass

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message is fix(resource): dispose SQLAlchemy engine in tool CLI service factory, followed by a blank line, then additional details, and a footer ISSUES CLOSED: #<this issue number>.
The commit is pushed to a branch and submitted as a pull request to master, reviewed, and merged.
All nox stages pass and coverage ≥ 97%.

Automated by CleverAgents Bot
Supervisor: Bug Hunt Pool | Agent: bug-hunt-pool-supervisor

## Metadata - **Commit message**: `Build: Reinforced label enforcement, and ensure implementation workers dont continue work on a mergable PR.` - **Branch**: `master` ## Background and Context In `src/cleveragents/cli/commands/tool.py`, the function `_get_tool_registry_service()` creates a new SQLAlchemy engine (and its associated connection pool) on every call, but never disposes it: ```python def _get_tool_registry_service() -> Any: ... engine = create_engine(database_url, echo=False) # new engine + connection pool created factory = sessionmaker(bind=engine, expire_on_commit=False) tool_repo = ToolRegistryRepository(session_factory=factory) attachment_repo = ValidationAttachmentRepository(session_factory=factory) return ToolRegistryService(tool_repo=tool_repo, attachment_repo=attachment_repo) # engine.dispose() is never called — connection pool is leaked ``` Every invocation of `agents tool add`, `agents tool remove`, `agents tool list`, or `agents tool show` calls `_get_tool_registry_service()`, which creates a new engine. The engine's connection pool is never closed or disposed. For a CLI tool that is invoked repeatedly (e.g., in scripts or automation), this leaks database connections until the process exits. ## Current Behavior Each call to any `agents tool` subcommand creates a new SQLAlchemy engine with a connection pool. The engine is never disposed. In long-running scripts or automation that invoke `agents tool` commands in a loop, this causes connection pool exhaustion and potential database connection leaks. ## Expected Behavior Per resource management best practices: - The SQLAlchemy engine should be obtained from the application container (which manages its lifecycle), OR - If a local engine must be created, it must be disposed after use via `engine.dispose()` or a context manager. - The preferred fix is to obtain `ToolRegistryService` from the DI container (which already manages the engine lifecycle), eliminating the need for a locally-created engine entirely. ## Acceptance Criteria - [ ] No locally-created SQLAlchemy engine exists in `src/cleveragents/cli/commands/tool.py`. - [ ] The `ToolRegistryService` is obtained via the application container. - [ ] All `agents tool` subcommands continue to function correctly. - [ ] A Behave BDD scenario verifies that repeated invocations do not leak connections. - [ ] `nox` passes (all sessions). - [ ] Coverage remains ≥ 97%. ## Subtasks - [ ] Remove the locally-created `engine` and `factory` from `_get_tool_registry_service()` - [ ] Obtain `ToolRegistryService` from the application container instead - [ ] Verify no engine is created outside the container lifecycle - [ ] Add/update Behave BDD scenarios for affected commands - [ ] Run `nox` and confirm all sessions pass ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message is `fix(resource): dispose SQLAlchemy engine in tool CLI service factory`, followed by a blank line, then additional details, and a footer `ISSUES CLOSED: #<this issue number>`. - The commit is pushed to a branch and submitted as a pull request to `master`, reviewed, and merged. - All nox stages pass and coverage ≥ 97%. --- **Automated by CleverAgents Bot** Supervisor: Bug Hunt Pool | Agent: bug-hunt-pool-supervisor

HAL9000 added the

labels

2026-04-13 18:51:43 +00:00

HAL9000 added this to the v3.6.0 milestone

2026-04-13 19:14:31 +00:00

HAL9000 added

and removed

labels

2026-04-13 19:14:55 +00:00

HAL9000 modified the milestone from v3.6.0 to v3.2.0

2026-04-13 19:17:52 +00:00

HAL9000 commented

2026-04-13 19:19:00 +00:00

Author

Owner

✅ Verified — Creating an undisposed SQLAlchemy engine on every CLI invocation is a connection pool leak. This will cause resource exhaustion in long-running sessions. MoSCoW: Must Have for v3.2.0 — resource management correctness is foundational. [AUTO-OWNR-1]

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

✅ **Verified** — Creating an undisposed SQLAlchemy engine on every CLI invocation is a connection pool leak. This will cause resource exhaustion in long-running sessions. **MoSCoW: Must Have** for v3.2.0 — resource management correctness is foundational. [AUTO-OWNR-1] --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor

HAL9000 referenced this issue

2026-04-13 20:33:18 +00:00

[AUTO-IMP-SUP] Status: Implementation Pool Supervisor (Cycle 1) #8513