cleveragents/cleveragents-core

Fork 3

cleveragents.cli.commands.tool directly imports sqlalchemy (architecture violation) #8413

New issue

Open

opened 2026-04-13 18:42:41 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-13 18:42:41 +00:00

Owner

Metadata

Commit message: Build: Reinforced label enforcement, and ensure implementation workers dont continue work on a mergable PR.
Branch: master

Background and Context

The specification and project code quality standards prohibit cross-layer imports. The CLI layer must not directly import infrastructure libraries such as SQLAlchemy. Issue #8386 already documents this violation in cleveragents.cli.commands.system. The same violation exists in cleveragents.cli.commands.tool.

In src/cleveragents/cli/commands/tool.py, the function _get_tool_registry_service() (lines ~60–80) contains direct SQLAlchemy imports inside the function body:

def _get_tool_registry_service() -> Any:
    from cleveragents.application.container import get_container
    container = get_container()
    database_url: str = container.database_url()

    from sqlalchemy import create_engine          # ← direct SQLAlchemy import in CLI layer
    from sqlalchemy.orm import sessionmaker       # ← direct SQLAlchemy import in CLI layer

    from cleveragents.application.services.tool_registry_service import ToolRegistryService
    from cleveragents.infrastructure.database.repositories import (
        ToolRegistryRepository,
        ValidationAttachmentRepository,
    )

    engine = create_engine(database_url, echo=False)
    factory = sessionmaker(bind=engine, expire_on_commit=False)
    tool_repo = ToolRegistryRepository(session_factory=factory)
    attachment_repo = ValidationAttachmentRepository(session_factory=factory)
    return ToolRegistryService(tool_repo=tool_repo, attachment_repo=attachment_repo)

This is the same architecture violation as #8386 (cleveragents.cli.commands.system directly imports sqlalchemy). The CLI layer should obtain the ToolRegistryService from the DI container, not construct it manually with raw SQLAlchemy primitives.

Current Behavior

agents tool add, agents tool remove, agents tool list, and agents tool show all call _get_tool_registry_service(), which directly imports and uses SQLAlchemy in the CLI layer. This bypasses the application container's dependency injection and creates a tight coupling between the CLI and the infrastructure layer.

Expected Behavior

Per the architecture standards and the fix pattern established for #8386:

_get_tool_registry_service() must be removed or replaced.
The ToolRegistryService must be obtained via get_container().tool_registry_service() (or equivalent DI accessor).
No SQLAlchemy imports should appear in src/cleveragents/cli/commands/tool.py.

Acceptance Criteria

src/cleveragents/cli/commands/tool.py contains no import sqlalchemy or from sqlalchemy statements.
ToolRegistryService is obtained via the application container (DI), not constructed manually.
All agents tool subcommands (add, remove, list, show) continue to work correctly.
A Behave BDD scenario verifies the agents tool commands function end-to-end.
nox passes (all sessions).
Coverage remains ≥ 97%.

Subtasks

Remove _get_tool_registry_service() function from src/cleveragents/cli/commands/tool.py
Add tool_registry_service() accessor to the application container (if not already present)
Update all four CLI commands (add, remove, list, show) to use the container accessor
Verify no SQLAlchemy imports remain in the CLI layer for this module
Add/update Behave BDD scenarios for affected commands
Run nox and confirm all sessions pass

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message is fix(cli): remove direct sqlalchemy import from cleveragents.cli.commands.tool, followed by a blank line, then additional details, and a footer ISSUES CLOSED: #<this issue number>.
The commit is pushed to a branch and submitted as a pull request to master, reviewed, and merged.
All nox stages pass and coverage ≥ 97%.

Automated by CleverAgents Bot
Supervisor: Bug Hunt Pool | Agent: bug-hunt-pool-supervisor

## Metadata - **Commit message**: `Build: Reinforced label enforcement, and ensure implementation workers dont continue work on a mergable PR.` - **Branch**: `master` ## Background and Context The specification and project code quality standards prohibit cross-layer imports. The CLI layer must not directly import infrastructure libraries such as SQLAlchemy. Issue #8386 already documents this violation in `cleveragents.cli.commands.system`. The same violation exists in `cleveragents.cli.commands.tool`. In `src/cleveragents/cli/commands/tool.py`, the function `_get_tool_registry_service()` (lines ~60–80) contains direct SQLAlchemy imports inside the function body: ```python def _get_tool_registry_service() -> Any: from cleveragents.application.container import get_container container = get_container() database_url: str = container.database_url() from sqlalchemy import create_engine # ← direct SQLAlchemy import in CLI layer from sqlalchemy.orm import sessionmaker # ← direct SQLAlchemy import in CLI layer from cleveragents.application.services.tool_registry_service import ToolRegistryService from cleveragents.infrastructure.database.repositories import ( ToolRegistryRepository, ValidationAttachmentRepository, ) engine = create_engine(database_url, echo=False) factory = sessionmaker(bind=engine, expire_on_commit=False) tool_repo = ToolRegistryRepository(session_factory=factory) attachment_repo = ValidationAttachmentRepository(session_factory=factory) return ToolRegistryService(tool_repo=tool_repo, attachment_repo=attachment_repo) ``` This is the same architecture violation as #8386 (`cleveragents.cli.commands.system` directly imports sqlalchemy). The CLI layer should obtain the `ToolRegistryService` from the DI container, not construct it manually with raw SQLAlchemy primitives. ## Current Behavior `agents tool add`, `agents tool remove`, `agents tool list`, and `agents tool show` all call `_get_tool_registry_service()`, which directly imports and uses SQLAlchemy in the CLI layer. This bypasses the application container's dependency injection and creates a tight coupling between the CLI and the infrastructure layer. ## Expected Behavior Per the architecture standards and the fix pattern established for #8386: - `_get_tool_registry_service()` must be removed or replaced. - The `ToolRegistryService` must be obtained via `get_container().tool_registry_service()` (or equivalent DI accessor). - No SQLAlchemy imports should appear in `src/cleveragents/cli/commands/tool.py`. ## Acceptance Criteria - [ ] `src/cleveragents/cli/commands/tool.py` contains no `import sqlalchemy` or `from sqlalchemy` statements. - [ ] `ToolRegistryService` is obtained via the application container (DI), not constructed manually. - [ ] All `agents tool` subcommands (`add`, `remove`, `list`, `show`) continue to work correctly. - [ ] A Behave BDD scenario verifies the `agents tool` commands function end-to-end. - [ ] `nox` passes (all sessions). - [ ] Coverage remains ≥ 97%. ## Subtasks - [ ] Remove `_get_tool_registry_service()` function from `src/cleveragents/cli/commands/tool.py` - [ ] Add `tool_registry_service()` accessor to the application container (if not already present) - [ ] Update all four CLI commands (`add`, `remove`, `list`, `show`) to use the container accessor - [ ] Verify no SQLAlchemy imports remain in the CLI layer for this module - [ ] Add/update Behave BDD scenarios for affected commands - [ ] Run `nox` and confirm all sessions pass ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message is `fix(cli): remove direct sqlalchemy import from cleveragents.cli.commands.tool`, followed by a blank line, then additional details, and a footer `ISSUES CLOSED: #<this issue number>`. - The commit is pushed to a branch and submitted as a pull request to `master`, reviewed, and merged. - All nox stages pass and coverage ≥ 97%. --- **Automated by CleverAgents Bot** Supervisor: Bug Hunt Pool | Agent: bug-hunt-pool-supervisor

HAL9000 added the

labels

2026-04-13 18:49:19 +00:00

HAL9000 added this to the v3.6.0 milestone

2026-04-13 19:14:30 +00:00

HAL9000 added

and removed

labels

2026-04-13 19:16:33 +00:00

HAL9000 modified the milestone from v3.6.0 to v3.2.0

2026-04-13 19:17:53 +00:00

HAL9000 commented

2026-04-13 19:19:03 +00:00

Author

Owner

✅ Verified — Direct SQLAlchemy import in CLI layer is an architecture violation per project rules. CLI must only interact with the application layer. MoSCoW: Must Have for v3.2.0 — architecture compliance is enforced by the guard system. [AUTO-OWNR-1]

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

✅ **Verified** — Direct SQLAlchemy import in CLI layer is an architecture violation per project rules. CLI must only interact with the application layer. **MoSCoW: Must Have** for v3.2.0 — architecture compliance is enforced by the guard system. [AUTO-OWNR-1] --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor

HAL9000 referenced this issue

2026-04-13 20:33:18 +00:00

[AUTO-IMP-SUP] Status: Implementation Pool Supervisor (Cycle 1) #8513