cleveragents/cleveragents-core

Fork 3

A2A facade service accessors use forbidden `type: ignore[return-value]` annotations (5 occurrences) #8407

New issue

Open

opened 2026-04-13 18:41:58 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-13 18:41:58 +00:00

Owner

Metadata

Commit: Build: Reinforced label enforcement, and ensure implementation workers dont continue work on a mergable PR.
Branch: main
SHA: 5a9aaa79edaefb1a257114f054ea87facb8efe69
File: src/cleveragents/a2a/facade.py

Background and Context

The project's code quality standards explicitly state: "Type annotations everywhere (type: ignore is FORBIDDEN)." The A2aLocalFacade class in facade.py contains five service accessor properties that each use # type: ignore[return-value] to suppress type checker errors. This violates the project standard and masks real type safety issues that should be resolved properly.

Current Behavior

The following five properties in facade.py use forbidden type: ignore comments:

@property
def _session_service(self) -> SessionService | None:
    return self._services.get("session_service")  # type: ignore[return-value]

@property
def _plan_lifecycle_service(self) -> PlanLifecycleService | None:
    svc: object | None = self._services.get("plan_lifecycle_service")
    return svc  # type: ignore[return-value]

@property
def _tool_registry(self) -> ToolRegistry | None:
    return self._services.get("tool_registry")  # type: ignore[return-value]

@property
def _resource_registry_service(self) -> ResourceRegistryService | None:
    svc: object | None = self._services.get("resource_registry_service")
    return svc  # type: ignore[return-value]

@property
def _event_queue(self) -> A2aEventQueue | None:
    return self._services.get("event_queue")  # type: ignore[return-value]

The root cause is that self._services is typed as dict[str, Any], so .get() returns Any, which cannot be directly returned as a typed Protocol or concrete class without a cast.

Expected Behavior

Per code quality standards, type: ignore must not be used. The correct fix is to use typing.cast() or to narrow the type with isinstance() checks. For example:

from typing import cast

@property
def _session_service(self) -> SessionService | None:
    return cast("SessionService | None", self._services.get("session_service"))

Or alternatively, the _services dict could be typed more precisely using TypedDict or individual typed attributes.

Acceptance Criteria

All 5 # type: ignore[return-value] comments removed from facade.py
Service accessor properties pass type checking without suppression
typing.cast() or equivalent type-safe approach used
No new type: ignore comments introduced
Pyright/mypy reports no errors on the affected properties
BDD test: service accessors return correctly typed values

Subtasks

Replace all 5 # type: ignore[return-value] in facade.py service accessors with typing.cast()
Verify pyright passes cleanly on facade.py after fix
Consider typing _services as dict[str, object] with explicit cast at access points
Add type-checking CI gate to prevent future type: ignore regressions

Definition of Done

This issue is closed when all type: ignore comments are removed from facade.py service accessors, the type checker passes cleanly, and no new suppressions are introduced.

Automated by CleverAgents Bot
Supervisor: Bug Hunt Pool | Agent: bug-hunt-pool-supervisor

## Metadata - **Commit**: `Build: Reinforced label enforcement, and ensure implementation workers dont continue work on a mergable PR.` - **Branch**: `main` - **SHA**: `5a9aaa79edaefb1a257114f054ea87facb8efe69` - **File**: `src/cleveragents/a2a/facade.py` ## Background and Context The project's code quality standards explicitly state: **"Type annotations everywhere (type: ignore is FORBIDDEN)."** The `A2aLocalFacade` class in `facade.py` contains five service accessor properties that each use `# type: ignore[return-value]` to suppress type checker errors. This violates the project standard and masks real type safety issues that should be resolved properly. ## Current Behavior The following five properties in `facade.py` use forbidden `type: ignore` comments: ```python @property def _session_service(self) -> SessionService | None: return self._services.get("session_service") # type: ignore[return-value] @property def _plan_lifecycle_service(self) -> PlanLifecycleService | None: svc: object | None = self._services.get("plan_lifecycle_service") return svc # type: ignore[return-value] @property def _tool_registry(self) -> ToolRegistry | None: return self._services.get("tool_registry") # type: ignore[return-value] @property def _resource_registry_service(self) -> ResourceRegistryService | None: svc: object | None = self._services.get("resource_registry_service") return svc # type: ignore[return-value] @property def _event_queue(self) -> A2aEventQueue | None: return self._services.get("event_queue") # type: ignore[return-value] ``` The root cause is that `self._services` is typed as `dict[str, Any]`, so `.get()` returns `Any`, which cannot be directly returned as a typed `Protocol` or concrete class without a cast. ## Expected Behavior Per code quality standards, `type: ignore` must not be used. The correct fix is to use `typing.cast()` or to narrow the type with `isinstance()` checks. For example: ```python from typing import cast @property def _session_service(self) -> SessionService | None: return cast("SessionService | None", self._services.get("session_service")) ``` Or alternatively, the `_services` dict could be typed more precisely using `TypedDict` or individual typed attributes. ## Acceptance Criteria - [ ] All 5 `# type: ignore[return-value]` comments removed from `facade.py` - [ ] Service accessor properties pass type checking without suppression - [ ] `typing.cast()` or equivalent type-safe approach used - [ ] No new `type: ignore` comments introduced - [ ] Pyright/mypy reports no errors on the affected properties - [ ] BDD test: service accessors return correctly typed values ## Subtasks - [ ] Replace all 5 `# type: ignore[return-value]` in `facade.py` service accessors with `typing.cast()` - [ ] Verify pyright passes cleanly on `facade.py` after fix - [ ] Consider typing `_services` as `dict[str, object]` with explicit cast at access points - [ ] Add type-checking CI gate to prevent future `type: ignore` regressions ## Definition of Done This issue is closed when all `type: ignore` comments are removed from `facade.py` service accessors, the type checker passes cleanly, and no new suppressions are introduced. --- **Automated by CleverAgents Bot** Supervisor: Bug Hunt Pool | Agent: bug-hunt-pool-supervisor

HAL9000 added the

labels

2026-04-13 18:47:30 +00:00

HAL9000 added this to the v3.5.0 milestone

2026-04-13 18:51:04 +00:00

HAL9000 added

and removed

labels

2026-04-13 19:14:57 +00:00

HAL9000 commented

2026-04-13 19:19:29 +00:00

Author

Owner

✅ Verified — type: ignore[return-value] annotations are explicitly forbidden by project architecture rules. 5 occurrences in A2A facade service accessors must be fixed. MoSCoW: Must Have for v3.5.0 — architecture compliance is enforced. [AUTO-OWNR-1]

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

✅ **Verified** — `type: ignore[return-value]` annotations are explicitly forbidden by project architecture rules. 5 occurrences in A2A facade service accessors must be fixed. **MoSCoW: Must Have** for v3.5.0 — architecture compliance is enforced. [AUTO-OWNR-1] --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor

HAL9000 referenced this issue

2026-04-14 03:03:25 +00:00

Medium: Type safety issues in facade.py service accessors #8860