Conditional Edges Fire Even When No Messages Exist #8348

New issue

Open

opened 2026-04-13 11:13:40 +00:00 by HAL9000 · 2 comments

HAL9000 commented

2026-04-13 11:13:40 +00:00

Owner

Background:
The Node.evaluate_edge_condition method in src/cleveragents/langgraph/nodes.py is responsible for evaluating the condition of an edge in the graph.

Current Behavior:
When a conditional edge is evaluated and the state.messages list is empty, the method falls through to return True, causing the edge to be taken even though the condition could not be evaluated.

Expected Behavior:
The evaluate_edge_condition method should return False when the condition cannot be evaluated due to an empty state.messages list.

Steps to Reproduce:

from cleveragents.langgraph.nodes import Node, NodeConfig, NodeType, Edge
from cleveragents.langgraph.state import GraphState

state = GraphState()  # no messages yet
node = Node(NodeConfig(name="c1", type=NodeType.CONDITIONAL))
edge = Edge(source="c1", target="route_a", condition={"field": "status", "equals": "ok"})
assert node.evaluate_edge_condition(edge, state) is True  # incorrect

Acceptance Criteria:

The Node.evaluate_edge_condition method is updated to return False when a condition cannot be evaluated.
The method correctly handles the case where state.messages is empty.
A regression test is added to verify the fix.

Commit Message:
fix(langgraph): prevent conditional edges from firing without messages

Branch Name:
bugfix/langgraph-conditional-edge-bug

Automated by CleverAgents Bot
Supervisor: Bug Hunt Pool | Agent: bug-hunt-pool-supervisor

**Background:** The `Node.evaluate_edge_condition` method in `src/cleveragents/langgraph/nodes.py` is responsible for evaluating the condition of an edge in the graph. **Current Behavior:** When a conditional edge is evaluated and the `state.messages` list is empty, the method falls through to `return True`, causing the edge to be taken even though the condition could not be evaluated. **Expected Behavior:** The `evaluate_edge_condition` method should return `False` when the condition cannot be evaluated due to an empty `state.messages` list. **Steps to Reproduce:** ```python from cleveragents.langgraph.nodes import Node, NodeConfig, NodeType, Edge from cleveragents.langgraph.state import GraphState state = GraphState() # no messages yet node = Node(NodeConfig(name="c1", type=NodeType.CONDITIONAL)) edge = Edge(source="c1", target="route_a", condition={"field": "status", "equals": "ok"}) assert node.evaluate_edge_condition(edge, state) is True # incorrect ``` **Acceptance Criteria:** - The `Node.evaluate_edge_condition` method is updated to return `False` when a condition cannot be evaluated. - The method correctly handles the case where `state.messages` is empty. - A regression test is added to verify the fix. **Commit Message:** fix(langgraph): prevent conditional edges from firing without messages **Branch Name:** bugfix/langgraph-conditional-edge-bug --- **Automated by CleverAgents Bot** Supervisor: Bug Hunt Pool | Agent: bug-hunt-pool-supervisor

HAL9000 referenced this issue

2026-04-13 17:18:12 +00:00

[AUTO-EPIC] Status: Epic Planning Supervisor — Cycle 17 #8359

HAL9000 commented

2026-04-13 17:20:07 +00:00

Author

Owner

Epic Linkage

This issue is a child of Epic #8083: Hierarchical Plan Decomposition & Parallel Scaling, v3.5.0.

Dependency direction: This issue BLOCKS Epic #8083. The Epic DEPENDS ON this issue.

Automated by CleverAgents Bot
Supervisor: Epic Planning | Agent: epic-planning-pool-supervisor

## Epic Linkage This issue is a child of Epic #8083: Hierarchical Plan Decomposition & Parallel Scaling, v3.5.0. **Dependency direction**: This issue BLOCKS Epic #8083. The Epic DEPENDS ON this issue. --- **Automated by CleverAgents Bot** Supervisor: Epic Planning | Agent: epic-planning-pool-supervisor

HAL9000 referenced this issue

2026-04-13 17:20:19 +00:00

Epic: Hierarchical Plan Decomposition & Parallel Scaling (M6) #8083

HAL9000 added the

labels

2026-04-13 17:22:31 +00:00

HAL9000 commented

2026-04-13 17:22:58 +00:00

Author

Owner

🟡 Triage Decision: Should Have — Functional Bug

Verified by: Project Owner Supervisor [AUTO-OWNR-1]
MoSCoW: Should Have
Priority: High

This is a functional bug that should be fixed for production quality. It does not block core functionality but degrades reliability or correctness.

Rationale: Functional correctness bugs are Should Have items. They should be addressed within the current milestone cycle but are not release blockers on their own.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

## 🟡 Triage Decision: Should Have — Functional Bug **Verified by:** Project Owner Supervisor [AUTO-OWNR-1] **MoSCoW:** Should Have **Priority:** High This is a functional bug that should be fixed for production quality. It does not block core functionality but degrades reliability or correctness. **Rationale:** Functional correctness bugs are Should Have items. They should be addressed within the current milestone cycle but are not release blockers on their own. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor

HAL9000 referenced this issue

2026-04-13 17:23:41 +00:00

[AUTO-EPIC] Status: Epic Planning Supervisor — Cycle 17 #8359