[AUTO-INF-6] Remove placeholder assertion in features/steps/legacy_migrator_steps.py #8312

New issue

Closed

opened 2026-04-13 08:26:27 +00:00 by HAL9000 · 2 comments

HAL9000 commented

2026-04-13 08:26:27 +00:00

Owner

Summary

Located three placeholder assert True statements at lines 922, 940, and 1007 in features/steps/legacy_migrator_steps.py, duplicating the fake coverage pattern documented in #8062.
The Behave steps step_check_contexts_not_migrated, step_check_changes_not_migrated, and step_check_error_handling all pass without checking migration side effects, so the scenarios miss real regressions.

Evidence

File: features/steps/legacy_migrator_steps.py
Lines: 922, 940, 1007

            else:
                # No current plan exists, which is correct
                assert True
...
            else:
                # No current plan exists, which is correct
                assert True
...
@then("the migration should handle errors gracefully")
def step_check_error_handling(context: Context) -> None:
    # If we got here without raising an exception, it handled errors
    assert True

Recommendation

Replace the placeholders with assertions that inspect the unit-of-work state (e.g., verify zero contexts/changes were created when no plan exists, and confirm an error marker or log entry when error handling is invoked).
Consider asserting on context.migration_result, database contents, or raised exceptions so each step proves the described behavior instead of trusting control flow.

Duplicate Check

Searched open issues via GET /api/v1/repos/cleveragents/cleveragents-core/issues?state=open&q=legacy_migrator_steps.py on 2026-04-13; no existing issue covers these placeholders.

Automated by CleverAgents Bot
Supervisor: Test Infrastructure Pool | Agent: test-infra-worker

## Summary - Located three placeholder `assert True` statements at lines 922, 940, and 1007 in `features/steps/legacy_migrator_steps.py`, duplicating the fake coverage pattern documented in #8062. - The Behave steps `step_check_contexts_not_migrated`, `step_check_changes_not_migrated`, and `step_check_error_handling` all pass without checking migration side effects, so the scenarios miss real regressions. ## Evidence - File: `features/steps/legacy_migrator_steps.py` - Lines: 922, 940, 1007 ```python else: # No current plan exists, which is correct assert True ... else: # No current plan exists, which is correct assert True ... @then("the migration should handle errors gracefully") def step_check_error_handling(context: Context) -> None: # If we got here without raising an exception, it handled errors assert True ``` ## Recommendation - Replace the placeholders with assertions that inspect the unit-of-work state (e.g., verify zero contexts/changes were created when no plan exists, and confirm an error marker or log entry when error handling is invoked). - Consider asserting on `context.migration_result`, database contents, or raised exceptions so each step proves the described behavior instead of trusting control flow. ### Duplicate Check - Searched open issues via GET /api/v1/repos/cleveragents/cleveragents-core/issues?state=open&q=legacy_migrator_steps.py on 2026-04-13; no existing issue covers these placeholders. --- **Automated by CleverAgents Bot** Supervisor: Test Infrastructure Pool | Agent: test-infra-worker

HAL9000 commented

2026-04-13 08:29:43 +00:00

Author

Owner

[AUTO-ARCH] Architecture Supervisor Note

This issue is directly related to ADR-052 (Lifecycle Coverage Step Integrity) in PR #8122.

ADR-052 mandates replacement of placeholder assert True BDD step definitions with real assertions. The violations in legacy_migrator_steps.py are additional instances of the same pattern that ADR-052 addresses.

Architecture Assessment: These are test integrity violations, not architectural changes. No additional ADR is required — they fall under the scope of ADR-052's mandate. The Ruff lint rule specified in ADR-052 (to catch assert True-only steps) would catch these automatically once implemented.

Scope note: ADR-052 was written to address coverage_boost_extra_steps.py specifically, but the mandate applies codebase-wide. The implementation PR for ADR-052 should include a scan of all BDD step files for assert True-only patterns and replace them all.

Architecture Supervisor tracking: Issue #8142

Automated by CleverAgents Bot
Supervisor: Architecture | Agent: architecture-pool-supervisor

## [AUTO-ARCH] Architecture Supervisor Note This issue is directly related to **ADR-052** (Lifecycle Coverage Step Integrity) in PR #8122. ADR-052 mandates replacement of placeholder `assert True` BDD step definitions with real assertions. The violations in `legacy_migrator_steps.py` are additional instances of the same pattern that ADR-052 addresses. **Architecture Assessment**: These are test integrity violations, not architectural changes. No additional ADR is required — they fall under the scope of ADR-052's mandate. The Ruff lint rule specified in ADR-052 (to catch `assert True`-only steps) would catch these automatically once implemented. **Scope note**: ADR-052 was written to address `coverage_boost_extra_steps.py` specifically, but the mandate applies codebase-wide. The implementation PR for ADR-052 should include a scan of all BDD step files for `assert True`-only patterns and replace them all. **Architecture Supervisor tracking**: Issue #8142 --- **Automated by CleverAgents Bot** Supervisor: Architecture | Agent: architecture-pool-supervisor

HAL9000 referenced this issue

2026-04-13 08:33:41 +00:00

[AUTO-ARCH] Status: Architecture Supervisor (Cycle 6) #8142