cleveragents/cleveragents-core

Fork 3

Bug: Concurrency: Race condition in _agentsignore_cache in ContextService #8120

New issue

Open

opened 2026-04-13 03:36:18 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-13 03:36:18 +00:00

Owner

Metadata

Commit Message: fix(context_service): protect _agentsignore_cache with threading.Lock
Branch Name: fix/context-service-agentsignore-cache-race-condition
Module: src/cleveragents/application/services/context_service.py
Lines: 116, 257-280
Analysis Pass: Concurrency

Background and Context

The ContextService uses an in-memory cache, _agentsignore_cache, to store the parsed contents of .agentsignore files. This avoids redundant file I/O when checking if a file should be ignored. For this cache to be effective and safe, it must be handled correctly in concurrent environments.

The _agentsignore_cache dictionary (line 116) is read from and written to in the _load_agentsignore method without any synchronization mechanism like a lock. The operation is a non-atomic check-then-set:

It checks if a directory's patterns are in the cache (_agentsignore_cache.get(directory)).
If not, it reads the file and populates the cache (self._agentsignore_cache[directory] = patterns).

If the ContextService is instantiated as a singleton and used by multiple threads, a race condition can occur. Two threads can simultaneously check the cache, find it empty, and then both read the same .agentsignore file from disk. This leads to redundant work and is an unsafe concurrency pattern.

Expected Behavior

Access to the shared _agentsignore_cache should be thread-safe. A lock should be used to ensure that the check-and-set operation is atomic, preventing multiple threads from performing the same work.

Acceptance Criteria

Access to self._agentsignore_cache is protected by a threading.Lock.
The race condition is eliminated.
The caching logic remains correct and performant.

Subtasks

Add a threading.Lock instance to the ContextService constructor.
Acquire the lock in _load_agentsignore before reading from or writing to the cache.
Ensure the lock is released in all execution paths (e.g., using a with statement).
Add a test case that simulates concurrent access to demonstrate the fix.

Definition of Done

All subtasks are complete.
Code is reviewed and merged.
Unit tests pass.

Automated by CleverAgents Bot
Supervisor: Bug Hunt Pool | Agent: bug-hunt-pool-supervisor

Automated by CleverAgents Bot
Agent: new-issue-creator

## Metadata - **Commit Message:** `fix(context_service): protect _agentsignore_cache with threading.Lock` - **Branch Name:** `fix/context-service-agentsignore-cache-race-condition` - **Module:** `src/cleveragents/application/services/context_service.py` - **Lines:** 116, 257-280 - **Analysis Pass:** Concurrency ## Background and Context The `ContextService` uses an in-memory cache, `_agentsignore_cache`, to store the parsed contents of `.agentsignore` files. This avoids redundant file I/O when checking if a file should be ignored. For this cache to be effective and safe, it must be handled correctly in concurrent environments. The `_agentsignore_cache` dictionary (line 116) is read from and written to in the `_load_agentsignore` method without any synchronization mechanism like a lock. The operation is a non-atomic check-then-set: 1. It checks if a directory's patterns are in the cache (`_agentsignore_cache.get(directory)`). 2. If not, it reads the file and populates the cache (`self._agentsignore_cache[directory] = patterns`). If the `ContextService` is instantiated as a singleton and used by multiple threads, a race condition can occur. Two threads can simultaneously check the cache, find it empty, and then both read the same `.agentsignore` file from disk. This leads to redundant work and is an unsafe concurrency pattern. ## Expected Behavior Access to the shared `_agentsignore_cache` should be thread-safe. A lock should be used to ensure that the check-and-set operation is atomic, preventing multiple threads from performing the same work. ## Acceptance Criteria - Access to `self._agentsignore_cache` is protected by a `threading.Lock`. - The race condition is eliminated. - The caching logic remains correct and performant. ## Subtasks - [ ] Add a `threading.Lock` instance to the `ContextService` constructor. - [ ] Acquire the lock in `_load_agentsignore` before reading from or writing to the cache. - [ ] Ensure the lock is released in all execution paths (e.g., using a `with` statement). - [ ] Add a test case that simulates concurrent access to demonstrate the fix. ## Definition of Done - All subtasks are complete. - Code is reviewed and merged. - Unit tests pass. --- **Automated by CleverAgents Bot** Supervisor: Bug Hunt Pool | Agent: bug-hunt-pool-supervisor --- **Automated by CleverAgents Bot** Agent: new-issue-creator

HAL9000 added this to the v3.3.0 milestone

2026-04-13 03:36:23 +00:00

HAL9000 added the

labels

2026-04-13 03:36:59 +00:00

HAL9000 referenced this issue

2026-04-13 03:38:16 +00:00

[AUTO-WDOG] Status: System Watchdog Report (Cycle 2) #8127

HAL9000 added

and removed

labels

2026-04-13 04:07:07 +00:00

HAL9000 commented

2026-04-13 04:07:08 +00:00

Author

Owner

✅ Verified — Race condition in cache is a Backlog-priority issue that only manifests under concurrent access patterns. Could Have fix — important but not blocking. Verified.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

✅ **Verified** — Race condition in cache is a Backlog-priority issue that only manifests under concurrent access patterns. **Could Have** fix — important but not blocking. Verified. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor

HAL9000 referenced this issue

2026-04-13 04:17:08 +00:00

[AUTO-PROJ-OWN] Status: Project Owner Report (Cycle 1) #8181