Error Handling: Broad exception clauses in ContextService swallow errors and hide bugs #8112

New issue

Open

opened 2026-04-13 03:34:55 +00:00 by HAL9000 · 0 comments

HAL9000 commented

2026-04-13 03:34:55 +00:00

Owner

Metadata

Commit message: fix(context_service): replace broad except Exception with specific handlers and log warnings
Branch name: fix/context-service-broad-exception-handling
Module: src/cleveragents/application/services/context_service.py
Lines: 253, 275
Analysis Pass: Error Handling

Background and Context

The ContextService is responsible for reading files from the filesystem to add them to the AI's context or to process .agentsignore rules. Robust error handling is critical to ensure that file-related issues are visible and debuggable.

In _add_file_to_context (line 253) and _load_agentsignore (line 275), the code uses broad except Exception: clauses. These clauses catch all possible errors (including IOError, PermissionError, UnicodeDecodeError, etc.) and handle them silently.

When adding a file, an error causes the file to be skipped with no log or warning.
When loading an ignore file, an error causes the file's rules to be ignored.

This makes it impossible for developers or users to diagnose why a specific file is not being added to the context or why an ignore rule is not working.

Expected Behavior

Exceptions during file operations should be handled more granularly:

Specific exceptions (e.g., IOError, PermissionError, UnicodeDecodeError) should be caught.
A warning should be logged containing the file path and the specific error message.
The file should still be skipped (or rules ignored), but the failure should be observable in the logs.

Acceptance Criteria

The except Exception: on line 253 is replaced with more specific exception handling.
The except Exception: on line 275 is replaced with more specific exception handling.
Errors caught in these blocks are logged as warnings with relevant context (file path, error).

Subtasks

Refactor the try...except block in _add_file_to_context to catch specific file-related exceptions and log warnings.
Refactor the try...except block in _load_agentsignore to catch specific file-related exceptions and log warnings.
Add unit tests to verify that errors are logged correctly when file operations fail.

Definition of Done

All subtasks are complete.
Code is reviewed and merged.
Unit tests pass.

Automated by CleverAgents Bot
Supervisor: Bug Hunt Pool | Agent: bug-hunt-pool-supervisor

Automated by CleverAgents Bot
Agent: new-issue-creator

## Metadata - **Commit message:** `fix(context_service): replace broad except Exception with specific handlers and log warnings` - **Branch name:** `fix/context-service-broad-exception-handling` - **Module:** `src/cleveragents/application/services/context_service.py` - **Lines:** 253, 275 - **Analysis Pass:** Error Handling ## Background and Context The `ContextService` is responsible for reading files from the filesystem to add them to the AI's context or to process `.agentsignore` rules. Robust error handling is critical to ensure that file-related issues are visible and debuggable. In `_add_file_to_context` (line 253) and `_load_agentsignore` (line 275), the code uses broad `except Exception:` clauses. These clauses catch all possible errors (including `IOError`, `PermissionError`, `UnicodeDecodeError`, etc.) and handle them silently. - When adding a file, an error causes the file to be skipped with no log or warning. - When loading an ignore file, an error causes the file's rules to be ignored. This makes it impossible for developers or users to diagnose why a specific file is not being added to the context or why an ignore rule is not working. ## Expected Behavior Exceptions during file operations should be handled more granularly: - Specific exceptions (e.g., `IOError`, `PermissionError`, `UnicodeDecodeError`) should be caught. - A warning should be logged containing the file path and the specific error message. - The file should still be skipped (or rules ignored), but the failure should be observable in the logs. ## Acceptance Criteria - The `except Exception:` on line 253 is replaced with more specific exception handling. - The `except Exception:` on line 275 is replaced with more specific exception handling. - Errors caught in these blocks are logged as warnings with relevant context (file path, error). ## Subtasks - [ ] Refactor the `try...except` block in `_add_file_to_context` to catch specific file-related exceptions and log warnings. - [ ] Refactor the `try...except` block in `_load_agentsignore` to catch specific file-related exceptions and log warnings. - [ ] Add unit tests to verify that errors are logged correctly when file operations fail. ## Definition of Done - All subtasks are complete. - Code is reviewed and merged. - Unit tests pass. --- **Automated by CleverAgents Bot** Supervisor: Bug Hunt Pool | Agent: bug-hunt-pool-supervisor --- **Automated by CleverAgents Bot** Agent: new-issue-creator

HAL9000 added this to the v3.2.0 milestone

2026-04-13 03:35:00 +00:00

HAL9000 referenced this issue

2026-04-14 07:36:14 +00:00

test-infra: Add Semgrep guard for broad exception suppression #9103