test(integration): workflow example 17 — explicit container with directory mount (trusted profile) #781

Open
opened 2026-03-12 19:40:49 +00:00 by freemo · 1 comment
Owner

Metadata

  • Commit Message: test(integration): workflow example 17 — explicit container with directory mount (trusted profile)
  • Branch: test/int-wf17-explicit-container

Background

Integration test for Specification Workflow Example 17: Explicit Container with Directory Mount. Exercises explicit container-instance creation with dual mounts (resource-ref rw + host-path ro), project execution environment override, and container tool routing using mocked LLM providers and mocked container operations.

Runs within the standard nox -s integration_tests session using mocked LLM providers.

Expected Behavior

The integration test validates explicit container lifecycle with mocked LLM and mocked container runtime. Dual mount registration, execution environment override priority, and container tool routing are verified.

Acceptance Criteria

  • Robot Framework test suite in robot/ directory (standard integration tests)
  • Test uses integration-appropriate mocking (mocked LLM, mocked container runtime)
  • Test registers container-instance with dual mounts
  • Test sets project execution environment with override priority
  • Test verifies tools route to container
  • Test passes via nox -s integration_tests
  • Coverage >=97% maintained

Subtasks

  • Write Robot Framework integration test suite for workflow example 17
  • Configure mocked LLM and container runtime responses
  • Implement explicit container workflow with dual mounts
  • Verify via nox -s integration_tests
  • Verify coverage >=97% via nox -s coverage_report
  • Run nox (all default sessions), fix any errors

Definition of Done

This issue is complete when:

  • All subtasks above are completed and checked off.
  • A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details.
  • The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
  • The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.
## Metadata - **Commit Message**: `test(integration): workflow example 17 — explicit container with directory mount (trusted profile)` - **Branch**: `test/int-wf17-explicit-container` ## Background Integration test for Specification Workflow Example 17: Explicit Container with Directory Mount. Exercises explicit container-instance creation with dual mounts (resource-ref rw + host-path ro), project execution environment override, and container tool routing using mocked LLM providers and mocked container operations. Runs within the standard `nox -s integration_tests` session using mocked LLM providers. ## Expected Behavior The integration test validates explicit container lifecycle with mocked LLM and mocked container runtime. Dual mount registration, execution environment override priority, and container tool routing are verified. ## Acceptance Criteria - [ ] Robot Framework test suite in `robot/` directory (standard integration tests) - [ ] Test uses integration-appropriate mocking (mocked LLM, mocked container runtime) - [ ] Test registers container-instance with dual mounts - [ ] Test sets project execution environment with override priority - [ ] Test verifies tools route to container - [ ] Test passes via `nox -s integration_tests` - [ ] Coverage >=97% maintained ## Subtasks - [ ] Write Robot Framework integration test suite for workflow example 17 - [ ] Configure mocked LLM and container runtime responses - [ ] Implement explicit container workflow with dual mounts - [ ] Verify via `nox -s integration_tests` - [ ] Verify coverage >=97% via `nox -s coverage_report` - [ ] Run `nox` (all default sessions), fix any errors ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.
freemo added this to the v3.7.0 milestone 2026-03-12 19:40:50 +00:00
freemo self-assigned this 2026-04-02 06:14:03 +00:00
Author
Owner

PR #954 Review Outcome — REQUEST_CHANGES

PR #954 has been reviewed. The code and tests are well-implemented and meet all acceptance criteria for WF17 (explicit container with directory mount).

Blocking issue: The branch has merge conflicts with master (specifically in CHANGELOG.md) and contains a merge commit that violates the project's "no merge commits" rule. The branch needs to be rebased onto current master with a clean linear history before it can be merged.

Code quality: All 5 Robot Framework test cases are properly structured, the Python helper is well-typed (493 lines, no # type: ignore), and all acceptance criteria are covered. Once the rebase is done, this should be ready to merge.

See PR #954 review for full details.

## PR #954 Review Outcome — REQUEST_CHANGES PR #954 has been reviewed. The code and tests are well-implemented and meet all acceptance criteria for WF17 (explicit container with directory mount). **Blocking issue:** The branch has merge conflicts with `master` (specifically in `CHANGELOG.md`) and contains a merge commit that violates the project's "no merge commits" rule. The branch needs to be rebased onto current `master` with a clean linear history before it can be merged. **Code quality:** All 5 Robot Framework test cases are properly structured, the Python helper is well-typed (493 lines, no `# type: ignore`), and all acceptance criteria are covered. Once the rebase is done, this should be ready to merge. See [PR #954 review](https://git.cleverthis.com/cleveragents/cleveragents-core/pulls/954#issuecomment-76740) for full details.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
cleveragents/cleveragents-core#781
No description provided.