cleveragents/cleveragents-core

Fork 3

UAT: [FA-10] CheckpointManager.create_checkpoint() uses naive datetime.now() — inconsistent with domain Checkpoint model using UTC-aware timestamps #7799

New issue

Open

opened 2026-04-12 03:57:42 +00:00 by HAL9000 · 4 comments

HAL9000 commented

2026-04-12 03:57:42 +00:00

Owner

Bug Report: Data Integrity — `CheckpointManager.create_checkpoint()` Uses Naive Datetime

Severity Assessment

Impact: Checkpoint timestamps in SandboxCheckpoint records use naive (timezone-unaware) datetimes, while the domain Checkpoint model uses UTC-aware datetimes. This inconsistency can cause incorrect timestamp comparisons, sorting errors, and serialization issues when checkpoints from both systems are compared or stored together.
Likelihood: Medium — triggered whenever checkpoints are compared across the two systems
Priority: Medium

Location

File: src/cleveragents/infrastructure/sandbox/checkpoint.py
Function/Class: CheckpointManager.create_checkpoint
Line: 158

Description

CheckpointManager.create_checkpoint() creates a SandboxCheckpoint with:

created_at=datetime.now(),  # naive datetime — no timezone

However, the domain model Checkpoint in src/cleveragents/domain/models/core/checkpoint.py uses:

created_at: datetime = Field(
    default_factory=lambda: datetime.now(UTC),  # UTC-aware datetime
    ...
)

This inconsistency means:

SandboxCheckpoint.created_at is a naive datetime (no timezone info)
Checkpoint.created_at is a UTC-aware datetime
Comparing or sorting checkpoints from both systems can produce incorrect results
If naive datetimes are stored in a database that expects UTC-aware timestamps, they may be misinterpreted

Evidence

# infrastructure/sandbox/checkpoint.py line 158
checkpoint = SandboxCheckpoint(
    checkpoint_id=checkpoint_id,
    sandbox_id=sandbox_id,
    plan_id=plan_id,
    phase=phase,
    created_at=datetime.now(),  # ← naive datetime, no UTC
    metadata=meta,
    snapshot_path=snapshot_path,
)

# domain/models/core/checkpoint.py line 102-105
created_at: datetime = Field(
    default_factory=lambda: datetime.now(UTC),  # ← UTC-aware datetime
    description="When the checkpoint was created",
)

Expected Behavior

CheckpointManager.create_checkpoint() should use datetime.now(UTC) (or datetime.now(timezone.utc)) to create UTC-aware timestamps, consistent with the domain model.

Actual Behavior

CheckpointManager.create_checkpoint() uses datetime.now() which creates a naive datetime without timezone information.

Suggested Fix

from datetime import UTC  # or: from datetime import timezone; UTC = timezone.utc

# In create_checkpoint():
created_at=datetime.now(UTC),  # UTC-aware timestamp

Category

data-integrity / consistency

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Bug Report: Data Integrity — `CheckpointManager.create_checkpoint()` Uses Naive Datetime ### Severity Assessment - **Impact**: Checkpoint timestamps in `SandboxCheckpoint` records use naive (timezone-unaware) datetimes, while the domain `Checkpoint` model uses UTC-aware datetimes. This inconsistency can cause incorrect timestamp comparisons, sorting errors, and serialization issues when checkpoints from both systems are compared or stored together. - **Likelihood**: Medium — triggered whenever checkpoints are compared across the two systems - **Priority**: Medium ### Location - **File**: `src/cleveragents/infrastructure/sandbox/checkpoint.py` - **Function/Class**: `CheckpointManager.create_checkpoint` - **Line**: 158 ### Description `CheckpointManager.create_checkpoint()` creates a `SandboxCheckpoint` with: ```python created_at=datetime.now(), # naive datetime — no timezone ``` However, the domain model `Checkpoint` in `src/cleveragents/domain/models/core/checkpoint.py` uses: ```python created_at: datetime = Field( default_factory=lambda: datetime.now(UTC), # UTC-aware datetime ... ) ``` This inconsistency means: 1. `SandboxCheckpoint.created_at` is a naive datetime (no timezone info) 2. `Checkpoint.created_at` is a UTC-aware datetime 3. Comparing or sorting checkpoints from both systems can produce incorrect results 4. If naive datetimes are stored in a database that expects UTC-aware timestamps, they may be misinterpreted ### Evidence ```python # infrastructure/sandbox/checkpoint.py line 158 checkpoint = SandboxCheckpoint( checkpoint_id=checkpoint_id, sandbox_id=sandbox_id, plan_id=plan_id, phase=phase, created_at=datetime.now(), # ← naive datetime, no UTC metadata=meta, snapshot_path=snapshot_path, ) # domain/models/core/checkpoint.py line 102-105 created_at: datetime = Field( default_factory=lambda: datetime.now(UTC), # ← UTC-aware datetime description="When the checkpoint was created", ) ``` ### Expected Behavior `CheckpointManager.create_checkpoint()` should use `datetime.now(UTC)` (or `datetime.now(timezone.utc)`) to create UTC-aware timestamps, consistent with the domain model. ### Actual Behavior `CheckpointManager.create_checkpoint()` uses `datetime.now()` which creates a naive datetime without timezone information. ### Suggested Fix ```python from datetime import UTC # or: from datetime import timezone; UTC = timezone.utc # In create_checkpoint(): created_at=datetime.now(UTC), # UTC-aware timestamp ``` ### Category data-integrity / consistency --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 added the

labels

2026-04-12 03:57:42 +00:00

HAL9000 added this to the v3.2.0 milestone

2026-04-12 04:05:18 +00:00

HAL9000 commented

2026-04-12 04:07:42 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified
Priority: Medium — datetime inconsistency between SandboxCheckpoint and domain Checkpoint model; causes timestamp comparison issues
Milestone: v3.2.0 — checkpoint functionality is M3 scope
Story Points: 1 — XS — one-line fix: replace datetime.now() with datetime.now(UTC) or datetime.utcnow().replace(tzinfo=timezone.utc)
MoSCoW: Should Have — datetime consistency is important for correctness but less critical than the restore bug (#7798)

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Medium — datetime inconsistency between SandboxCheckpoint and domain Checkpoint model; causes timestamp comparison issues - **Milestone**: v3.2.0 — checkpoint functionality is M3 scope - **Story Points**: 1 — XS — one-line fix: replace `datetime.now()` with `datetime.now(UTC)` or `datetime.utcnow().replace(tzinfo=timezone.utc)` - **MoSCoW**: Should Have — datetime consistency is important for correctness but less critical than the restore bug (#7798) --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner

HAL9000 referenced this issue

2026-04-12 04:10:37 +00:00

[AUTO-PROJ-OWN] Project Owner Report (Cycle 1) #7724

HAL9000 referenced this issue

2026-04-12 04:39:44 +00:00

[AUTO-UAT-SUP] UAT Test Pool Status (Cycle 8) #7821

freemo added the

Type

Bug

label

2026-04-12 18:33:32 +00:00

HAL9000 added

and removed

labels

2026-04-14 05:58:04 +00:00

HAL9000 commented

2026-04-14 05:58:04 +00:00

Author

Owner

✅ Verified — UAT bug: CheckpointManager uses naive datetime instead of UTC-aware. Data integrity issue. MoSCoW: Must-have. Priority: High.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

✅ **Verified** — UAT bug: CheckpointManager uses naive datetime instead of UTC-aware. Data integrity issue. MoSCoW: Must-have. Priority: High. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor

HAL9000 commented

2026-04-14 06:11:22 +00:00

Author

Owner

✅ Verified — UAT bug: CheckpointManager uses naive datetime instead of UTC-aware. Data integrity issue. MoSCoW: Must-have. Priority: High.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor