cleveragents/cleveragents-core

Fork 3

BUG-HUNT: [missing-validation] ProjectRepositoryProtocol.get raises undocumented exception type not defined in domain layer #7767

New issue

Open

opened 2026-04-12 03:28:30 +00:00 by HAL9000 · 3 comments

HAL9000 commented

2026-04-12 03:28:30 +00:00

Owner

Bug Report: Missing Validation — ProjectRepositoryProtocol.get documents ProjectNotFoundError but it is not defined in domain layer

Severity Assessment

Impact: The ProjectRepositoryProtocol.get method documents Raises: ProjectNotFoundError in its docstring, but ProjectNotFoundError is NOT defined anywhere in the domain layer. Implementors of the protocol will need to define this error class themselves without a domain-layer contract, leading to inconsistent error handling across implementations.
Likelihood: High — any consumer of the protocol that catches ProjectNotFoundError will fail at import time if there is no canonical location to import it from.
Priority: High

Location

File: src/cleveragents/domain/repositories/project_repository.py
Class: ProjectRepositoryProtocol
Method: get
Lines: ~40-55

Description

The ProjectRepositoryProtocol.get method documents that it raises ProjectNotFoundError:

def get(self, namespaced_name: str) -> NamespacedProject:
    """
    Raises:
        ProjectNotFoundError: If the project does not exist.
    """

However, searching the entire domain layer, ProjectNotFoundError is not defined in:

project_repository.py (the file containing the protocol)
project.py (the project domain model)
Any __init__.py in the domain layer
Any other domain model file

By contrast, the session.py module correctly defines SessionNotFoundError, SessionExportError, and SessionImportError alongside the SessionService abstract class. The project repository protocol is missing the corresponding ProjectNotFoundError domain exception.

This creates an incomplete repository interface contract: the method promises to raise a specific exception type, but that type does not exist in the domain layer for callers to import and catch.

Evidence

# From project_repository.py
@runtime_checkable
class ProjectRepositoryProtocol(Protocol):
    def get(self, namespaced_name: str) -> NamespacedProject:
        """
        Returns:
            The NamespacedProject domain object.
        Raises:
            ProjectNotFoundError: If the project does not exist.  # UNDEFINED!
        """
        ...

Verification:

# ProjectNotFoundError not found in domain layer:
grep -r "ProjectNotFoundError" src/cleveragents/domain/
# Returns no results

Expected Behavior

ProjectNotFoundError should be defined in the domain layer (either in project.py or project_repository.py) alongside the protocol, mirroring the pattern used in session.py:

class ProjectNotFoundError(Exception):
    """Raised when a project with the given name is not found."""

Actual Behavior

The exception is documented but not defined, leaving the repository interface contract incomplete and breaking importability for any code that tries to catch ProjectNotFoundError.

TDD Note

After this bug issue is verified, a corresponding Type/Testing issue will be created for TDD.

Automated by CleverAgents Bot
Supervisor: Bug Hunting | Agent: bug-hunter

## Bug Report: Missing Validation — ProjectRepositoryProtocol.get documents ProjectNotFoundError but it is not defined in domain layer ### Severity Assessment - **Impact**: The `ProjectRepositoryProtocol.get` method documents `Raises: ProjectNotFoundError` in its docstring, but `ProjectNotFoundError` is NOT defined anywhere in the domain layer. Implementors of the protocol will need to define this error class themselves without a domain-layer contract, leading to inconsistent error handling across implementations. - **Likelihood**: High — any consumer of the protocol that catches `ProjectNotFoundError` will fail at import time if there is no canonical location to import it from. - **Priority**: High ### Location - **File**: `src/cleveragents/domain/repositories/project_repository.py` - **Class**: `ProjectRepositoryProtocol` - **Method**: `get` - **Lines**: ~40-55 ### Description The `ProjectRepositoryProtocol.get` method documents that it raises `ProjectNotFoundError`: ```python def get(self, namespaced_name: str) -> NamespacedProject: """ Raises: ProjectNotFoundError: If the project does not exist. """ ``` However, searching the entire domain layer, `ProjectNotFoundError` is not defined in: - `project_repository.py` (the file containing the protocol) - `project.py` (the project domain model) - Any `__init__.py` in the domain layer - Any other domain model file By contrast, the `session.py` module correctly defines `SessionNotFoundError`, `SessionExportError`, and `SessionImportError` alongside the `SessionService` abstract class. The project repository protocol is missing the corresponding `ProjectNotFoundError` domain exception. This creates an incomplete repository interface contract: the method promises to raise a specific exception type, but that type does not exist in the domain layer for callers to import and catch. ### Evidence ```python # From project_repository.py @runtime_checkable class ProjectRepositoryProtocol(Protocol): def get(self, namespaced_name: str) -> NamespacedProject: """ Returns: The NamespacedProject domain object. Raises: ProjectNotFoundError: If the project does not exist. # UNDEFINED! """ ... ``` Verification: ```bash # ProjectNotFoundError not found in domain layer: grep -r "ProjectNotFoundError" src/cleveragents/domain/ # Returns no results ``` ### Expected Behavior `ProjectNotFoundError` should be defined in the domain layer (either in `project.py` or `project_repository.py`) alongside the protocol, mirroring the pattern used in `session.py`: ```python class ProjectNotFoundError(Exception): """Raised when a project with the given name is not found.""" ``` ### Actual Behavior The exception is documented but not defined, leaving the repository interface contract incomplete and breaking importability for any code that tries to catch `ProjectNotFoundError`. ### Category missing-validation ### TDD Note After this bug issue is verified, a corresponding Type/Testing issue will be created for TDD. --- **Automated by CleverAgents Bot** Supervisor: Bug Hunting | Agent: bug-hunter

HAL9000 added this to the v3.2.0 milestone

2026-04-12 03:45:57 +00:00

HAL9000 referenced this issue

2026-04-12 03:47:56 +00:00

[AUTO-PROJ-OWN] Project Owner Report (Cycle 1) #7724

HAL9000 added the

labels

2026-04-12 05:47:56 +00:00

freemo added the

Type

Bug

label

2026-04-12 18:33:38 +00:00

HAL9000 added

and removed

labels

2026-04-14 05:58:20 +00:00

HAL9000 commented

2026-04-14 05:58:21 +00:00

Author

Owner

✅ Verified — Bug: undocumented exception type in ProjectRepositoryProtocol.get. MoSCoW: Should-have. Priority: Medium.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

✅ **Verified** — Bug: undocumented exception type in ProjectRepositoryProtocol.get. MoSCoW: Should-have. Priority: Medium. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor

HAL9000 commented

2026-04-14 06:11:38 +00:00

Author

Owner

✅ Verified — Bug: undocumented exception type in ProjectRepositoryProtocol.get. MoSCoW: Should-have. Priority: Medium.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor