cleveragents/cleveragents-core

Fork 3

BUG-HUNT: [code-consistency] CleverAgentsException and UnsafeConfigurationError missing from exceptions.all #7756

New issue

Open

opened 2026-04-12 03:24:59 +00:00 by HAL9000 · 3 comments

HAL9000 commented

2026-04-12 03:24:59 +00:00

Owner

Bug Report: Code Consistency — Backward-Compat Classes Missing from all

Severity Assessment

Impact: CleverAgentsException (explicitly documented as a backward-compatibility alias) and UnsafeConfigurationError are defined in exceptions.py but not listed in __all__. Code using from cleveragents.core.exceptions import * silently omits these names, breaking the backward-compatibility guarantee.
Likelihood: Low-Medium — affects users of star imports who rely on the backward compat alias.
Priority: Low

Location

File: src/cleveragents/core/exceptions.py
Function/Class: module __all__
Lines: 21–22 (class definitions), 328–356 (__all__ declaration)

Description

Two classes are defined in exceptions.py but absent from its __all__ export list:

CleverAgentsException (line 21) — explicitly documented as "Backward compatibility exception name for v2 code". Omitting it from __all__ means from cleveragents.core.exceptions import * does not export it, defeating the backward-compatibility purpose.
UnsafeConfigurationError (line 25) — a public error class for unsafe configuration scenarios; it is usable via named import but unreachable via star import.

Every other exception class defined in the file IS present in __all__ (28 entries), making these omissions inconsistent.

Evidence

# src/cleveragents/core/exceptions.py lines 21-26
class CleverAgentsException(CleverAgentsError):
    """Backward compatibility exception name for v2 code."""  # documented compat

class UnsafeConfigurationError(CleverAgentsError):
    """Unsafe configuration requires explicit opt-in."""

# lines 328-356 — __all__ list (28 entries)
__all__ = [
    "AuthenticationError",
    "AuthorizationError",
    # ... 26 more entries ...
    # CleverAgentsException  <-- MISSING
    # UnsafeConfigurationError  <-- MISSING
]

Expected Behavior

All public and backward-compat exception classes defined in the module should be present in __all__. from cleveragents.core.exceptions import * should yield CleverAgentsException and UnsafeConfigurationError.

Actual Behavior

from cleveragents.core.exceptions import * omits both CleverAgentsException and UnsafeConfigurationError. Code migrating from v2 that does from cleveragents.core.exceptions import * and then uses CleverAgentsException will receive a NameError.

Suggested Fix

Add the missing entries to __all__:

__all__ = [
    "AuthenticationError",
    "AuthorizationError",
    "BusinessRuleViolation",
    "CleverAgentsError",
    "CleverAgentsException",        # add
    "ConfigurationError",
    # ...
    "UnsafeConfigurationError",     # add
    "ValidationError",
]

TDD Note

After this bug issue is verified, a corresponding Type/Testing issue will be created for TDD.

Automated by CleverAgents Bot
Supervisor: Bug Hunting | Agent: bug-hunter

## Bug Report: Code Consistency — Backward-Compat Classes Missing from __all__ ### Severity Assessment - **Impact**: `CleverAgentsException` (explicitly documented as a backward-compatibility alias) and `UnsafeConfigurationError` are defined in `exceptions.py` but not listed in `__all__`. Code using `from cleveragents.core.exceptions import *` silently omits these names, breaking the backward-compatibility guarantee. - **Likelihood**: Low-Medium — affects users of star imports who rely on the backward compat alias. - **Priority**: Low ### Location - **File**: `src/cleveragents/core/exceptions.py` - **Function/Class**: module `__all__` - **Lines**: 21–22 (class definitions), 328–356 (`__all__` declaration) ### Description Two classes are defined in `exceptions.py` but absent from its `__all__` export list: 1. `CleverAgentsException` (line 21) — explicitly documented as "Backward compatibility exception name for v2 code". Omitting it from `__all__` means `from cleveragents.core.exceptions import *` does not export it, defeating the backward-compatibility purpose. 2. `UnsafeConfigurationError` (line 25) — a public error class for unsafe configuration scenarios; it is usable via named import but unreachable via star import. Every other exception class defined in the file IS present in `__all__` (28 entries), making these omissions inconsistent. ### Evidence ```python # src/cleveragents/core/exceptions.py lines 21-26 class CleverAgentsException(CleverAgentsError): """Backward compatibility exception name for v2 code.""" # documented compat class UnsafeConfigurationError(CleverAgentsError): """Unsafe configuration requires explicit opt-in.""" # lines 328-356 — __all__ list (28 entries) __all__ = [ "AuthenticationError", "AuthorizationError", # ... 26 more entries ... # CleverAgentsException <-- MISSING # UnsafeConfigurationError <-- MISSING ] ``` ### Expected Behavior All public and backward-compat exception classes defined in the module should be present in `__all__`. `from cleveragents.core.exceptions import *` should yield `CleverAgentsException` and `UnsafeConfigurationError`. ### Actual Behavior `from cleveragents.core.exceptions import *` omits both `CleverAgentsException` and `UnsafeConfigurationError`. Code migrating from v2 that does `from cleveragents.core.exceptions import *` and then uses `CleverAgentsException` will receive a `NameError`. ### Suggested Fix Add the missing entries to `__all__`: ```python __all__ = [ "AuthenticationError", "AuthorizationError", "BusinessRuleViolation", "CleverAgentsError", "CleverAgentsException", # add "ConfigurationError", # ... "UnsafeConfigurationError", # add "ValidationError", ] ``` ### Category code-consistency ### TDD Note After this bug issue is verified, a corresponding Type/Testing issue will be created for TDD. --- **Automated by CleverAgents Bot** Supervisor: Bug Hunting | Agent: bug-hunter

HAL9000 added this to the v3.2.0 milestone

2026-04-12 03:45:08 +00:00

HAL9000 referenced this issue

2026-04-12 03:47:56 +00:00

[AUTO-PROJ-OWN] Project Owner Report (Cycle 1) #7724

HAL9000 added the

labels

2026-04-12 07:15:43 +00:00

freemo added the

Type

Bug

label

2026-04-12 18:33:43 +00:00

HAL9000 added

and removed

labels

2026-04-14 05:58:27 +00:00

HAL9000 commented

2026-04-14 05:58:28 +00:00

Author

Owner

✅ Verified — Code consistency: missing from all. MoSCoW: Could-have. Priority: Low — minor consistency issue.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

✅ **Verified** — Code consistency: missing from __all__. MoSCoW: Could-have. Priority: Low — minor consistency issue. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor

HAL9000 commented

2026-04-14 06:11:45 +00:00

Author

Owner

✅ Verified — Code consistency: missing from all. MoSCoW: Could-have. Priority: Low — minor consistency issue.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor