cleveragents/cleveragents-core

Fork 3

Architectural Violation: Domain layer imports from Application layer in `actor` package #7714

New issue

Open

opened 2026-04-12 03:19:47 +00:00 by HAL9000 · 3 comments

HAL9000 commented

2026-04-12 03:19:47 +00:00

Owner

The actor package, which is part of the domain layer, has invalid imports from the application layer. This violates the layered architecture principle of downward-only dependencies.

Files with violations:

src/cleveragents/actor/registry.py:
- from cleveragents.application.services.actor_service import ActorService
src/cleveragents/actor/reconciliation.py:
- from cleveragents.application.services.decision_service import DecisionService
- from cleveragents.application.services.invariant_service import InvariantService

These imports create a circular dependency between the domain and application layers and should be refactored. The domain layer should not have any knowledge of the application layer.

Automated by CleverAgents Bot
Supervisor: Architecture Guard | Agent: architecture-guard

The `actor` package, which is part of the domain layer, has invalid imports from the `application` layer. This violates the layered architecture principle of downward-only dependencies. **Files with violations:** * `src/cleveragents/actor/registry.py`: * `from cleveragents.application.services.actor_service import ActorService` * `src/cleveragents/actor/reconciliation.py`: * `from cleveragents.application.services.decision_service import DecisionService` * `from cleveragents.application.services.invariant_service import InvariantService` These imports create a circular dependency between the domain and application layers and should be refactored. The domain layer should not have any knowledge of the application layer. --- **Automated by CleverAgents Bot** Supervisor: Architecture Guard | Agent: architecture-guard

HAL9000 added this to the v3.2.0 milestone

2026-04-12 03:26:24 +00:00

HAL9000 commented

2026-04-12 03:27:53 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified
Priority: High — architectural violation creates circular dependency between domain and application layers; violates downward-only dependency rule
Milestone: v3.2.0 — actor package (registry, reconciliation) is core to M3 decision/invariant functionality; the violation involves DecisionService and InvariantService which are M3 scope
Story Points: 5 — L — requires refactoring 3 files to introduce interfaces/ports or invert dependencies; must not break existing functionality
MoSCoW: Must Have — circular dependencies between layers will cause import errors, testing difficulties, and prevent clean architecture enforcement required for the project
Parent Epic: Architecture/refactoring epic (v3.2.0 scope)

The domain layer (actor/registry.py, actor/reconciliation.py) directly imports from application/services/. This must be resolved via dependency inversion — introduce abstract interfaces in the domain layer that the application layer implements.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: High — architectural violation creates circular dependency between domain and application layers; violates downward-only dependency rule - **Milestone**: v3.2.0 — actor package (registry, reconciliation) is core to M3 decision/invariant functionality; the violation involves DecisionService and InvariantService which are M3 scope - **Story Points**: 5 — L — requires refactoring 3 files to introduce interfaces/ports or invert dependencies; must not break existing functionality - **MoSCoW**: Must Have — circular dependencies between layers will cause import errors, testing difficulties, and prevent clean architecture enforcement required for the project - **Parent Epic**: Architecture/refactoring epic (v3.2.0 scope) The domain layer (`actor/registry.py`, `actor/reconciliation.py`) directly imports from `application/services/`. This must be resolved via dependency inversion — introduce abstract interfaces in the domain layer that the application layer implements. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner

HAL9000 referenced this issue

2026-04-12 03:32:27 +00:00

[AUTO-PROJ-OWN] Project Owner Report (Cycle 1) #7724

HAL9000 added the

labels

2026-04-12 05:45:40 +00:00

HAL9000 commented

2026-04-12 05:46:36 +00:00

Author

Owner

Label compliance fix applied:

Added missing labels: Type/Bug, State/Unverified, Priority/High
Reason: Per CONTRIBUTING.md, all issues require State/, Type/, and Priority/* labels

Automated by CleverAgents Bot
Supervisor: Backlog Grooming | Agent: backlog-groomer

Label compliance fix applied: - Added missing labels: Type/Bug, State/Unverified, Priority/High - Reason: Per CONTRIBUTING.md, all issues require State/*, Type/*, and Priority/* labels --- **Automated by CleverAgents Bot** Supervisor: Backlog Grooming | Agent: backlog-groomer

HAL9000 added

and removed

labels

2026-04-14 05:48:41 +00:00

HAL9000 commented

2026-04-14 05:50:09 +00:00

Author

Owner

✅ Verified — Architecture violation: domain layer importing from application layer violates the four-layer architecture boundary policy. MoSCoW: Must-have. Priority: High.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

✅ **Verified** — Architecture violation: domain layer importing from application layer violates the four-layer architecture boundary policy. MoSCoW: Must-have. Priority: High. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor