cleveragents/cleveragents-core

Fork 3

BUG-HUNT: [boundary] CostBudgetService._check_warning() only fires once per session lifetime — warning never re-emits after cost drops below threshold #7525

New issue

Open

opened 2026-04-10 21:36:20 +00:00 by HAL9000 · 3 comments

HAL9000 commented

2026-04-10 21:36:20 +00:00

Owner

Bug Report: [boundary] — Budget Warning Only Fires Once, Cannot Re-trigger

Severity Assessment

Impact: Once a session reaches the warning threshold, it is added to _warned_sessions permanently. If the session budget is later reconfigured (e.g. increased), or the session is reused, the warning will never fire again for that session even when the new threshold is crossed.
Likelihood: Medium — affects long-running sessions where budget is reconfigured via configure_session_budget().
Priority: Low

Location

File: src/cleveragents/application/services/cost_budget_service.py
Function/Class: CostBudgetService._check_warning, CostBudgetService.configure_session_budget
Lines: 100–126, 306–320

Description

_check_warning() adds the session to _warned_sessions after the first warning and immediately returns False on all subsequent calls:

def _check_warning(self, session_id: str) -> bool:
    if session_id in self._warned_sessions:
        return False   # Never warns again once added
    ...
    if util >= self._warning_threshold:
        self._warned_sessions.add(session_id)
        self._emit_warning(session_id)
        return True
    return False

However, configure_session_budget() does NOT remove the session from _warned_sessions when the budget is reconfigured:

def configure_session_budget(self, session_id, *, max_cost_usd=None, ...):
    with self._lock:
        existing = self._sessions.get(session_id)
        total = existing.total_cost if existing else 0.0
        self._sessions[session_id] = SessionCostBudget(max_cost_usd=max_cost_usd, total_cost=total)
        # Does NOT clear _warned_sessions[session_id]

This means:

Session A reaches 80% of budget → warning fires, added to _warned_sessions.
Budget is increased via configure_session_budget() → _warned_sessions still contains session A.
Session A later reaches 80% of the new higher budget → warning never fires.

Evidence

# cost_budget_service.py line 126 — remove_session clears it:
def remove_session(self, session_id: str) -> None:
    with self._lock:
        self._sessions.pop(session_id, None)
        self._session_org.pop(session_id, None)
        self._warned_sessions.discard(session_id)  # Only cleared on remove

But configure_session_budget() does not call _warned_sessions.discard(session_id), so re-configuration does not reset the warning state.

Expected Behavior

When configure_session_budget() changes the max_cost_usd, the warning state for that session should be reset so the warning can fire again when the new threshold is crossed.

Actual Behavior

Once a warning fires, it never fires again for that session even after budget reconfiguration.

Suggested Fix

Add self._warned_sessions.discard(session_id) inside configure_session_budget() whenever max_cost_usd is changed.

TDD Note

After this bug issue is verified, a corresponding Type/Testing issue will be created for TDD with @tdd_expected_fail tags.

Automated by CleverAgents Bot
Supervisor: Bug Hunt Pool | Agent: bug-hunt-pool-supervisor

## Bug Report: [boundary] — Budget Warning Only Fires Once, Cannot Re-trigger ### Severity Assessment - **Impact**: Once a session reaches the warning threshold, it is added to `_warned_sessions` permanently. If the session budget is later reconfigured (e.g. increased), or the session is reused, the warning will never fire again for that session even when the new threshold is crossed. - **Likelihood**: Medium — affects long-running sessions where budget is reconfigured via `configure_session_budget()`. - **Priority**: Low ### Location - **File**: `src/cleveragents/application/services/cost_budget_service.py` - **Function/Class**: `CostBudgetService._check_warning`, `CostBudgetService.configure_session_budget` - **Lines**: 100–126, 306–320 ### Description `_check_warning()` adds the session to `_warned_sessions` after the first warning and immediately returns `False` on all subsequent calls: ```python def _check_warning(self, session_id: str) -> bool: if session_id in self._warned_sessions: return False # Never warns again once added ... if util >= self._warning_threshold: self._warned_sessions.add(session_id) self._emit_warning(session_id) return True return False ``` However, `configure_session_budget()` does NOT remove the session from `_warned_sessions` when the budget is reconfigured: ```python def configure_session_budget(self, session_id, *, max_cost_usd=None, ...): with self._lock: existing = self._sessions.get(session_id) total = existing.total_cost if existing else 0.0 self._sessions[session_id] = SessionCostBudget(max_cost_usd=max_cost_usd, total_cost=total) # Does NOT clear _warned_sessions[session_id] ``` This means: 1. Session A reaches 80% of budget → warning fires, added to `_warned_sessions`. 2. Budget is increased via `configure_session_budget()` → `_warned_sessions` still contains session A. 3. Session A later reaches 80% of the new higher budget → **warning never fires**. ### Evidence ```python # cost_budget_service.py line 126 — remove_session clears it: def remove_session(self, session_id: str) -> None: with self._lock: self._sessions.pop(session_id, None) self._session_org.pop(session_id, None) self._warned_sessions.discard(session_id) # Only cleared on remove ``` But `configure_session_budget()` does not call `_warned_sessions.discard(session_id)`, so re-configuration does not reset the warning state. ### Expected Behavior When `configure_session_budget()` changes the `max_cost_usd`, the warning state for that session should be reset so the warning can fire again when the new threshold is crossed. ### Actual Behavior Once a warning fires, it never fires again for that session even after budget reconfiguration. ### Suggested Fix Add `self._warned_sessions.discard(session_id)` inside `configure_session_budget()` whenever `max_cost_usd` is changed. ### Category boundary ### TDD Note After this bug issue is verified, a corresponding Type/Testing issue will be created for TDD with `@tdd_expected_fail` tags. --- **Automated by CleverAgents Bot** Supervisor: Bug Hunt Pool | Agent: bug-hunt-pool-supervisor

HAL9000 added the

Type

Bug

label

2026-04-10 21:36:20 +00:00

HAL9000 referenced this issue

2026-04-10 21:37:11 +00:00

[AUTO-BUG-SUP] Bug Hunt Pool Status (Cycle 1) #7531

HAL9000 added the

labels

2026-04-10 23:02:04 +00:00

HAL9000 added this to the v3.5.0 milestone

2026-04-10 23:05:50 +00:00

HAL9000 commented

2026-04-10 23:11:18 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified
Priority: Backlog — Minor bug or optimization that does not block milestone delivery
Milestone: Assigned to appropriate milestone for future work
Story Points: 2 (S) — Small fix
MoSCoW: Could Have — Nice to fix but not blocking

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

Issue triaged by project owner: - **State**: Verified - **Priority**: Backlog — Minor bug or optimization that does not block milestone delivery - **Milestone**: Assigned to appropriate milestone for future work - **Story Points**: 2 (S) — Small fix - **MoSCoW**: Could Have — Nice to fix but not blocking --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor

HAL9000 referenced this issue

2026-04-10 23:30:28 +00:00

[AUTO-OWNR] Project Owner Status (Cycle 4) #7585

freemo added the

Priority

Backlog

label

2026-04-12 18:34:04 +00:00

HAL9000 commented

2026-04-13 07:03:30 +00:00

Author

Owner

Implementation Attempt Starting — Tier 1: haiku — [AUTO-IMP-ISSUE-7525]

Beginning implementation of the bug fix for CostBudgetService._check_warning() / configure_session_budget().

Plan:

Locate src/cleveragents/application/services/cost_budget_service.py
Add self._warned_sessions.discard(session_id) inside configure_session_budget() when max_cost_usd is changed
Write BDD/Gherkin tests (behave) covering the re-trigger scenario
Run all quality gates (lint, typecheck, unit_tests, integration_tests, coverage)
Create PR closing this issue

Escalation Tier: Tier 1: haiku

Automated by CleverAgents Bot
Supervisor: Implementation Pool | Agent: implementation-pool-supervisor

**Implementation Attempt Starting** — Tier 1: haiku — [AUTO-IMP-ISSUE-7525] Beginning implementation of the bug fix for `CostBudgetService._check_warning()` / `configure_session_budget()`. **Plan:** 1. Locate `src/cleveragents/application/services/cost_budget_service.py` 2. Add `self._warned_sessions.discard(session_id)` inside `configure_session_budget()` when `max_cost_usd` is changed 3. Write BDD/Gherkin tests (behave) covering the re-trigger scenario 4. Run all quality gates (lint, typecheck, unit_tests, integration_tests, coverage) 5. Create PR closing this issue **Escalation Tier**: Tier 1: haiku --- **Automated by CleverAgents Bot** Supervisor: Implementation Pool | Agent: implementation-pool-supervisor

HAL9000 referenced this issue from a commit

2026-04-13 07:51:30 +00:00

fix(boundary): reset warned_sessions on configure_session_budget

HAL9000 referenced this issue from a pull request that will close it,

2026-04-13 07:53:58 +00:00

fix(boundary): reset warned_sessions on configure_session_budget #8284

HAL9000 added

and removed

labels

2026-04-13 08:02:20 +00:00

HAL9000 commented

2026-04-13 08:06:04 +00:00

Author

Owner

Implementation Attempt — Tier 1: haiku — Success [AUTO-IMP-ISSUE-7525]

What was done

Fixed the bug in CostBudgetService.configure_session_budget() where the warning state was not reset when the budget was reconfigured.

Root cause: configure_session_budget() did not call _warned_sessions.discard(session_id) after updating the budget cap, so once a BUDGET_WARNING fired for a session it was permanently suppressed even after the budget was raised.

Fix: Added self._warned_sessions.discard(session_id) at the end of configure_session_budget() (after updating the session budget), so warning state is reset on every reconfiguration.

Files changed

src/cleveragents/application/services/cost_budget_service.py — 4 lines added
features/cost_budgets.feature — 4 new BDD scenarios
features/steps/cost_budgets_steps.py — 2 new step definitions
CHANGELOG.md — entry added under [Unreleased] > Fixed

Quality gates

✅ nox -e lint — passed
✅ nox -e typecheck — passed (0 errors)
✅ nox -e unit_tests — 85 scenarios passed, 0 failed (4 new scenarios)

PR

PR #8284: #8284

Automated by CleverAgents Bot
Supervisor: Implementation Pool | Agent: implementation-pool-supervisor

**Implementation Attempt** — Tier 1: haiku — Success [AUTO-IMP-ISSUE-7525] ## What was done Fixed the bug in `CostBudgetService.configure_session_budget()` where the warning state was not reset when the budget was reconfigured. **Root cause:** `configure_session_budget()` did not call `_warned_sessions.discard(session_id)` after updating the budget cap, so once a `BUDGET_WARNING` fired for a session it was permanently suppressed even after the budget was raised. **Fix:** Added `self._warned_sessions.discard(session_id)` at the end of `configure_session_budget()` (after updating the session budget), so warning state is reset on every reconfiguration. ## Files changed - `src/cleveragents/application/services/cost_budget_service.py` — 4 lines added - `features/cost_budgets.feature` — 4 new BDD scenarios - `features/steps/cost_budgets_steps.py` — 2 new step definitions - `CHANGELOG.md` — entry added under `[Unreleased] > Fixed` ## Quality gates - ✅ `nox -e lint` — passed - ✅ `nox -e typecheck` — passed (0 errors) - ✅ `nox -e unit_tests` — 85 scenarios passed, 0 failed (4 new scenarios) ## PR PR #8284: https://git.cleverthis.com/cleveragents/cleveragents-core/pulls/8284 --- **Automated by CleverAgents Bot** Supervisor: Implementation Pool | Agent: implementation-pool-supervisor

HAL9000 referenced this issue from a commit

2026-04-13 19:16:56 +00:00

docs(contributors): add HAL 9000 contribution details entry

HAL9000 referenced this issue from a pull request that will close it,

2026-04-14 04:25:06 +00:00

fix(boundary): reset warned_sessions on configure_session_budget #8284

HAL9000 added a new dependency

2026-04-14 12:56:22 +00:00

#8284 fix(boundary): reset warned_sessions on configure_session_budget

HAL9000 referenced this issue

2026-04-14 12:56:33 +00:00

fix(boundary): reset warned_sessions on configure_session_budget #8284