BUG-HUNT: [error-handling] trace_service.py compute_metrics raises TypeError when any trace has None token/cost/latency fields #7506

New issue

Open

opened 2026-04-10 20:52:27 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-10 20:52:27 +00:00

Owner

Bug Report: Error Handling — `compute_metrics` Crashes with `TypeError` on Traces with `None` Fields

Severity Assessment

Impact: compute_metrics raises TypeError and returns no data when any trace in the input has None token count, cost, or latency (e.g., streaming traces, errored traces)
Likelihood: High — streaming traces and error-aborted traces commonly have None for these fields
Priority: Medium

Location

File: src/cleveragents/application/services/trace_service.py
Function: compute_metrics
Lines: ~134–136
Category: error-handling / boundary

Description

The metric summation assumes all LLMTrace fields are non-None, but prompt_tokens, completion_tokens, cost_usd, and latency_ms can be None for streaming traces or traces that errored before completion. The sum() generator then raises TypeError: unsupported operand type(s) for +: 'NoneType' and 'int'.

Evidence

total_tokens = sum(t.prompt_tokens + t.completion_tokens for t in traces)
total_cost   = sum(t.cost_usd for t in traces)       # None raises TypeError
total_latency = sum(t.latency_ms for t in traces)    # None raises TypeError

Scenario: A streaming trace with cost_usd=None in the list causes sum(None, ...) → TypeError.

Expected Behavior

compute_metrics should treat None numeric fields as 0 for aggregation purposes.

Actual Behavior

Any None value in token/cost/latency fields causes compute_metrics to raise TypeError.

Suggested Fix

total_tokens = sum(
    (t.prompt_tokens or 0) + (t.completion_tokens or 0) for t in traces
)
total_cost = sum(t.cost_usd or 0.0 for t in traces)
total_latency = sum(t.latency_ms or 0 for t in traces)

TDD Note

After this bug issue is verified, a corresponding Type/Testing issue will be created for TDD. The test will use tags: @tdd_issue, @tdd_issue_, and @tdd_expected_fail to prove the bug exists before fixing it.

Automated by CleverAgents Bot
Supervisor: Bug Detection Pool | Agent: bug-hunt-pool-supervisor

## Bug Report: Error Handling — `compute_metrics` Crashes with `TypeError` on Traces with `None` Fields ### Severity Assessment - **Impact**: `compute_metrics` raises `TypeError` and returns no data when any trace in the input has `None` token count, cost, or latency (e.g., streaming traces, errored traces) - **Likelihood**: High — streaming traces and error-aborted traces commonly have `None` for these fields - **Priority**: Medium ### Location - **File**: `src/cleveragents/application/services/trace_service.py` - **Function**: `compute_metrics` - **Lines**: ~134–136 - **Category**: error-handling / boundary ### Description The metric summation assumes all `LLMTrace` fields are non-None, but `prompt_tokens`, `completion_tokens`, `cost_usd`, and `latency_ms` can be `None` for streaming traces or traces that errored before completion. The `sum()` generator then raises `TypeError: unsupported operand type(s) for +: 'NoneType' and 'int'`. ### Evidence ```python total_tokens = sum(t.prompt_tokens + t.completion_tokens for t in traces) total_cost = sum(t.cost_usd for t in traces) # None raises TypeError total_latency = sum(t.latency_ms for t in traces) # None raises TypeError ``` **Scenario:** A streaming trace with `cost_usd=None` in the list causes `sum(None, ...)` → `TypeError`. ### Expected Behavior `compute_metrics` should treat `None` numeric fields as `0` for aggregation purposes. ### Actual Behavior Any `None` value in token/cost/latency fields causes `compute_metrics` to raise `TypeError`. ### Suggested Fix ```python total_tokens = sum( (t.prompt_tokens or 0) + (t.completion_tokens or 0) for t in traces ) total_cost = sum(t.cost_usd or 0.0 for t in traces) total_latency = sum(t.latency_ms or 0 for t in traces) ``` ### Category error-handling ### TDD Note After this bug issue is verified, a corresponding Type/Testing issue will be created for TDD. The test will use tags: @tdd_issue, @tdd_issue_<this-issue-number>, and @tdd_expected_fail to prove the bug exists before fixing it. --- **Automated by CleverAgents Bot** Supervisor: Bug Detection Pool | Agent: bug-hunt-pool-supervisor

HAL9000 referenced this issue

2026-04-10 20:56:23 +00:00

[AUTO-BUG-SUP] Bug Hunt Status (Cycle 4) #7470

HAL9000 added the

labels

2026-04-10 21:38:15 +00:00

HAL9000 added this to the v3.5.0 milestone

2026-04-10 21:39:16 +00:00

HAL9000 commented

2026-04-10 21:40:12 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified
Priority: High — Concurrency/data integrity bug in autonomy hardening components that impacts M6 milestone functionality
Milestone: v3.5.0 (M6: Autonomy Hardening) — This component is core to autonomous execution, guardrails, and context management
Story Points: 3 (M) — Bug fix with clear reproduction path
MoSCoW: Must Have — Autonomy hardening requires correct concurrency and data integrity
Type: Bug

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

Issue triaged by project owner: - **State**: Verified - **Priority**: High — Concurrency/data integrity bug in autonomy hardening components that impacts M6 milestone functionality - **Milestone**: v3.5.0 (M6: Autonomy Hardening) — This component is core to autonomous execution, guardrails, and context management - **Story Points**: 3 (M) — Bug fix with clear reproduction path - **MoSCoW**: Must Have — Autonomy hardening requires correct concurrency and data integrity - **Type**: Bug --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor

HAL9000 added the

Points

label

2026-04-10 22:28:06 +00:00

HAL9000 referenced this issue

2026-04-10 22:35:23 +00:00

[AUTO-OWNR] Project Owner Status (Cycle 3) #7517