cleveragents/cleveragents-core

Fork 3

BUG-HUNT: [concurrency] Thread safety issue in TUI reference parser cache #7071

New issue

Open

opened 2026-04-10 07:29:13 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-10 07:29:13 +00:00

Owner

Bug Report: Concurrency — Thread Safety Issue in Reference Parser Cache

Severity Assessment

Impact: Data corruption, cache inconsistency, potential crashes in concurrent TUI sessions
Likelihood: High in multi-session or multi-threaded usage scenarios
Priority: High

Location

File: src/cleveragents/tui/input/reference_parser.py
Function/Class: _catalog() function and global _catalog_cache
Lines: 15, 33-46

Description

The TUI reference parser uses a global mutable dictionary _catalog_cache without any thread safety mechanisms. Multiple concurrent TUI sessions or threads can access and modify this cache simultaneously, leading to race conditions and data corruption.

Evidence

# Global mutable cache without thread protection
_catalog_cache: dict[str, object] = {"cwd": None, "created_at": 0.0, "catalog": None}

def _catalog() -> dict[str, list[str]]:
    cwd = Path.cwd()
    now = time.time()
    # Multiple threads can read/write these values concurrently
    cached_cwd = _catalog_cache.get("cwd")
    cached_time = _catalog_cache.get("created_at")
    cached_catalog = _catalog_cache.get("catalog")
    # ... later in the function:
    _catalog_cache["cwd"] = cwd
    _catalog_cache["created_at"] = now
    _catalog_cache["catalog"] = catalog

Expected Behavior

Cache operations should be thread-safe to prevent data corruption in concurrent usage scenarios.

Actual Behavior

Multiple threads can corrupt the cache state by interleaving reads and writes, leading to:

Partial cache updates
Inconsistent cache state
Wrong catalog data returned to different sessions
Potential crashes from type mismatches

Suggested Fix

Add thread synchronization using threading.Lock() around cache operations or use a thread-safe caching mechanism.

TDD Note

After this bug issue is verified, a corresponding Type/Testing issue will be created for TDD. The test will use tags: @tdd_issue, @tdd_issue_<this-issue-number>, and @tdd_expected_fail to prove the bug exists before fixing it.

Automated by CleverAgents Bot
Supervisor: Bug Hunting | Agent: bug-hunter

## Bug Report: Concurrency — Thread Safety Issue in Reference Parser Cache ### Severity Assessment - **Impact**: Data corruption, cache inconsistency, potential crashes in concurrent TUI sessions - **Likelihood**: High in multi-session or multi-threaded usage scenarios - **Priority**: High ### Location - **File**: `src/cleveragents/tui/input/reference_parser.py` - **Function/Class**: `_catalog()` function and global `_catalog_cache` - **Lines**: 15, 33-46 ### Description The TUI reference parser uses a global mutable dictionary `_catalog_cache` without any thread safety mechanisms. Multiple concurrent TUI sessions or threads can access and modify this cache simultaneously, leading to race conditions and data corruption. ### Evidence ```python # Global mutable cache without thread protection _catalog_cache: dict[str, object] = {"cwd": None, "created_at": 0.0, "catalog": None} def _catalog() -> dict[str, list[str]]: cwd = Path.cwd() now = time.time() # Multiple threads can read/write these values concurrently cached_cwd = _catalog_cache.get("cwd") cached_time = _catalog_cache.get("created_at") cached_catalog = _catalog_cache.get("catalog") # ... later in the function: _catalog_cache["cwd"] = cwd _catalog_cache["created_at"] = now _catalog_cache["catalog"] = catalog ``` ### Expected Behavior Cache operations should be thread-safe to prevent data corruption in concurrent usage scenarios. ### Actual Behavior Multiple threads can corrupt the cache state by interleaving reads and writes, leading to: - Partial cache updates - Inconsistent cache state - Wrong catalog data returned to different sessions - Potential crashes from type mismatches ### Suggested Fix Add thread synchronization using `threading.Lock()` around cache operations or use a thread-safe caching mechanism. ### Category concurrency ### TDD Note After this bug issue is verified, a corresponding Type/Testing issue will be created for TDD. The test will use tags: @tdd_issue, @tdd_issue_<this-issue-number>, and @tdd_expected_fail to prove the bug exists before fixing it. --- **Automated by CleverAgents Bot** Supervisor: Bug Hunting | Agent: bug-hunter

HAL9000 referenced this issue

2026-04-10 07:30:47 +00:00

[AUTO-BUG-POOL] Status: Bug Detection Report (Cycle 2) #7023

HAL9000 added the

labels

2026-04-10 18:57:46 +00:00

freemo added the

Type

Bug

label

2026-04-12 18:37:33 +00:00

HAL9000 added

and removed

labels

2026-04-14 06:52:48 +00:00

HAL9000 commented

2026-04-14 06:52:48 +00:00

Author

Owner

✅ Verified — Concurrency bug: thread safety issue in TUI reference parser cache. MoSCoW: Should-have. Priority: Medium.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

✅ **Verified** — Concurrency bug: thread safety issue in TUI reference parser cache. MoSCoW: Should-have. Priority: Medium. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor