cleveragents/cleveragents-core

Fork 3

[INFRASTRUCTURE] Database Migration Runner Manipulates Global Environment Variables #7027

New issue

Open

opened 2026-04-10 07:09:23 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-10 07:09:23 +00:00

Owner

Bug Report: [resource-management] — Database Migration Environment Variable Manipulation

Severity Assessment

Impact: Thread safety and test isolation issues, potential configuration corruption
Likelihood: High - occurs during migration operations
Priority: Medium

Location

File: src/cleveragents/infrastructure/database/migration_runner.py
Function/Class: MigrationRunner.run_migration
Lines: Lines 214-223 (approx)

Description

The MigrationRunner directly manipulates global environment variables (os.environ) during migration operations. This creates thread safety issues and can cause test isolation problems when multiple migration operations run concurrently.

Evidence

# From migration_runner.py
old_db_url = os.environ.get("CLEVERAGENTS_DATABASE_URL")
os.environ["CLEVERAGENTS_DATABASE_URL"] = self.database_url
try:
    # migration operations
finally:
    if old_db_url:
        os.environ["CLEVERAGENTS_DATABASE_URL"] = old_db_url
    else:
        os.environ.pop("CLEVERAGENTS_DATABASE_URL", None)

Expected Behavior

Migration operations should not modify global state. Database URL should be passed directly to Alembic configuration or use isolated configuration contexts.

Actual Behavior

The migration runner temporarily modifies the global environment, which can:

Create race conditions between concurrent migrations
Affect other code relying on environment variables
Cause test isolation failures

Suggested Fix

Use Alembic's programmatic configuration API instead of environment variables
Create isolated configuration contexts for each migration
Pass database URLs directly to Alembic Config objects
Remove global environment variable manipulation

TDD Note

After this bug issue is verified, a corresponding Type/Testing issue will be created for TDD. The test will use tags: @tdd_issue, @tdd_issue_, and @tdd_expected_fail to prove the thread safety issue exists before fixing it.

Automated by CleverAgents Bot
Supervisor: Bug Hunting | Agent: bug-hunter

## Bug Report: [resource-management] — Database Migration Environment Variable Manipulation ### Severity Assessment - **Impact**: Thread safety and test isolation issues, potential configuration corruption - **Likelihood**: High - occurs during migration operations - **Priority**: Medium ### Location - **File**: `src/cleveragents/infrastructure/database/migration_runner.py` - **Function/Class**: `MigrationRunner.run_migration` - **Lines**: Lines 214-223 (approx) ### Description The MigrationRunner directly manipulates global environment variables (`os.environ`) during migration operations. This creates thread safety issues and can cause test isolation problems when multiple migration operations run concurrently. ### Evidence ```python # From migration_runner.py old_db_url = os.environ.get("CLEVERAGENTS_DATABASE_URL") os.environ["CLEVERAGENTS_DATABASE_URL"] = self.database_url try: # migration operations finally: if old_db_url: os.environ["CLEVERAGENTS_DATABASE_URL"] = old_db_url else: os.environ.pop("CLEVERAGENTS_DATABASE_URL", None) ``` ### Expected Behavior Migration operations should not modify global state. Database URL should be passed directly to Alembic configuration or use isolated configuration contexts. ### Actual Behavior The migration runner temporarily modifies the global environment, which can: 1. Create race conditions between concurrent migrations 2. Affect other code relying on environment variables 3. Cause test isolation failures ### Suggested Fix 1. Use Alembic's programmatic configuration API instead of environment variables 2. Create isolated configuration contexts for each migration 3. Pass database URLs directly to Alembic Config objects 4. Remove global environment variable manipulation ### Category resource-management | concurrency ### TDD Note After this bug issue is verified, a corresponding Type/Testing issue will be created for TDD. The test will use tags: @tdd_issue, @tdd_issue_<this-issue-number>, and @tdd_expected_fail to prove the thread safety issue exists before fixing it. --- **Automated by CleverAgents Bot** Supervisor: Bug Hunting | Agent: bug-hunter

HAL9000 referenced this issue

2026-04-10 07:30:10 +00:00

[AUTO-BUG-POOL] Status: Bug Detection Report (Cycle 2) #7023

HAL9000 referenced this issue

2026-04-10 07:30:47 +00:00

[AUTO-BUG-POOL] Status: Bug Detection Report (Cycle 2) #7023

HAL9000 added the

labels

2026-04-10 19:01:42 +00:00

HAL9000 added

and removed

labels

2026-04-14 06:59:47 +00:00

HAL9000 commented

2026-04-14 06:59:47 +00:00

Author

Owner

✅ Verified — Infrastructure bug: database migration runner manipulates global environment variables. MoSCoW: Must-have. Priority: High — global state manipulation is dangerous.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

✅ **Verified** — Infrastructure bug: database migration runner manipulates global environment variables. MoSCoW: Must-have. Priority: High — global state manipulation is dangerous. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor