cleveragents/cleveragents-core

Fork 3

[INFRASTRUCTURE] Plugin Loader Uses Untrusted Dynamic Imports - Security Risk #7026

New issue

Open

opened 2026-04-10 07:09:12 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-10 07:09:12 +00:00

Owner

Bug Report: [security] — Plugin Loader Dynamic Import Vulnerability

Severity Assessment

Impact: Potential arbitrary code execution if attacker can control module paths
Likelihood: Medium - depends on input validation and access controls
Priority: High

Location

File: src/cleveragents/infrastructure/plugins/loader.py
Function/Class: PluginLoader._import_class
Lines: Line 115

Description

The plugin loader uses importlib.import_module() with user-controlled input without sufficient validation. While there is a _validate_module_prefix method, dynamic imports with untrusted input can still pose security risks.

Evidence

# Line 115 in loader.py
module = importlib.import_module(module_path)

From Semgrep security scan:

"message": "Untrusted user input in `importlib.import_module()` function allows an attacker to load arbitrary code. Avoid dynamic values in `importlib.import_module()` or use a whitelist to prevent running untrusted code."

Expected Behavior

Plugin loading should use a strict whitelist approach or additional sandboxing to prevent loading of arbitrary modules.

Actual Behavior

The current implementation relies primarily on module prefix validation, which may not be sufficient for all attack vectors.

Suggested Fix

Implement a strict whitelist of allowed modules/plugins
Add additional validation beyond prefix checking
Consider using a plugin registry with pre-approved modules
Add logging for all plugin loading attempts

TDD Note

After this bug issue is verified, a corresponding Type/Testing issue will be created for TDD. The test will use tags: @tdd_issue, @tdd_issue_, and @tdd_expected_fail to prove the vulnerability exists before fixing it.

Automated by CleverAgents Bot
Supervisor: Bug Hunting | Agent: bug-hunter

## Bug Report: [security] — Plugin Loader Dynamic Import Vulnerability ### Severity Assessment - **Impact**: Potential arbitrary code execution if attacker can control module paths - **Likelihood**: Medium - depends on input validation and access controls - **Priority**: High ### Location - **File**: `src/cleveragents/infrastructure/plugins/loader.py` - **Function/Class**: `PluginLoader._import_class` - **Lines**: Line 115 ### Description The plugin loader uses `importlib.import_module()` with user-controlled input without sufficient validation. While there is a `_validate_module_prefix` method, dynamic imports with untrusted input can still pose security risks. ### Evidence ```python # Line 115 in loader.py module = importlib.import_module(module_path) ``` From Semgrep security scan: ``` "message": "Untrusted user input in `importlib.import_module()` function allows an attacker to load arbitrary code. Avoid dynamic values in `importlib.import_module()` or use a whitelist to prevent running untrusted code." ``` ### Expected Behavior Plugin loading should use a strict whitelist approach or additional sandboxing to prevent loading of arbitrary modules. ### Actual Behavior The current implementation relies primarily on module prefix validation, which may not be sufficient for all attack vectors. ### Suggested Fix 1. Implement a strict whitelist of allowed modules/plugins 2. Add additional validation beyond prefix checking 3. Consider using a plugin registry with pre-approved modules 4. Add logging for all plugin loading attempts ### Category security ### TDD Note After this bug issue is verified, a corresponding Type/Testing issue will be created for TDD. The test will use tags: @tdd_issue, @tdd_issue_<this-issue-number>, and @tdd_expected_fail to prove the vulnerability exists before fixing it. --- **Automated by CleverAgents Bot** Supervisor: Bug Hunting | Agent: bug-hunter

HAL9000 referenced this issue

2026-04-10 07:30:10 +00:00

[AUTO-BUG-POOL] Status: Bug Detection Report (Cycle 2) #7023

HAL9000 referenced this issue

2026-04-10 07:30:47 +00:00

[AUTO-BUG-POOL] Status: Bug Detection Report (Cycle 2) #7023

HAL9000 added the

labels

2026-04-10 19:01:43 +00:00

HAL9000 added

and removed

labels

2026-04-14 06:59:48 +00:00

HAL9000 commented

2026-04-14 06:59:48 +00:00

Author

Owner

✅ Verified — Security bug: plugin loader uses untrusted dynamic imports. MoSCoW: Must-have. Priority: High — security risk.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

✅ **Verified** — Security bug: plugin loader uses untrusted dynamic imports. MoSCoW: Must-have. Priority: High — security risk. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor