UAT: `agents plan diff --correction <ID>` is stubbed — returns placeholder instead of real correction changeset diff #6811

New issue

Open

opened 2026-04-10 02:12:15 +00:00 by HAL9000 · 0 comments

HAL9000 commented

2026-04-10 02:12:15 +00:00

Owner

What Was Tested

agents plan diff --correction <CORRECTION_ATTEMPT_ID> <PLAN_ID> command behavior (code analysis of src/cleveragents/cli/commands/plan.py, lines 3295–3307).

Expected Behavior (from Spec §agents plan diff, line 343)

agents plan diff (--correction <CORRECTION_ATTEMPT_ID>|<PLAN_ID>)

When --correction is supplied, agents plan diff must show the changeset diff for that specific correction attempt — i.e., which files would change and how, comparing the pre-correction state to the post-correction recomputed state. This is part of the correction model's review workflow (it's referenced in the History panel of agents plan correct output as: agents plan diff --correction <ID>).

Actual Behavior

The implementation at lines 3296–3307 contains an explicit stub that returns a hardcoded placeholder:

if correction:
    # Show correction-specific diff (stub: shows info panel)
    console.print(
        Panel(
            f"[bold]Correction Attempt:[/bold] {correction}\n"
            f"[bold]Plan:[/bold] {plan_id}\n\n"
            "[dim]Correction diff will be available after M4.2.[/dim]",  # STUB
            title="Correction Diff",
            expand=False,
        )
    )
    return

The comment explicitly says "Correction diff will be available after M4.2." — this is an unimplemented feature stub. Users who follow the correction workflow and run agents plan diff --correction <ID> as instructed by the History panel will receive a placeholder instead of actual diff output.

Impact

This creates a broken correction review loop:

User runs agents plan correct --mode revert -g "..." --yes → sees History panel suggesting agents plan diff --correction <ID>
User runs that command → gets a placeholder message instead of the actual diff

Steps to Reproduce

Review src/cleveragents/cli/commands/plan.py lines 3295–3307
Note the explicit "will be available after M4.2" stub comment
Compare to spec: agents plan diff (--correction <CORRECTION_ATTEMPT_ID>|<PLAN_ID>) (line 343)

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## What Was Tested `agents plan diff --correction <CORRECTION_ATTEMPT_ID> <PLAN_ID>` command behavior (code analysis of `src/cleveragents/cli/commands/plan.py`, lines 3295–3307). ## Expected Behavior (from Spec §agents plan diff, line 343) ``` agents plan diff (--correction <CORRECTION_ATTEMPT_ID>|<PLAN_ID>) ``` When `--correction` is supplied, `agents plan diff` must show the **changeset diff for that specific correction attempt** — i.e., which files would change and how, comparing the pre-correction state to the post-correction recomputed state. This is part of the correction model's review workflow (it's referenced in the `History` panel of `agents plan correct` output as: `agents plan diff --correction <ID>`). ## Actual Behavior The implementation at lines 3296–3307 contains an **explicit stub that returns a hardcoded placeholder**: ```python if correction: # Show correction-specific diff (stub: shows info panel) console.print( Panel( f"[bold]Correction Attempt:[/bold] {correction}\n" f"[bold]Plan:[/bold] {plan_id}\n\n" "[dim]Correction diff will be available after M4.2.[/dim]", # STUB title="Correction Diff", expand=False, ) ) return ``` The comment explicitly says `"Correction diff will be available after M4.2."` — this is an unimplemented feature stub. Users who follow the correction workflow and run `agents plan diff --correction <ID>` as instructed by the `History` panel will receive a placeholder instead of actual diff output. ## Impact This creates a broken correction review loop: 1. User runs `agents plan correct --mode revert -g "..." --yes` → sees History panel suggesting `agents plan diff --correction <ID>` 2. User runs that command → gets a placeholder message instead of the actual diff ## Steps to Reproduce 1. Review `src/cleveragents/cli/commands/plan.py` lines 3295–3307 2. Note the explicit `"will be available after M4.2"` stub comment 3. Compare to spec: `agents plan diff (--correction <CORRECTION_ATTEMPT_ID>|<PLAN_ID>)` (line 343) --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

Rows
Columns

UAT: agents plan diff --correction <ID> is stubbed — returns placeholder instead of real correction changeset diff #6811