cleveragents/cleveragents-core

Fork 3

UAT: `InvariantService` uses in-memory storage — invariants lost between CLI invocations #6795

New issue

Open

opened 2026-04-10 02:06:40 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-10 02:06:40 +00:00

Owner

What Was Tested

Code analysis of InvariantService in src/cleveragents/application/services/invariant_service.py and the module-level singleton pattern in src/cleveragents/cli/commands/invariant.py.

Expected Behavior (From Spec)

The spec treats invariants as first-class persistent entities. Per docs/specification.md:

Invariants are listed alongside plans, projects, actions, and other persistent entities that survive across CLI invocations
agents invariant list is expected to return previously added invariants in any future CLI session
Invariants reference plans by ULID (--plan PLAN_ID) implying they must outlive the current process
The system has a persistent SQLite database (~/.cleveragents/cleveragents.db as shown in spec §agents init output), and all user-facing entities are stored there

Actual Behavior

InvariantService explicitly uses in-memory storage with no persistence:

# src/cleveragents/application/services/invariant_service.py lines 8-10 (module docstring)
"""
## Storage
Uses in-memory storage (same pattern as ``PlanLifecycleService``) with
a dict keyed by invariant ID.
"""

# Line 57
self._invariants: dict[str, Invariant] = {}  # purely in-memory

The CLI module also uses a process-lifetime module-level singleton:

# src/cleveragents/cli/commands/invariant.py lines 58-59
# Module-level service instance (in-memory, same lifetime as CLI process)
_service: InvariantService | None = None

This means:

agents invariant add --global "Never delete production data" adds the invariant
The CLI process exits
agents invariant list --global returns nothing — the invariant is gone

Steps to Reproduce

# Session 1
agents invariant add --global "Never delete production data"
# → Invariant added: <some-id>

# Session 2 (new process)
agents invariant list --global
# → "No invariants found."  (should show the previously added invariant)

Impact

This is a fundamental correctness failure. Invariants are intended to be persistent constraints that guide plan execution across the system lifetime. Without persistence:

Any invariants added via the CLI are silently discarded at process exit
The Invariant Reconciliation Actor at Strategize time will always see zero CLI-managed invariants
The invariant system is effectively non-functional for the primary use case

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## What Was Tested Code analysis of `InvariantService` in `src/cleveragents/application/services/invariant_service.py` and the module-level singleton pattern in `src/cleveragents/cli/commands/invariant.py`. ## Expected Behavior (From Spec) The spec treats invariants as first-class persistent entities. Per `docs/specification.md`: - Invariants are listed alongside plans, projects, actions, and other persistent entities that survive across CLI invocations - `agents invariant list` is expected to return previously added invariants in any future CLI session - Invariants reference plans by ULID (`--plan PLAN_ID`) implying they must outlive the current process - The system has a persistent SQLite database (`~/.cleveragents/cleveragents.db` as shown in spec §agents init output), and all user-facing entities are stored there ## Actual Behavior `InvariantService` explicitly uses in-memory storage with no persistence: ```python # src/cleveragents/application/services/invariant_service.py lines 8-10 (module docstring) """ ## Storage Uses in-memory storage (same pattern as ``PlanLifecycleService``) with a dict keyed by invariant ID. """ # Line 57 self._invariants: dict[str, Invariant] = {} # purely in-memory ``` The CLI module also uses a process-lifetime module-level singleton: ```python # src/cleveragents/cli/commands/invariant.py lines 58-59 # Module-level service instance (in-memory, same lifetime as CLI process) _service: InvariantService | None = None ``` This means: 1. `agents invariant add --global "Never delete production data"` adds the invariant 2. The CLI process exits 3. `agents invariant list --global` returns nothing — the invariant is gone ## Steps to Reproduce ```bash # Session 1 agents invariant add --global "Never delete production data" # → Invariant added: <some-id> # Session 2 (new process) agents invariant list --global # → "No invariants found." (should show the previously added invariant) ``` ## Impact This is a fundamental correctness failure. Invariants are intended to be persistent constraints that guide plan execution across the system lifetime. Without persistence: - Any invariants added via the CLI are silently discarded at process exit - The `Invariant Reconciliation Actor` at Strategize time will always see zero CLI-managed invariants - The invariant system is effectively non-functional for the primary use case --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 added this to the v3.4.0 milestone

2026-04-10 02:06:47 +00:00

HAL9000 added the

labels

2026-04-10 02:06:48 +00:00

HAL9000 referenced this issue

2026-04-10 02:08:40 +00:00

[AUTO-UAT-POOL] UAT Testing Report (Cycle 4) #6758

HAL9000 referenced this issue

2026-04-10 05:55:44 +00:00

UAT: Invariants are not persisted between CLI invocations #6916

HAL9000 referenced this issue

2026-04-10 05:56:06 +00:00

UAT: Invariants are not persisted between CLI invocations #6916

HAL9000 referenced this issue

2026-04-10 05:56:57 +00:00

[AUTO-BLOG] Status: Backlog Groomer (Cycle 1) #6936

HAL9000 referenced this issue

2026-04-10 06:08:22 +00:00

[AUTO-BLOG] Status: Backlog Groomer (Cycle 1) #6936

HAL9000 referenced this issue

2026-04-10 06:12:32 +00:00

[AUTO-BLOG] Status: Backlog Groomer (Cycle 2) #6994

HAL9000 referenced this issue

2026-04-10 06:26:48 +00:00

[AUTO-PROJ-OWN] Project Owner Report (Cycle 1) #7007

HAL9000 added

and removed

labels

2026-04-14 07:19:46 +00:00

HAL9000 commented

2026-04-14 07:19:46 +00:00

Author

Owner

✅ Verified — UAT bug: InvariantService uses in-memory storage — invariants lost between CLI invocations. MoSCoW: Must-have. Priority: High — this is a fundamental v3.2.0 deliverable failure.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

✅ **Verified** — UAT bug: InvariantService uses in-memory storage — invariants lost between CLI invocations. MoSCoW: Must-have. Priority: High — this is a fundamental v3.2.0 deliverable failure. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor