cleveragents/cleveragents-core

Fork 3

UAT: Invariant IDs use raw ULID format instead of spec-required `inv_` prefix #6773

New issue

Open

opened 2026-04-10 02:05:08 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-10 02:05:08 +00:00

Owner

What Was Tested

Code analysis of InvariantService.add_invariant() in src/cleveragents/application/services/invariant_service.py and the Invariant domain model in src/cleveragents/domain/models/core/invariant.py.

Expected Behavior (From Spec)

Per docs/specification.md §agents invariant add (lines ~17912, ~17923, ~17934, ~17945), every invariant ID must use the inv_-prefixed format:

ID: inv_01HXM9A1B

The JSON output schema also confirms this format:

{ "id": "inv_01HXM9A1B" }

All specification examples consistently show inv_-prefixed IDs.

Actual Behavior

InvariantService.add_invariant() generates IDs using a raw ULID():

# src/cleveragents/application/services/invariant_service.py line 92
invariant = Invariant(
    id=str(ULID()),   # <-- generates e.g. "01HXM9A1B3K7C2B3F2R4VYV6J", not "inv_01HXM9A1B..."
    ...
)

The Invariant domain model field also defaults to a raw ULID:

# src/cleveragents/domain/models/core/invariant.py line 61
id: str = Field(
    default_factory=lambda: str(ULID()),   # <-- no "inv_" prefix
    ...
)

This means all invariant IDs are raw ULIDs like 01HXM9A1B3K7C2B3F2R4VYV6J rather than the spec-required inv_01HXM9A1B... format.

Steps to Reproduce

from cleveragents.application.services.invariant_service import InvariantService
from cleveragents.domain.models.core.invariant import InvariantScope

svc = InvariantService()
inv = svc.add_invariant(text="test", scope=InvariantScope.GLOBAL, source_name="system")
print(inv.id)  # Prints: "01HXM9A1B3K7C2B3F2R4VYV6J"  (should be "inv_01HXM9A1B...")

Impact

This is a clear spec violation affecting:

CLI output (both rich and structured JSON/YAML formats)
agents invariant remove <INVARIANT_ID> (users would try inv_xxx IDs per the spec)
Any integration or tooling that expects the inv_ prefix

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## What Was Tested Code analysis of `InvariantService.add_invariant()` in `src/cleveragents/application/services/invariant_service.py` and the `Invariant` domain model in `src/cleveragents/domain/models/core/invariant.py`. ## Expected Behavior (From Spec) Per `docs/specification.md` §agents invariant add (lines ~17912, ~17923, ~17934, ~17945), every invariant ID must use the `inv_`-prefixed format: ``` ID: inv_01HXM9A1B ``` The JSON output schema also confirms this format: ```json { "id": "inv_01HXM9A1B" } ``` All specification examples consistently show `inv_`-prefixed IDs. ## Actual Behavior `InvariantService.add_invariant()` generates IDs using a raw `ULID()`: ```python # src/cleveragents/application/services/invariant_service.py line 92 invariant = Invariant( id=str(ULID()), # <-- generates e.g. "01HXM9A1B3K7C2B3F2R4VYV6J", not "inv_01HXM9A1B..." ... ) ``` The `Invariant` domain model field also defaults to a raw ULID: ```python # src/cleveragents/domain/models/core/invariant.py line 61 id: str = Field( default_factory=lambda: str(ULID()), # <-- no "inv_" prefix ... ) ``` This means all invariant IDs are raw ULIDs like `01HXM9A1B3K7C2B3F2R4VYV6J` rather than the spec-required `inv_01HXM9A1B...` format. ## Steps to Reproduce ```python from cleveragents.application.services.invariant_service import InvariantService from cleveragents.domain.models.core.invariant import InvariantScope svc = InvariantService() inv = svc.add_invariant(text="test", scope=InvariantScope.GLOBAL, source_name="system") print(inv.id) # Prints: "01HXM9A1B3K7C2B3F2R4VYV6J" (should be "inv_01HXM9A1B...") ``` ## Impact This is a clear spec violation affecting: - CLI output (both rich and structured JSON/YAML formats) - `agents invariant remove <INVARIANT_ID>` (users would try `inv_xxx` IDs per the spec) - Any integration or tooling that expects the `inv_` prefix --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 added this to the v3.4.0 milestone

2026-04-10 02:05:14 +00:00

HAL9000 added the

labels

2026-04-10 02:05:19 +00:00

HAL9000 referenced this issue

2026-04-10 02:08:40 +00:00

[AUTO-UAT-POOL] UAT Testing Report (Cycle 4) #6758

HAL9000 added

and removed

labels

2026-04-14 07:19:49 +00:00

HAL9000 commented

2026-04-14 07:19:49 +00:00

Author

Owner

✅ Verified — UAT bug: invariant IDs missing inv_ prefix. Spec violation. MoSCoW: Must-have. Priority: High.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

✅ **Verified** — UAT bug: invariant IDs missing `inv_` prefix. Spec violation. MoSCoW: Must-have. Priority: High. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor