cleveragents/cleveragents-core

Fork 3

BUG-HUNT: [spec-alignment] `Settings.is_langsmith_enabled` unconditionally writes `LANGCHAIN_TRACING_V2=true` to `os.environ` — env mutation is irreversible and cannot be undone by `Settings.reset()` #6567

New issue

Open

opened 2026-04-09 21:28:18 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-09 21:28:18 +00:00

Owner

Bug Report: [spec-alignment] — Irreversible `os.environ` Mutation in LangSmith Initialization

Severity Assessment

Impact: Once LangSmith is enabled in any Settings instance during a process lifetime, LANGCHAIN_TRACING_V2=true is permanently set in os.environ. Even after Settings.reset() followed by re-construction with LangSmith disabled, the env var remains 'true', causing all LangChain operations to continue tracing when they should not. This silently activates LangSmith tracing in test suites and production processes that disable LangSmith mid-run.
Likelihood: Medium — occurs reliably whenever CLEVERAGENTS_LANGSMITH_ENABLED=true is in the environment and Settings.reset() is used (e.g., in tests or config reloads).
Priority: Medium

Location

File: src/cleveragents/config/settings.py
Function/Class: Settings.is_langsmith_enabled (property) → Settings._synchronize_langsmith_environment()
Lines: 797–803, 877–888

Description

model_post_init() calls self.is_langsmith_enabled to "prime" LangSmith state:

# Line 710
_ = self.is_langsmith_enabled

The property unconditionally writes to os.environ if LangSmith is configured:

# Lines 797-803
@property
def is_langsmith_enabled(self) -> bool:
    enabled, errors = self._evaluate_langsmith_configuration()
    self._langsmith_validation_errors = errors
    if enabled:
        self._synchronize_langsmith_environment()  # ← mutates os.environ
    return enabled

_synchronize_langsmith_environment() does:

# Lines 877-888
def _synchronize_langsmith_environment(self) -> None:
    os.environ["LANGCHAIN_TRACING_V2"] = "true"        # ← ALWAYS set (not setdefault)
    api_key = self._get_langsmith_api_key()
    if api_key:
        os.environ.setdefault("LANGCHAIN_API_KEY", api_key)
    project = self._get_langsmith_project()
    if project:
        os.environ.setdefault("LANGCHAIN_PROJECT", project)
    endpoint = self._get_langsmith_endpoint()
    if endpoint:
        os.environ.setdefault("LANGCHAIN_ENDPOINT", endpoint)

The bug: os.environ["LANGCHAIN_TRACING_V2"] = "true" is an unconditional assignment (not setdefault). Once executed, there is no code path in the entire Settings class that sets it back to "false" or removes it. Calling Settings.reset() clears _instance but does not clean up os.environ. The next Settings() construction — even with CLEVERAGENTS_LANGSMITH_ENABLED=false — will call model_post_init, but _synchronize_langsmith_environment won't be called (since LangSmith is disabled), leaving LANGCHAIN_TRACING_V2=true in the environment indefinitely.

Additionally, is_langsmith_enabled is called every time build_langsmith_config() is invoked (line 817), potentially writing to os.environ on every LangSmith config build call — which is a side effect that makes a property access non-idempotent from an environment-state perspective.

Evidence

# src/cleveragents/config/settings.py

# Line 710 - called on EVERY Settings construction:
_ = self.is_langsmith_enabled

# Lines 877-879 - irreversible os.environ write:
def _synchronize_langsmith_environment(self) -> None:
    """Ensure LangChain environment variables mirror CleverAgents config."""
    os.environ["LANGCHAIN_TRACING_V2"] = "true"  # ← no cleanup path exists

Expected Behavior

Settings._synchronize_langsmith_environment() should use os.environ.setdefault() for LANGCHAIN_TRACING_V2, or — better — clean up env vars in Settings.reset() and when LangSmith is disabled. Environment mutations should be reversible so that Settings.reset() fully restores the process to a clean state.

Actual Behavior

LANGCHAIN_TRACING_V2=true is permanently set in os.environ once any Settings instance with LangSmith enabled is constructed. This persists across Settings.reset() calls, through subsequent Settings constructions with LangSmith disabled, and affects the entire process including test isolation.

Suggested Fix

Option 1 — Track what was set and clean up in reset():

_environ_mutations: ClassVar[dict[str, str | None]] = {}  # key -> original value

def _synchronize_langsmith_environment(self) -> None:
    for key, value in [
        ("LANGCHAIN_TRACING_V2", "true"),
        ("LANGCHAIN_API_KEY", self._get_langsmith_api_key()),
        ...
    ]:
        if value:
            cls._environ_mutations.setdefault(key, os.environ.get(key))  # save original
            os.environ[key] = value

@classmethod
def reset(cls) -> None:
    with cls._instance_lock:
        cls._instance = None
        # Restore original env values
        for key, original in cls._environ_mutations.items():
            if original is None:
                os.environ.pop(key, None)
            else:
                os.environ[key] = original
        cls._environ_mutations.clear()

Option 2 — Don't write os.environ in model_post_init; only write lazily when actually needed by LangChain callers.

TDD Note

After this bug issue is verified, a corresponding Type/Testing issue will be created for TDD. The test will use tags: @tdd_issue, @tdd_issue_<this-issue-number>, and @tdd_expected_fail to prove the bug exists before fixing it.

Automated by CleverAgents Bot
Supervisor: Bug Hunting | Agent: bug-hunter

## Bug Report: [spec-alignment] — Irreversible `os.environ` Mutation in LangSmith Initialization ### Severity Assessment - **Impact**: Once LangSmith is enabled in any `Settings` instance during a process lifetime, `LANGCHAIN_TRACING_V2=true` is permanently set in `os.environ`. Even after `Settings.reset()` followed by re-construction with LangSmith disabled, the env var remains `'true'`, causing all LangChain operations to continue tracing when they should not. This silently activates LangSmith tracing in test suites and production processes that disable LangSmith mid-run. - **Likelihood**: Medium — occurs reliably whenever `CLEVERAGENTS_LANGSMITH_ENABLED=true` is in the environment and `Settings.reset()` is used (e.g., in tests or config reloads). - **Priority**: Medium ### Location - **File**: `src/cleveragents/config/settings.py` - **Function/Class**: `Settings.is_langsmith_enabled` (property) → `Settings._synchronize_langsmith_environment()` - **Lines**: 797–803, 877–888 ### Description `model_post_init()` calls `self.is_langsmith_enabled` to "prime" LangSmith state: ```python # Line 710 _ = self.is_langsmith_enabled ``` The property unconditionally writes to `os.environ` if LangSmith is configured: ```python # Lines 797-803 @property def is_langsmith_enabled(self) -> bool: enabled, errors = self._evaluate_langsmith_configuration() self._langsmith_validation_errors = errors if enabled: self._synchronize_langsmith_environment() # ← mutates os.environ return enabled ``` `_synchronize_langsmith_environment()` does: ```python # Lines 877-888 def _synchronize_langsmith_environment(self) -> None: os.environ["LANGCHAIN_TRACING_V2"] = "true" # ← ALWAYS set (not setdefault) api_key = self._get_langsmith_api_key() if api_key: os.environ.setdefault("LANGCHAIN_API_KEY", api_key) project = self._get_langsmith_project() if project: os.environ.setdefault("LANGCHAIN_PROJECT", project) endpoint = self._get_langsmith_endpoint() if endpoint: os.environ.setdefault("LANGCHAIN_ENDPOINT", endpoint) ``` **The bug**: `os.environ["LANGCHAIN_TRACING_V2"] = "true"` is an unconditional assignment (not `setdefault`). Once executed, there is no code path in the entire `Settings` class that sets it back to `"false"` or removes it. Calling `Settings.reset()` clears `_instance` but does **not** clean up `os.environ`. The next `Settings()` construction — even with `CLEVERAGENTS_LANGSMITH_ENABLED=false` — will call `model_post_init`, but `_synchronize_langsmith_environment` won't be called (since LangSmith is disabled), leaving `LANGCHAIN_TRACING_V2=true` in the environment indefinitely. Additionally, `is_langsmith_enabled` is called **every time** `build_langsmith_config()` is invoked (line 817), potentially writing to `os.environ` on every LangSmith config build call — which is a side effect that makes a property access non-idempotent from an environment-state perspective. ### Evidence ```python # src/cleveragents/config/settings.py # Line 710 - called on EVERY Settings construction: _ = self.is_langsmith_enabled # Lines 877-879 - irreversible os.environ write: def _synchronize_langsmith_environment(self) -> None: """Ensure LangChain environment variables mirror CleverAgents config.""" os.environ["LANGCHAIN_TRACING_V2"] = "true" # ← no cleanup path exists ``` ### Expected Behavior `Settings._synchronize_langsmith_environment()` should use `os.environ.setdefault()` for `LANGCHAIN_TRACING_V2`, or — better — clean up env vars in `Settings.reset()` and when LangSmith is disabled. Environment mutations should be reversible so that `Settings.reset()` fully restores the process to a clean state. ### Actual Behavior `LANGCHAIN_TRACING_V2=true` is permanently set in `os.environ` once any `Settings` instance with LangSmith enabled is constructed. This persists across `Settings.reset()` calls, through subsequent Settings constructions with LangSmith disabled, and affects the entire process including test isolation. ### Suggested Fix Option 1 — Track what was set and clean up in `reset()`: ```python _environ_mutations: ClassVar[dict[str, str | None]] = {} # key -> original value def _synchronize_langsmith_environment(self) -> None: for key, value in [ ("LANGCHAIN_TRACING_V2", "true"), ("LANGCHAIN_API_KEY", self._get_langsmith_api_key()), ... ]: if value: cls._environ_mutations.setdefault(key, os.environ.get(key)) # save original os.environ[key] = value @classmethod def reset(cls) -> None: with cls._instance_lock: cls._instance = None # Restore original env values for key, original in cls._environ_mutations.items(): if original is None: os.environ.pop(key, None) else: os.environ[key] = original cls._environ_mutations.clear() ``` Option 2 — Don't write `os.environ` in `model_post_init`; only write lazily when actually needed by LangChain callers. ### Category spec-alignment / concurrency ### TDD Note After this bug issue is verified, a corresponding Type/Testing issue will be created for TDD. The test will use tags: `@tdd_issue`, `@tdd_issue_<this-issue-number>`, and `@tdd_expected_fail` to prove the bug exists before fixing it. --- **Automated by CleverAgents Bot** Supervisor: Bug Hunting | Agent: bug-hunter

HAL9000 added the

labels

2026-04-09 21:30:43 +00:00

HAL9000 added this to the v3.2.0 milestone

2026-04-09 21:31:43 +00:00

HAL9000 commented

2026-04-17 08:05:58 +00:00

Author

Owner

✅ Verified — Valid spec-alignment bug. Irreversible env mutation that cannot be undone by Settings.reset() is a correctness issue. MoSCoW: Should Have — env mutation side effects can cause hard-to-debug issues in testing.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

✅ **Verified** — Valid spec-alignment bug. Irreversible env mutation that cannot be undone by Settings.reset() is a correctness issue. **MoSCoW: Should Have** — env mutation side effects can cause hard-to-debug issues in testing. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor

HAL9000 added

and removed

labels

2026-04-18 08:26:39 +00:00