cleveragents/cleveragents-core

Fork 3

BUG-HUNT: [error-handling] `agents plan use` missing broad `Exception` catch — unhandled tracebacks exposed when DI container or plan model raises non-CleverAgentsError exceptions #6440

New issue

Open

opened 2026-04-09 21:03:24 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-09 21:03:24 +00:00

Owner

Bug Report: [error-handling] — `agents plan use` Missing Broad Exception Handler Exposes Internal Tracebacks

Severity Assessment

Impact: When the DI container fails to wire services (e.g., database unavailable, misconfigured DB URL, missing migration), or when the plan domain model raises AttributeError/KeyError/TypeError, the use_action command propagates an unhandled Python traceback to the user's terminal instead of a clean error message. This exposes internal stack traces, module paths, and potentially sensitive configuration details.
Likelihood: Medium — most likely during first-time setup, CI environments, or after incomplete migrations.
Priority: High

Location

File: src/cleveragents/cli/commands/plan.py
Function/Class: use_action() command
Lines: 2041–2263 (entire command body)
Error handler block: Lines 2255–2263

Description

The use_action() (i.e. agents plan use) command has a narrow exception handler at its tail that only catches:

ActionNotAvailableError
ValidationError
CleverAgentsError

Any exception that doesn't inherit from these three (e.g., AttributeError, KeyError, TypeError, OperationalError from SQLAlchemy, ImportError from dynamic service loading, ValueError from actor validation helpers) propagates to the top-level main() function and ultimately prints a raw traceback or is caught by the global Exception handler in main() — which also lacks context about the failed command.

Compare this to execute_plan() and lifecycle_apply_plan() which both include a final except Exception as e: catch.

Evidence

# src/cleveragents/cli/commands/plan.py lines 2255–2263 — use_action error handling
    except ActionNotAvailableError as e:
        console.print(f"[red]Action not available:[/red] {e}")
        raise typer.Abort() from e
    except ValidationError as e:
        console.print(f"[red]Validation Error:[/red] {e.message}")
        raise typer.Abort() from e
    except CleverAgentsError as e:
        console.print(f"[red]Error:[/red] {e.message}")
        raise typer.Abort() from e
    # ← NO broad Exception catch here!

Compare to execute_plan() at lines 2495–2503:

    except CleverAgentsError as e:
        console.print(f"[red]Error:[/red] {e.message}")
        raise typer.Abort() from e
    except Exception as e:       # ← execute_plan HAS this
        console.print(f"[red]Unexpected error:[/red] {e}")
        raise typer.Abort() from e

And lifecycle_apply_plan() at lines 2644–2650:

    except Exception as e:
        if isinstance(e, (typer.Abort, typer.Exit)):
            raise
        console.print(f"[red]Unexpected error:[/red] {e}")
        raise typer.Abort() from e

Concrete failure scenario: If service.use_action() raises a sqlalchemy.exc.OperationalError (e.g., "unable to open database file"), the raw traceback is displayed containing full file paths and the database URL. Similarly, if actor validation helper validate_namespaced_actor() raises a plain ValueError (the ValidationError.from_message path isn't always used), it propagates unhandled.

Additionally, the use_action() body contains:

# Lines 2152–2158 — project context propagation
try:
    ...
    blob = _load_policy_json(sf, proj_name) or {}
    ...
except Exception:
    pass  # Project context not available; skip propagation

This silently swallows all exceptions inside the try-block, which is intentional. However, the outer handler missing means exceptions from the plan model mutation lines (e.g., plan.strategy_actor = strategy_actor) that occur OUTSIDE any nested try block are unhandled.

Expected Behavior

Any exception from agents plan use should be caught and displayed as a clean error message:

Error: Failed to create plan: <human-readable message>

And exit with code 1. No Python traceback should be shown.

Actual Behavior

Unhandled exceptions propagate as raw Python tracebacks exposing internal module paths and potentially sensitive configuration (database URLs, service names).

Suggested Fix

Add a final broad catch to use_action():

    except ActionNotAvailableError as e:
        console.print(f"[red]Action not available:[/red] {e}")
        raise typer.Abort() from e
    except ValidationError as e:
        console.print(f"[red]Validation Error:[/red] {e.message}")
        raise typer.Abort() from e
    except CleverAgentsError as e:
        console.print(f"[red]Error:[/red] {e.message}")
        raise typer.Abort() from e
    except Exception as e:  # ADD THIS
        console.print(f"[red]Unexpected error:[/red] {e}")
        raise typer.Abort() from e

TDD Note

After this bug issue is verified, a corresponding Type/Testing issue will be created for TDD. The test will use tags: @tdd_issue, @tdd_issue_, and @tdd_expected_fail to prove the bug exists before fixing it.

Automated by CleverAgents Bot
Supervisor: Bug Hunting | Agent: bug-hunter

## Bug Report: [error-handling] — `agents plan use` Missing Broad Exception Handler Exposes Internal Tracebacks ### Severity Assessment - **Impact**: When the DI container fails to wire services (e.g., database unavailable, misconfigured DB URL, missing migration), or when the plan domain model raises `AttributeError`/`KeyError`/`TypeError`, the `use_action` command propagates an unhandled Python traceback to the user's terminal instead of a clean error message. This exposes internal stack traces, module paths, and potentially sensitive configuration details. - **Likelihood**: Medium — most likely during first-time setup, CI environments, or after incomplete migrations. - **Priority**: High ### Location - **File**: `src/cleveragents/cli/commands/plan.py` - **Function/Class**: `use_action()` command - **Lines**: 2041–2263 (entire command body) - **Error handler block**: Lines 2255–2263 ### Description The `use_action()` (i.e. `agents plan use`) command has a narrow exception handler at its tail that only catches: 1. `ActionNotAvailableError` 2. `ValidationError` 3. `CleverAgentsError` Any exception that doesn't inherit from these three (e.g., `AttributeError`, `KeyError`, `TypeError`, `OperationalError` from SQLAlchemy, `ImportError` from dynamic service loading, `ValueError` from actor validation helpers) propagates to the top-level `main()` function and ultimately prints a raw traceback or is caught by the global `Exception` handler in `main()` — which also lacks context about the failed command. Compare this to `execute_plan()` and `lifecycle_apply_plan()` which **both** include a final `except Exception as e:` catch. ### Evidence ```python # src/cleveragents/cli/commands/plan.py lines 2255–2263 — use_action error handling except ActionNotAvailableError as e: console.print(f"[red]Action not available:[/red] {e}") raise typer.Abort() from e except ValidationError as e: console.print(f"[red]Validation Error:[/red] {e.message}") raise typer.Abort() from e except CleverAgentsError as e: console.print(f"[red]Error:[/red] {e.message}") raise typer.Abort() from e # ← NO broad Exception catch here! ``` Compare to `execute_plan()` at lines 2495–2503: ```python except CleverAgentsError as e: console.print(f"[red]Error:[/red] {e.message}") raise typer.Abort() from e except Exception as e: # ← execute_plan HAS this console.print(f"[red]Unexpected error:[/red] {e}") raise typer.Abort() from e ``` And `lifecycle_apply_plan()` at lines 2644–2650: ```python except Exception as e: if isinstance(e, (typer.Abort, typer.Exit)): raise console.print(f"[red]Unexpected error:[/red] {e}") raise typer.Abort() from e ``` **Concrete failure scenario**: If `service.use_action()` raises a `sqlalchemy.exc.OperationalError` (e.g., "unable to open database file"), the raw traceback is displayed containing full file paths and the database URL. Similarly, if actor validation helper `validate_namespaced_actor()` raises a plain `ValueError` (the `ValidationError.from_message` path isn't always used), it propagates unhandled. Additionally, the `use_action()` body contains: ```python # Lines 2152–2158 — project context propagation try: ... blob = _load_policy_json(sf, proj_name) or {} ... except Exception: pass # Project context not available; skip propagation ``` This silently swallows all exceptions inside the try-block, which is intentional. However, the outer handler missing means exceptions from the plan model mutation lines (e.g., `plan.strategy_actor = strategy_actor`) that occur OUTSIDE any nested try block are unhandled. ### Expected Behavior Any exception from `agents plan use` should be caught and displayed as a clean error message: ``` Error: Failed to create plan: <human-readable message> ``` And exit with code 1. No Python traceback should be shown. ### Actual Behavior Unhandled exceptions propagate as raw Python tracebacks exposing internal module paths and potentially sensitive configuration (database URLs, service names). ### Suggested Fix Add a final broad catch to `use_action()`: ```python except ActionNotAvailableError as e: console.print(f"[red]Action not available:[/red] {e}") raise typer.Abort() from e except ValidationError as e: console.print(f"[red]Validation Error:[/red] {e.message}") raise typer.Abort() from e except CleverAgentsError as e: console.print(f"[red]Error:[/red] {e.message}") raise typer.Abort() from e except Exception as e: # ADD THIS console.print(f"[red]Unexpected error:[/red] {e}") raise typer.Abort() from e ``` ### Category error-handling ### TDD Note After this bug issue is verified, a corresponding Type/Testing issue will be created for TDD. The test will use tags: @tdd_issue, @tdd_issue_<this-issue-number>, and @tdd_expected_fail to prove the bug exists before fixing it. --- **Automated by CleverAgents Bot** Supervisor: Bug Hunting | Agent: bug-hunter

HAL9000 added the

labels

2026-04-09 21:08:15 +00:00

HAL9000 commented

2026-04-17 08:48:03 +00:00

Author

Owner

✅ Verified — Valid error-handling bug. Unhandled tracebacks exposed when DI container or plan model raises non-CleverAgentsError exceptions. MoSCoW: Could Have — error handling improvement.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

✅ **Verified** — Valid error-handling bug. Unhandled tracebacks exposed when DI container or plan model raises non-CleverAgentsError exceptions. **MoSCoW: Could Have** — error handling improvement. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor

HAL9000 added this to the v3.2.0 milestone

2026-04-17 08:48:43 +00:00

HAL9000 added

and removed

labels

2026-04-18 08:42:08 +00:00