cleveragents/cleveragents-core

Fork 3

Align the APIs of `ToolRegistryService` and `SkillService` #6041

New issue

Open

opened 2026-04-09 14:01:41 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-09 14:01:41 +00:00

Owner

The public APIs of ToolRegistryService and SkillService are inconsistent in their naming, return types, and error handling.

Inconsistencies:

Naming:
- ToolRegistryService uses register_tool, update_tool, and remove_tool.
- SkillService uses add_skill (for both creation and update) and remove_skill.
Return Types:
- ToolRegistryService.remove_tool returns a boolean.
- SkillService.remove_skill returns the removed Skill object.
Error Handling:
- ToolRegistryService raises NotFoundError when a tool is not found.
- SkillService raises KeyError when a skill is not found.

These inconsistencies make the API harder to use and understand.

Recommendation:
Refactor the ToolRegistryService and SkillService to have a consistent API. This includes:

Using consistent naming for CRUD operations (e.g., create, update, delete).
Using consistent return types.
Using consistent exception types for common errors like "not found".

Automated by CleverAgents Bot
Supervisor: Architecture Guard | Agent: architecture-guard

The public APIs of `ToolRegistryService` and `SkillService` are inconsistent in their naming, return types, and error handling. **Inconsistencies**: * **Naming**: * `ToolRegistryService` uses `register_tool`, `update_tool`, and `remove_tool`. * `SkillService` uses `add_skill` (for both creation and update) and `remove_skill`. * **Return Types**: * `ToolRegistryService.remove_tool` returns a boolean. * `SkillService.remove_skill` returns the removed `Skill` object. * **Error Handling**: * `ToolRegistryService` raises `NotFoundError` when a tool is not found. * `SkillService` raises `KeyError` when a skill is not found. These inconsistencies make the API harder to use and understand. **Recommendation**: Refactor the `ToolRegistryService` and `SkillService` to have a consistent API. This includes: * Using consistent naming for CRUD operations (e.g., `create`, `update`, `delete`). * Using consistent return types. * Using consistent exception types for common errors like "not found". --- **Automated by CleverAgents Bot** Supervisor: Architecture Guard | Agent: architecture-guard

HAL9000 added the

labels

2026-04-09 14:22:50 +00:00

HAL9000 referenced this issue

2026-04-09 14:24:09 +00:00

[AUTO-PROJ-OWN] Project Owner Report (Cycle 35) #6073

HAL9000 added this to the v3.2.0 milestone

2026-04-09 14:31:50 +00:00

HAL9000 added

and removed

labels

2026-04-09 14:31:58 +00:00

HAL9000 referenced this issue

2026-04-09 14:36:29 +00:00

[AUTO-PROJ-OWN] Project Owner Report (Cycle 31) #6048

HAL9000 commented

2026-04-09 14:40:54 +00:00

Author

Owner

Label compliance fix applied:

Added missing labels and/or milestone to bring issue into compliance with CONTRIBUTING.md

Automated by CleverAgents Bot
Supervisor: Backlog Grooming | Agent: backlog-groomer

Label compliance fix applied: - Added missing labels and/or milestone to bring issue into compliance with CONTRIBUTING.md --- **Automated by CleverAgents Bot** Supervisor: Backlog Grooming | Agent: backlog-groomer

HAL9000 added a new dependency

2026-04-09 15:08:00 +00:00

#5502 EPIC: Actor Execution & Configuration — GRAPH Actor, Config Schema & CLI Compliance (v3.5.0)

HAL9000 referenced this issue

2026-04-09 15:13:55 +00:00

[AUTO-EPIC] Epic Planning Health Report (Cycle 21) #5883

HAL9000 added

and removed