UAT: wf12_hierarchical.robot uses unconditional Fail as TDD placeholder — not a real E2E test #5999

Open
opened 2026-04-09 13:27:36 +00:00 by HAL9000 · 1 comment
Owner

Bug Report

Feature Area: E2E Workflow Specification Tests — WF12 Large-Scale Hierarchical Feature Implementation
Milestone: v3.6.0 (M7) — E2E workflow specification tests
Severity: Priority/Backlog — test infrastructure gap, not blocking runtime

What Was Tested

Code-level analysis of robot/e2e/wf12_hierarchical.robot against Specification Example 12: Large-Scale Feature Implementation with Hierarchical Decomposition.

Expected Behavior (from spec)

Specification Example 12 describes a supervised-profile workflow building a notification system across 4 projects with:

  1. Hierarchical plan decomposition (4+ levels of subplans)
  2. User guidance via plan correct (append mode)
  3. Dependency-ordered apply
  4. Error recovery via plan correct

The test file has extensive keyword infrastructure (Create Project Repo, Register Project With Invariant, Select Non Root Decision Id, Verify Plan In List) and a 35-minute timeout budget.

Actual Behavior

The test case body contains only an unconditional Fail statement:

WF12 Large Scale Hierarchical Feature Implementation
  [Documentation]    Supervised-profile workflow: 4-project notification system
  ...    Note: ``plan prompt`` (spec Step 4 — supervised-profile
  ...    user intervention) is not yet implemented as a CLI command.
  [Tags]    tdd_issue    tdd_issue_4188    tdd_expected_fail
  [Timeout]    35 minutes
  # TDD placeholder - implementation pending
  Fail    WF12 hierarchical decomposition not yet implemented (TDD placeholder)

This is a TDD placeholder that unconditionally fails. The tdd_expected_fail tag inverts this to a CI pass, but the test exercises nothing — it doesn't even attempt to set up the 4-project environment or run any plan lifecycle operations.

Code Location

  • File: robot/e2e/wf12_hierarchical.robot
  • Lines 115-128: Test case body — single Fail statement

Impact

The WF12 E2E test provides zero coverage of the large-scale hierarchical decomposition workflow. This is one of the most complex and important scenarios in the specification (4+ levels of subplans, parallel execution, correction flow), and it has no E2E test at all.

The tdd_expected_fail tag masks this gap — the test "passes" in CI by inverting the failure, giving false confidence that the workflow is tested.

Definition of Done

The test body should implement the full WF12 workflow:

  1. Create 4 git repos (protos, api, worker, frontend) using Create Project Repo
  2. Register resources and projects with invariants using Register Project With Invariant
  3. Create multi-project action with supervised profile
  4. Run plan use targeting all 4 projects
  5. Run plan execute and verify hierarchical decomposition (4+ subplans)
  6. Inspect decision tree via plan tree
  7. Apply plan correct --mode append for user guidance
  8. Verify dependency-ordered apply
  9. Remove tdd_expected_fail tag once implementation is complete

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Bug Report **Feature Area**: E2E Workflow Specification Tests — WF12 Large-Scale Hierarchical Feature Implementation **Milestone**: v3.6.0 (M7) — E2E workflow specification tests **Severity**: Priority/Backlog — test infrastructure gap, not blocking runtime ### What Was Tested Code-level analysis of `robot/e2e/wf12_hierarchical.robot` against Specification Example 12: Large-Scale Feature Implementation with Hierarchical Decomposition. ### Expected Behavior (from spec) Specification Example 12 describes a supervised-profile workflow building a notification system across 4 projects with: 1. Hierarchical plan decomposition (4+ levels of subplans) 2. User guidance via `plan correct` (append mode) 3. Dependency-ordered apply 4. Error recovery via `plan correct` The test file has extensive keyword infrastructure (Create Project Repo, Register Project With Invariant, Select Non Root Decision Id, Verify Plan In List) and a 35-minute timeout budget. ### Actual Behavior The test case body contains only an unconditional `Fail` statement: ```robot WF12 Large Scale Hierarchical Feature Implementation [Documentation] Supervised-profile workflow: 4-project notification system ... Note: ``plan prompt`` (spec Step 4 — supervised-profile ... user intervention) is not yet implemented as a CLI command. [Tags] tdd_issue tdd_issue_4188 tdd_expected_fail [Timeout] 35 minutes # TDD placeholder - implementation pending Fail WF12 hierarchical decomposition not yet implemented (TDD placeholder) ``` This is a TDD placeholder that unconditionally fails. The `tdd_expected_fail` tag inverts this to a CI pass, but the test exercises nothing — it doesn't even attempt to set up the 4-project environment or run any plan lifecycle operations. ### Code Location - File: `robot/e2e/wf12_hierarchical.robot` - Lines 115-128: Test case body — single `Fail` statement ### Impact The WF12 E2E test provides zero coverage of the large-scale hierarchical decomposition workflow. This is one of the most complex and important scenarios in the specification (4+ levels of subplans, parallel execution, correction flow), and it has no E2E test at all. The `tdd_expected_fail` tag masks this gap — the test "passes" in CI by inverting the failure, giving false confidence that the workflow is tested. ### Definition of Done The test body should implement the full WF12 workflow: 1. Create 4 git repos (protos, api, worker, frontend) using `Create Project Repo` 2. Register resources and projects with invariants using `Register Project With Invariant` 3. Create multi-project action with supervised profile 4. Run `plan use` targeting all 4 projects 5. Run `plan execute` and verify hierarchical decomposition (4+ subplans) 6. Inspect decision tree via `plan tree` 7. Apply `plan correct --mode append` for user guidance 8. Verify dependency-ordered apply 9. Remove `tdd_expected_fail` tag once implementation is complete --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester
Author
Owner

🏷️ Label compliance fix applied by backlog groomer (cycle 64)

Added missing labels: State/Verified, Type/Bug, Priority/High

This issue was missing the State/ and Type/ labels. Labels have been applied based on issue content (UAT-identified WF12 E2E test using unconditional Fail as a TDD placeholder with no real assertions).


Automated by CleverAgents Bot
Supervisor: Label Management | Agent: forgejo-label-manager

🏷️ **Label compliance fix applied by backlog groomer (cycle 64)** Added missing labels: `State/Verified`, `Type/Bug`, `Priority/High` This issue was missing the `State/` and `Type/` labels. Labels have been applied based on issue content (UAT-identified WF12 E2E test using unconditional `Fail` as a TDD placeholder with no real assertions). --- **Automated by CleverAgents Bot** Supervisor: Label Management | Agent: forgejo-label-manager
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core#5999
No description provided.