cleveragents/cleveragents-core

Fork 3

`agent project show` fails to show a project. #590

New issue

Closed

opened 2026-03-05 01:02:10 +00:00 by brent.edwards · 5 comments

brent.edwards commented

2026-03-05 01:02:10 +00:00

Member

Metadata

Commit Message: fix(project): show created project after creation
Branch: feature/m3-fix-project-show-after-create

Field	Value
Type	Bug
Priority	Medium
MoSCoW	Must Have
Points	3
Milestone	v3.2.0
Assignee	freemo
Parent Epic	#401

Background and Context

agents project create project1 appears to succeed (shows "Project Created" panel) but the project is not persisted to the database. Subsequent agents project show local/project1 fails with "Project not found" after multiple retries. This is the same root cause as #589 — NamespacedProjectRepository.create() flushes but never commits.

Reported by Brent Edwards on Day 25.

Steps to reproduce:

cd ~
mkdir data
uv venv
source .venv/bin/activate
uv pip install -e /app
agents init
agents project create project1
agents project show local/project1
# Expected: project details appear
# Actual: "Project 'local/project1' not found" after retries

Expected Behavior

After agents project create project1, agents project show local/project1 displays the project details.

Acceptance Criteria

agents project show local/<name> returns the project immediately after creation.
The project record is committed to the database during creation.

Subtasks

Code: Fix the persistence issue so project records are committed (shared fix with #589).
Tests (Behave): Ensure failing tests from PR #593 now pass.
Tests (Robot): Ensure Robot smoke tests pass.
Quality: Verify coverage >=97% via nox -s coverage_report.
Quality: Run nox (all default sessions), fix any errors.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.

## Metadata - **Commit Message**: `fix(project): show created project after creation` - **Branch**: `feature/m3-fix-project-show-after-create` | Field | Value | |-------|-------| | **Type** | Bug | | **Priority** | Medium | | **MoSCoW** | Must Have | | **Points** | 3 | | **Milestone** | v3.2.0 | | **Assignee** | freemo | | **Parent Epic** | #401 | ## Background and Context `agents project create project1` appears to succeed (shows "Project Created" panel) but the project is not persisted to the database. Subsequent `agents project show local/project1` fails with "Project not found" after multiple retries. This is the same root cause as #589 — `NamespacedProjectRepository.create()` flushes but never commits. Reported by Brent Edwards on Day 25. **Steps to reproduce:** ```bash cd ~ mkdir data uv venv source .venv/bin/activate uv pip install -e /app agents init agents project create project1 agents project show local/project1 # Expected: project details appear # Actual: "Project 'local/project1' not found" after retries ``` ## Expected Behavior After `agents project create project1`, `agents project show local/project1` displays the project details. ## Acceptance Criteria - [ ] `agents project show local/<name>` returns the project immediately after creation. - [ ] The project record is committed to the database during creation. ## Subtasks - [ ] Code: Fix the persistence issue so project records are committed (shared fix with #589). - [ ] Tests (Behave): Ensure failing tests from PR #593 now pass. - [ ] Tests (Robot): Ensure Robot smoke tests pass. - [ ] Quality: Verify coverage >=97% via `nox -s coverage_report`. - [ ] Quality: Run `nox` (all default sessions), fix any errors. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

brent.edwards self-assigned this

2026-03-05 01:26:58 +00:00

brent.edwards referenced this issue from a commit

2026-03-05 01:35:14 +00:00

fix(project): show created project after creation

~~brent.edwards referenced this issue 2026-03-05 01:35:34 +00:00~~

fix(project): show created project after creation #593

brent.edwards added the

State

In Review

label

2026-03-05 01:36:09 +00:00

brent.edwards commented

2026-03-05 01:36:21 +00:00

Author

Member

TDD Tests Submitted -- PR #593

Opened PR #593 with TDD failing tests that reproduce this bug.

Root Cause Analysis

Same root cause as #589. NamespacedProjectRepository.create() at repositories.py:2828-2855 calls session.flush() but never session.commit(). The show command at project.py:832 gets a fresh repo and calls repo.get(name), which cannot see the uncommitted row. The @database_retry decorator on get() wastefully retries 3 times (since ProjectNotFoundError inherits from DatabaseError) before surfacing the error.

Deliverables

3 Behave BDD scenarios (@wip, @tdd, @bug590) -- all expected to fail until fix
Robot Framework integration smoke tests
ASV round-trip benchmark with found/not-found tracker
CHANGELOG entry

Next Steps

The fix for #589 (adding session.commit() to the create path) will also resolve this issue.

## TDD Tests Submitted -- PR #593 Opened PR #593 with TDD failing tests that reproduce this bug. ### Root Cause Analysis Same root cause as #589. `NamespacedProjectRepository.create()` at `repositories.py:2828-2855` calls `session.flush()` but never `session.commit()`. The `show` command at `project.py:832` gets a fresh repo and calls `repo.get(name)`, which cannot see the uncommitted row. The `@database_retry` decorator on `get()` wastefully retries 3 times (since `ProjectNotFoundError` inherits from `DatabaseError`) before surfacing the error. ### Deliverables - 3 Behave BDD scenarios (`@wip`, `@tdd`, `@bug590`) -- all expected to **fail** until fix - Robot Framework integration smoke tests - ASV round-trip benchmark with found/not-found tracker - CHANGELOG entry ### Next Steps The fix for #589 (adding `session.commit()` to the create path) will also resolve this issue.

freemo added the

labels

2026-03-05 03:28:12 +00:00

freemo added this to the v3.2.0 milestone

2026-03-05 03:28:18 +00:00

freemo referenced this issue

2026-03-05 03:33:15 +00:00

agents project doesn't show created projects. #589

freemo commented

2026-03-05 03:33:17 +00:00

Owner

PM Acknowledgment — Day 25 Review

Confirmed — same root cause as #589 (missing session.commit() in NamespacedProjectRepository.create()). Good additional observation about the @database_retry decorator wastefully retrying ProjectNotFoundError — that's worth a separate cleanup ticket if it persists after the fix.

Triage Notes

TDD PR #593 assigned to @freemo for review.
Fix ownership: @freemo — will be resolved by the same persistence fix as #589.
This issue will be retested and closed once the #589 fix merges.

## PM Acknowledgment — Day 25 Review Confirmed — same root cause as #589 (missing `session.commit()` in `NamespacedProjectRepository.create()`). Good additional observation about the `@database_retry` decorator wastefully retrying `ProjectNotFoundError` — that's worth a separate cleanup ticket if it persists after the fix. ### Triage Notes - **TDD PR #593** assigned to @freemo for review. - **Fix ownership**: @freemo — will be resolved by the same persistence fix as #589. - This issue will be retested and closed once the #589 fix merges.

freemo added

and removed

labels

2026-03-05 04:26:37 +00:00

freemo referenced this issue from a commit

2026-03-05 06:18:04 +00:00

fix(project): show created project after creation

freemo referenced this issue from a commit

2026-03-05 06:18:04 +00:00

fix(project): show created project after creation

freemo referenced this issue from a pull request that will close it,

2026-03-05 06:18:16 +00:00

fix(project): show created project after creation #593

freemo added

and removed

labels

2026-03-05 06:49:57 +00:00

freemo commented

2026-03-05 06:50:21 +00:00

Owner

Implementation Notes

Root Cause

Same as #589 — NamespacedProjectRepository.create() called session.flush() without session.commit(). The project show command opens a new session to retrieve the project, which can't see uncommitted records.

Fix Applied

Same database fix as #589 (add session.commit()). Additionally fixed an ambiguous Behave step matcher by renaming "I create a project named" to "I create a described project named" for the variant with description.

Verification

All nox sessions pass, coverage 97%
8503 Behave scenarios, 1196 Robot tests (0 failures)

PR: #593 (updated with fix commit)

## Implementation Notes ### Root Cause Same as #589 — `NamespacedProjectRepository.create()` called `session.flush()` without `session.commit()`. The `project show` command opens a new session to retrieve the project, which can't see uncommitted records. ### Fix Applied Same database fix as #589 (add `session.commit()`). Additionally fixed an ambiguous Behave step matcher by renaming "I create a project named" to "I create a described project named" for the variant with description. ### Verification - All nox sessions pass, coverage 97% - 8503 Behave scenarios, 1196 Robot tests (0 failures) PR: #593 (updated with fix commit)

brent.edwards referenced this issue from a commit

2026-03-05 20:11:28 +00:00

test(project): address review #1977 findings for show-after-create TDD

brent.edwards referenced this issue

2026-03-05 20:11:51 +00:00

fix(project): show created project after creation #593

brent.edwards referenced this issue from a commit

2026-03-06 01:23:36 +00:00

fix(project): address review #1995 findings — fix delete/update commit, docs, tests

brent.edwards referenced this issue from a commit

2026-03-06 01:27:51 +00:00

fix(project): add mix_stderr documentation comment to test runner