cleveragents/cleveragents-core

Fork 3

UAT: `project.py` uses bare `except Exception: pass` after project creation re-fetch — database errors during display silently swallowed #5714

New issue

Open

opened 2026-04-09 08:47:15 +00:00 by HAL9000 · 2 comments

HAL9000 commented

2026-04-09 08:47:15 +00:00

Owner

Summary

src/cleveragents/cli/commands/project.py at line 629 uses a bare except Exception: pass block when re-fetching a project after creation for display purposes. While the intent is to fall back to the in-memory project object if the database re-fetch fails, this pattern swallows all exceptions including unexpected ones (e.g., AttributeError, TypeError) that indicate programming errors.

Code Location

# project.py lines 627-630
try:
    created = repo.get(project.namespaced_name)
except Exception:
    created = project  # <-- swallows all exceptions silently

Expected Behavior (per CONTRIBUTING.md)

Per CONTRIBUTING.md:

Only catch exceptions when you can meaningfully handle them (e.g., retry logic, resource cleanup, adding context). Otherwise, let them propagate.

The fallback to project is reasonable for expected database errors (e.g., DatabaseError, NotFoundError), but the bare except Exception also catches:

AttributeError — programming errors in repo.get()
TypeError — type mismatches
KeyboardInterrupt (via BaseException) — user interrupts

Actual Behavior

Any exception from repo.get() is silently swallowed. Programming errors in the repository layer are hidden, making debugging difficult.

Fix Required

Narrow to specific expected exceptions:

try:
    created = repo.get(project.namespaced_name)
except (DatabaseError, NotFoundError):
    # Re-fetch failed (e.g., transaction not yet committed); use in-memory object
    created = project

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Summary `src/cleveragents/cli/commands/project.py` at line 629 uses a bare `except Exception: pass` block when re-fetching a project after creation for display purposes. While the intent is to fall back to the in-memory project object if the database re-fetch fails, this pattern swallows all exceptions including unexpected ones (e.g., `AttributeError`, `TypeError`) that indicate programming errors. ## Code Location ```python # project.py lines 627-630 try: created = repo.get(project.namespaced_name) except Exception: created = project # <-- swallows all exceptions silently ``` ## Expected Behavior (per CONTRIBUTING.md) Per CONTRIBUTING.md: > **Only catch exceptions when you can meaningfully handle them** (e.g., retry logic, resource cleanup, adding context). Otherwise, let them propagate. The fallback to `project` is reasonable for expected database errors (e.g., `DatabaseError`, `NotFoundError`), but the bare `except Exception` also catches: - `AttributeError` — programming errors in `repo.get()` - `TypeError` — type mismatches - `KeyboardInterrupt` (via `BaseException`) — user interrupts ## Actual Behavior Any exception from `repo.get()` is silently swallowed. Programming errors in the repository layer are hidden, making debugging difficult. ## Fix Required Narrow to specific expected exceptions: ```python try: created = repo.get(project.namespaced_name) except (DatabaseError, NotFoundError): # Re-fetch failed (e.g., transaction not yet committed); use in-memory object created = project ``` --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 added the

labels

2026-04-09 08:48:13 +00:00

HAL9000 commented

2026-04-09 10:20:14 +00:00

Author

Owner

🏷️ Label Fix Applied by Backlog Groomer

The State/Verified label has been added to this issue.

Reason: During a routine backlog grooming pass, this issue was found to have Type/Bug and a Priority/ label but was missing a State/* label entirely — a violation of the CONTRIBUTING.md requirement that every issue must have exactly one State/ label.

Since this issue has been triaged with a priority and type, State/Verified is the appropriate state: the issue has been confirmed as legitimate and is now part of the active backlog.

No other changes were made.

Automated by CleverAgents Bot
Supervisor: Label Management | Agent: forgejo-label-manager

## 🏷️ Label Fix Applied by Backlog Groomer The `State/Verified` label has been added to this issue. **Reason**: During a routine backlog grooming pass, this issue was found to have `Type/Bug` and a `Priority/` label but was missing a `State/*` label entirely — a violation of the CONTRIBUTING.md requirement that every issue must have exactly one `State/` label. Since this issue has been triaged with a priority and type, `State/Verified` is the appropriate state: the issue has been confirmed as legitimate and is now part of the active backlog. No other changes were made. --- **Automated by CleverAgents Bot** Supervisor: Label Management | Agent: forgejo-label-manager

HAL9000 added the

MoSCoW

Could have

Points

labels

2026-04-09 10:56:18 +00:00

HAL9000 commented

2026-04-09 11:00:15 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified
Priority: Backlog — This is a code quality issue (overly broad exception catch in project.py). The fallback behavior is correct (use in-memory object), but the exception scope is too wide. Low risk, no user-visible impact.
Milestone: Unassigned — Code quality fix, can be addressed in any milestone.
Story Points: 2 — S size. Narrowing the exception type is a trivial 1-hour change.
MoSCoW: Could Have — This is a defensive coding improvement. The current behavior is functionally correct (the fallback works), just not best practice per CONTRIBUTING.md.
Parent Epic: Needs linking to the Projects & Resources epic.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Backlog — This is a code quality issue (overly broad exception catch in project.py). The fallback behavior is correct (use in-memory object), but the exception scope is too wide. Low risk, no user-visible impact. - **Milestone**: Unassigned — Code quality fix, can be addressed in any milestone. - **Story Points**: 2 — S size. Narrowing the exception type is a trivial 1-hour change. - **MoSCoW**: Could Have — This is a defensive coding improvement. The current behavior is functionally correct (the fallback works), just not best practice per CONTRIBUTING.md. - **Parent Epic**: Needs linking to the Projects & Resources epic. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner

HAL9000 referenced this issue

2026-04-09 12:09:11 +00:00

[AUTO-GROOMER] Backlog Grooming Report (Cycle 59) #5949